From patchwork Wed Nov 18 18:16:53 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 29031 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9B07BC3355 for ; Wed, 18 Nov 2026 18:18:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 606B66A910; Wed, 18 Nov 2026 19:18:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="XmFJApOA"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A576A6A8C7 for ; Wed, 18 Nov 2026 19:18:07 +0100 (CET) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c67:cdf:7464:6c04:36e4:ee87]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DA04C34; Wed, 18 Nov 2026 19:15:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1795025739; bh=yAZmujjnWHA1vgbAa6C9cnXwIDAqoMsv/Znf6aEg0Zc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=XmFJApOAYDwQDHrr2mJgVjkpSNKuCnlht1gqdPrPIYQ90VVKJi32sz7ZAfmy3nxDa 1Vhw2avsCEN9aW15S6QbymONA0XlGrq33AYuLHLUt2KY48o81XOcUDIK427Er1v97J vZOo90fEy1NMQQnXMQNpUmJwPD1YMIy1t1bTTuts= From: Jai Luthra Date: Wed, 18 Nov 2026 23:46:53 +0530 Subject: [PATCH v4 3/8] ipa: rpi: vc4: Add Bcm2835Params helper MIME-Version: 1.0 Message-Id: <20261118-pi4-upstream-v4-3-93bdc7d925ba@ideasonboard.com> References: <20261118-pi4-upstream-v4-0-93bdc7d925ba@ideasonboard.com> In-Reply-To: <20261118-pi4-upstream-v4-0-93bdc7d925ba@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart , Kieran Bingham , Paul Elder , Jacopo Mondi , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2656; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=yAZmujjnWHA1vgbAa6C9cnXwIDAqoMsv/Znf6aEg0Zc=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBq/evGMYaimxgJmHkh8rHmfVQtqJVy20C2i8wSI TRu+mvoffKJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCav3rxgAKCRBD3pH5JJpx RRFKD/4/SlQVbmr1xxQ4TT4wo1O/NtisZb+x8PYSl34lxZI620Ot0L/DcPGLKIqRfVtl21U4Cs3 bRPZzL09ycDZri9a6Scl9mFebcxCR0BQp6dbzcz2t9sn2zIy8YEAJf74WK4qF9DqQ7cfx7d6utO EuK2i21A9KTDnfDir4T3+A3f1XGnDgJxV2edYLlpnpGVq5W/I7Sd1KqvYVK15jf2bwq5E3pkeGf +IAbheqXgbQqx4Dazmq5GGQiHSnUsRcWKMMjNJW4J+NvuKeFdWwo8ZQZ2r1t5CeD4Z6FnsfPWbp 4aPRHWiU/xkJp2LqBSJ7W3vSrj5Tg0KWyzXnx3/H/K3HZ9L+13UAhwkhsj37SaLDR7c8mI1bl+x 04p+ILVFFGPs6mVTf3ip2NCtB4srVKPEzYju4J812FaHG+ZBezXHt+JeC5DWVPR9Oz5BvrI/k+P /yT1ZxW4uoKE0zYnUkHK76Gu/ehEQHQpb8rDF/3x+jrFOLuVju8BpxOM9Srcvd011JeaW3gM/mE sknkLyTyCfLvIec3UeUfoSYoX0F0xmSD6dDyMzuePP5MstkeaI2G6Is1EV2mqb8T2gSQwJRaZ3J Cu4uk81MBvkLXMOa12ZV+3MD2xe9y6ImqOD8MUnHWNiBrwluQ+PuhEsOZcQPOYWLJGvSfajzQ+t UdCc8HnZReUSqVA== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Implement Bcm2835Params to derive from V4L2Params. The mainline driver uses extensible V4L2 parameter for configuration instead of custom V4L2 controls. Reviewed-by: Paul Elder Tested-by: Paul Elder Signed-off-by: Jai Luthra --- src/ipa/rpi/vc4/params.h | 79 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+) diff --git a/src/ipa/rpi/vc4/params.h b/src/ipa/rpi/vc4/params.h new file mode 100644 index 000000000000..3eb7794e7c79 --- /dev/null +++ b/src/ipa/rpi/vc4/params.h @@ -0,0 +1,79 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2026, Ideas On Board + * + * Raspberry Pi VC4/BCM2835 ISP Parameters + */ + +#pragma once + +#include + +#include + +#include + +namespace libcamera { + +namespace ipa::RPi { + +enum class BlockType : uint16_t { + BlackLevel, + Geq, + Gamma, + Denoise, + Sharpen, + Dpc, + Cdn, + CcMatrix, + LensShading, + AwbGains, + DGain, +}; + +namespace details { + +template +struct block_type { +}; + +#define BCM2835_DEFINE_BLOCK_TYPE(id, structName, blockId) \ + template<> \ + struct block_type { \ + using type = struct bcm2835_isp_params_##structName; \ + static constexpr bcm2835_isp_param_block_type blockType = \ + BCM2835_ISP_PARAM_BLOCK_##blockId; \ + }; + +BCM2835_DEFINE_BLOCK_TYPE(BlackLevel, black_level, BLACK_LEVEL) +BCM2835_DEFINE_BLOCK_TYPE(Geq, geq, GEQ) +BCM2835_DEFINE_BLOCK_TYPE(Gamma, gamma, GAMMA) +BCM2835_DEFINE_BLOCK_TYPE(Denoise, denoise, DENOISE) +BCM2835_DEFINE_BLOCK_TYPE(Sharpen, sharpen, SHARPEN) +BCM2835_DEFINE_BLOCK_TYPE(Dpc, dpc, DPC) +BCM2835_DEFINE_BLOCK_TYPE(Cdn, cdn, CDN) +BCM2835_DEFINE_BLOCK_TYPE(CcMatrix, cc_matrix, CC_MATRIX) +BCM2835_DEFINE_BLOCK_TYPE(LensShading, lens_shading, LENS_SHADING) +BCM2835_DEFINE_BLOCK_TYPE(AwbGains, awb_gains, AWB_GAINS) +BCM2835_DEFINE_BLOCK_TYPE(DGain, digital_gain, DIGITAL_GAIN) + +struct params_traits { + using id_type = BlockType; + template + using id_to_details = block_type; +}; + +} /* namespace details */ + +class Bcm2835Params : public V4L2Params +{ +public: + Bcm2835Params(std::span data) : + V4L2Params(data, BCM2835_ISP_PARAM_BUFFER_V1) + { + } +}; + +} /* namespace ipa::RPi */ + +} /* namespace libcamera */