From patchwork Wed Nov 18 18:16:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 29029 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AF4F7C3355 for ; Wed, 18 Nov 2026 18:17:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4E9306A910; Wed, 18 Nov 2026 19:17:59 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="TuXA+7Bk"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CA316A906 for ; Wed, 18 Nov 2026 19:17:58 +0100 (CET) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c67:cdf:7464:6c04:36e4:ee87]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 433141D18; Wed, 18 Nov 2026 19:15:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1795025729; bh=mdjfOOSJJiRGHbBjH7v6nHv8bNidwHfF5C6q6U1iygA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TuXA+7BkM5/nM0de5zFIR/7uz/a1QIssXCxGH+4ljIqF/TV+GWW+MhZUuhRu5fAEl sShkeJS+J17epQzGxWyVJQbjnc4rhluO5cH0s9s2UUT+IYfLj3y9uRM+7+2PBEaf1S Gw8mY4Iwcd+5a7WkWrO8EIkyXEnd+2Flcd9yZNsY= From: Jai Luthra Date: Wed, 18 Nov 2026 23:46:51 +0530 Subject: [PATCH v4 1/8] ipa: rpi: Drop unused params argument from platformPrepareIsp() MIME-Version: 1.0 Message-Id: <20261118-pi4-upstream-v4-1-93bdc7d925ba@ideasonboard.com> References: <20261118-pi4-upstream-v4-0-93bdc7d925ba@ideasonboard.com> In-Reply-To: <20261118-pi4-upstream-v4-0-93bdc7d925ba@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart , Kieran Bingham , Paul Elder , Jacopo Mondi , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4069; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=mdjfOOSJJiRGHbBjH7v6nHv8bNidwHfF5C6q6U1iygA=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBq/evE7489nVqypnfq9OoQPw3jsi/CchCI9mQqA iUpf8SZgVaJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCav3rxAAKCRBD3pH5JJpx RScEEADTOFWwxm2AyWfsrkG6vLOkwj/NDPGR/AloT53Cy2vx0cfjsvBOiklUKFDYP5ejZxKSH7I i1vvJy7OTmMjiKQll8kNMrDo/BG3QTZgzRxsgzib4M2CV8HOKIM+GlGfwpd8xjyzrGD9LsKr+HY uJoCr9p56wYj3Nq4WMukLi5v0Q69XxTt2ehClxb3K4bUytpucD66qNAxeaw+QUt4mZF6xuDyuvR qGvVihLLFvLeQSoxFlpyDRfcHQ08MaTN/Gv2foZv3V97YwCLe5GS+sa3w3s1GSTIYCfISyXiIWA FjBtDpdOAGyO6xkslSSn7dqEZM/VE73OO+NGfrjX45IusIjwGhB6CNKRWid76G6tXFhsNB3dNYC OpVQxwm1J1tgbwC93jOuAdm5YEG8t68J6FvR1xmlLCUEpwx7i84ji/e0KOJFlRclYrGLzedTd56 fmjsbKC5zm/pvrXprsXvsNIEBzDKnre698xyPOJM2+G1sPfy+lhZTU/1M1C1Js+dgXGplP7AvNR YEHqK1VxvXWXamy0+jt8BA9yP9Ls07aa6ZmvWD3BS+RBLyytNwo56Sbfb1wh6JkJQqCYs/U2iOZ PQxGi0H5V1Lh86TbVW0aL1EKXTK0SOgcbyeXr5xTJ1HZBRlzj4dAc7CocANEoaYnqK4BRy/tyOy WhdDTqFQ++bUHMw== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In IPABase::platformPrepareIsp() we pass PrepareParams but none of the IPAs (vc4 and pisp) use them. So drop it. Reviewed-by: Paul Elder Tested-by: Paul Elder Signed-off-by: Jai Luthra --- src/ipa/rpi/common/ipa_base.cpp | 2 +- src/ipa/rpi/common/ipa_base.h | 3 +-- src/ipa/rpi/pisp/pisp.cpp | 6 ++---- src/ipa/rpi/vc4/vc4.cpp | 5 ++--- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index c284834440c8..2ee28c9a5005 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -501,7 +501,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms) if (processPending_) { controller_.prepare(&rpiMetadata); /* Actually prepare the ISP parameters for the frame. */ - platformPrepareIsp(params, rpiMetadata); + platformPrepareIsp(rpiMetadata); platformPrepareAgc(rpiMetadata); } else platformPrepareAgc(rpiMetadata); diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h index 0d7842f1f742..1c375669c9f7 100644 --- a/src/ipa/rpi/common/ipa_base.h +++ b/src/ipa/rpi/common/ipa_base.h @@ -87,8 +87,7 @@ private: virtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0; virtual int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) = 0; - virtual void platformPrepareIsp(const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) = 0; + virtual void platformPrepareIsp(RPiController::Metadata &rpiMetadata) = 0; virtual void platformPrepareAgc(RPiController::Metadata &rpiMetadata) = 0; virtual RPiController::StatisticsPtr platformProcessStats(std::span mem) = 0; diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index 835934d57897..ed31867786f6 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -232,8 +232,7 @@ private: int32_t platformStart(const ControlList &controls, StartResult *result) override; int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override; - void platformPrepareIsp(const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) override; + void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override; void platformPrepareAgc(RPiController::Metadata &rpiMetadata) override; RPiController::StatisticsPtr platformProcessStats(std::span mem) override; @@ -354,8 +353,7 @@ int32_t IpaPiSP::platformConfigure([[maybe_unused]] const ConfigParams ¶ms, return 0; } -void IpaPiSP::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) +void IpaPiSP::platformPrepareIsp(RPiController::Metadata &rpiMetadata) { std::scoped_lock l(rpiMetadata); diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index 122657b2d0a8..298cf8829258 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -59,7 +59,7 @@ private: int32_t platformStart(const ControlList &controls, StartResult *result) override; int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override; - void platformPrepareIsp(const PrepareParams ¶ms, RPiController::Metadata &rpiMetadata) override; + void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override; void platformPrepareAgc([[maybe_unused]] RPiController::Metadata &rpiMetadata) override; RPiController::StatisticsPtr platformProcessStats(std::span mem) override; @@ -144,8 +144,7 @@ int32_t IpaVc4::platformConfigure(const ConfigParams ¶ms, [[maybe_unused]] C return 0; } -void IpaVc4::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) +void IpaVc4::platformPrepareIsp(RPiController::Metadata &rpiMetadata) { ControlList &ctrls = ctrls_;