From patchwork Wed Nov 18 09:57:25 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28981 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D9A38BDE17 for ; Wed, 18 Nov 2026 09:58:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7BFEA6A8F9; Wed, 18 Nov 2026 10:58:26 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="M5+J+LQC"; dkim-atps=neutral Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BA116A8C8 for ; Wed, 18 Nov 2026 10:58:08 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-490f38e9688so435375f8f.0 for ; Wed, 18 Nov 2026 01:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995888; x=1795600688; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=axyCX8IRvg1Maa6h/NSfsasoGZ5fBp4secxjSuJ9foo=; b=M5+J+LQCjFzhSnkRkFT3UA+9aTuDyhP1/5x0AEIThdlwKmtD9ZAZFIkL77OmMEPpo1 7ZTm6TkTuQEu1+EzfwjTgxmeqSa3qIzQmAznnv3axJCT6fS3H/7KeT6fH8nq4Q0nXI6x TxpoqKARF27E6UB1C76WAF9ChR6BEv9If3VOUENxYfPJ4wZw8C3lZ8CzJ8f4NF579jfg H0AU8CsrWMG+MHsFAsIgz4qTI4GOhxdM2vBc550mUSFJgFP8aip+uwHl363b5d792vDn xgbGszXP119Pnb6+1JChXEVMsNeruVrZdpGKFWVC+vDRzl4FyuPtT91yRtFnNCYBK04g ktzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995888; x=1795600688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=axyCX8IRvg1Maa6h/NSfsasoGZ5fBp4secxjSuJ9foo=; b=ppaJhaaLR+ZmmkbNaSfnDptamHcMpE5UMV3ew8STP+cZyzKVeEHtyXHqmhASVIgoYI u7kZvdig8PzC1lurAzLd/B4m4F2E1m3tdLsXwXYx6LCwxzOtcpIHEaNTci66Wna36B/s AB8Cz60yiUORyhuQ/Bf2vQzy2eFNBNC2p/e2GY328i9UW0DBEekzxPg6bWytMZaGqKNK 9OKtW4rDhH1p6KGdCj/oBlNh41sS1OtIksqkd42ejISpxnpZ4zVZP32E9P8hXgD6COXs PNx+uRapXAaDTIQMBovWsTepKv4NsC5GK7pwVwuu80RHywhmT/qICkRNOafVIg3qZlPb vVrw== X-Gm-Message-State: APuU4Z+LIt9yNLRohBWjAPsvl2/aO+z9ZAXKrD8XZJoKGiClFcd9sZda OvQUh6oq0Lk+IfZZo5dex/zrzMwfN4r3CIMb8MxsVfizHsRVH2er5f7nPiqRyJdgacpPSLl3hxe x8V/fOwk= X-Gm-Gg: AZFdTZfSvljxf7G4TLolOgSfxTdT0UYONhaC+qJ0aOMJrbqzebXBKfgncFeqBkMQPUN uSM0Zbh4GXaGWds3/XX47zOsV2z2cXs2crg5o9AXN4Pm37egq1eziXifTinnJ2v3GPYnZxZ/fID ++3wyuP20fHUgcmIIAaumQq9ApKRmOpxVQQhKu8DKluqz5fNqoDHmPgfD157QhnHH/JfMqkgHD2 6I9PEeqgsXQrjHJ2jKcqEmLOOiA+Ju4NQWJLye4ijJl3lHmH6uE1QziiKirFYcqcfq8mAnS9K5Z qydpasCH6c2rtzOXiXnxW8MVErMxvJ3c7bCrwjycx6sVI2b5Pk1S++8ZY3mwIq9FZ8ePOoihSdz iPY506ruL8q/YIS0LsckJBBVYSmVeJpFTCIzbkaldlblJBXvQabwK3Qh32ggc3DXgLjKSZ65ypE 5jrAJko8NcX9esq78Kr5bQhh4+6Q3n5yLAcxjCQE2MIOGMIVhdk10lKhtm98IdbK1p9AOeFfVlh A32FHQd9O+I7sec0iFM18f8nAVAjyeEGazVjM4NUri0FeE5oTGHFV2ekq/LTje7wxFQjcmaWCTY fen3zDPBrs+iZRvg4MUJpVyoIIFVMUmSUGH8KFzqbArycQ== X-Received: by 2002:a05:6000:200c:b0:4a7:9630:7b36 with SMTP id ffacd0b85a97d-4a796308082mr1482998f8f.21.1794995887554; Wed, 18 Nov 2026 01:58:07 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:58:07 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 18/26] libcamera: shaders: bayer_glr16_to_rgba.frag: Make fetch() into a function Date: Wed, 18 Nov 2026 10:57:25 +0100 Message-ID: <20261118095735.170587-19-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Do some simple functional decomposition to make the subjectively ugly define into a function. Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/bayer_glr16f_to_rgba.frag | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/libcamera/shaders/bayer_glr16f_to_rgba.frag b/src/libcamera/shaders/bayer_glr16f_to_rgba.frag index 4a2e5af87..0b2db1d7a 100644 --- a/src/libcamera/shaders/bayer_glr16f_to_rgba.frag +++ b/src/libcamera/shaders/bayer_glr16f_to_rgba.frag @@ -37,12 +37,14 @@ float apply_contrast(float value) return 1.0 - 0.5 * pow((1.0 - value) / 0.5, contrastExp); } +float fetch(float x, float y) +{ + return texture2D(tex_y, vec2(x, y)).r; +} + void main(void) { vec3 rgb; - /* Sample from R16F input texture */ - #define fetch(x, y) texture2D(tex_y, vec2(x, y)).r - float C = fetch(center.x, center.y); // ( 0, 0) /* Which of the four CFA phases are we on (0 = even). Same as McGuire. */