From patchwork Wed Nov 18 09:57:23 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28979 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 70B1DBDE17 for ; Wed, 18 Nov 2026 09:58:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A50CF6A8E3; Wed, 18 Nov 2026 10:58:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Kv+oseTc"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BB24F6A8BF for ; Wed, 18 Nov 2026 10:58:05 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-48dee593f18so582624f8f.3 for ; Wed, 18 Nov 2026 01:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995885; x=1795600685; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kmd73Zvt6PWfdw34Ciy9RdsHEmOxMQ4QVnZVG/eb6i4=; b=Kv+oseTckpRzTK0Zp8slhNjLHtM+PmN3lPPFpmexDWW+Wp2ZeTK5Sp1UVDpjpFi9E3 dxkXH+xWqLJJmSlmSQJ3TjDjuJkljtLUvqyJTy0BGkUIeiu/b/KvxS1xc8e5fNMtHU6R cH39aVgjROzU+dJpDimbwfKNv62BH9kST1MEMkpuzCygtS651yLAf4dMwS/PdFsFKURY eyFBtnhdPvHlcgfY+js8X7t/yrJt2igbEAu4yl9bvOOFTgbJ7VR9hrin/9YAcTQHWdUW HzIXTa6jUxf8W6aky/Dlt40mEMHlOPoQtLEXoqUOEMc6wZ0GqksLErC6PwwISCtZiEAW UOug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995885; x=1795600685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=kmd73Zvt6PWfdw34Ciy9RdsHEmOxMQ4QVnZVG/eb6i4=; b=oCnw5kK+VNnMajSU3KdUKddNRQ7L4SUTfwOZX6k9n5KgjwYnA3cd6tnhgJ8ZUGgfpI SZjoBtal8F+DrZ/SxrlvH8ZzELjx3xAe/mfrdJaRngkFbkfLQ5pmximMQCeGKkC93cTP HPRi/Ffk1N2g4l3axs6YGmXN2/UMRTZxniQfnhl9KhEniuLBy7Ynan1I6f7ebeaWdQTM R9XMS727c898djFGpHLqTXS2Da2gm256JED+x7ZxxEyxxjVa1+F+W3NO7uu+gbOk8O85 ZvYeKm0UZDk+R4DGIDLpnTmebgh6a6kXhJkrlwIkeGQ9vMcym84TimWZUZRvUUr8kokD iyLA== X-Gm-Message-State: APuU4Z+fFZ853WZ0ScnYoOfrze5siSfwF9GpR8X9E2Dgaiza2HTHUnl7 hgoZC24sK+ZCfgruy0BM5RagT1GCzF+MxPUnkmGw1koxxLgNO2+LOrnfg7SCzwBUmY+buANHZbf kbG9eo5M= X-Gm-Gg: AZFdTZd48bQcyJ9ajd4wAKGYfXezoi2epvzDEcnxxDTP1a0NacePUUvO+B1d6U6ZWJD Zho9ahMmKSxZO8eHunQccvbXvJbS22K0Pal43Bjn8yaxeoDC8ENdBHs3Ps++hhEjTu9/8faLYTo KiGoJTy9FonJ3HBz3e8wE/efCIm2NkCzNzrcvrOBW73X7LLdTHyZ0o17GFWCFFA7WaeYa4VEk8F o31PxMXaK+wGz2ZCgSh/Riqx4VMMbYoIFuL4vA7RvKKWhfiV9DNnoZ3VXIMxLect8GL+NBD0wD7 1ZkoXsYnrJaRYxCuBUxIf5LDuzYz9v9FfhKhLb3hWV+d6my3rAKiKMLQSpry1AgXdI0XZTMPKzP Cx+TJixwkNnqu5B+3Ohe4rJ4xfdz7frxO2tNfqpZLlyaBhI2Bg3n2rHM+4A+1UW/Hn/u9GKRCI0 2P4nZpzasihXJuqTkUNmLZSPv91rOwekIkp16USK/cqLyLBhWSdqeJ+Rmqo8CUQsV34/h0gauGy xnhwfbT586XNEh9/SqIDOcVka1aWUXyMs+rX06dItHk1bXJ/VqquSjO1uxTK8j0whks+O+Pg+V2 fIBcGG5HUNXc0HFsnO8pxd05C3cNB1Vwi1mECXwXcKeMiQ== X-Received: by 2002:a5d:5888:0:b0:492:46e:d4ce with SMTP id ffacd0b85a97d-4a63833821emr4143873f8f.13.1794995885242; Wed, 18 Nov 2026 01:58:05 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:58:04 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 16/26] libcamera: software_isp: gpu: Include GpuIspShaderPassBlcNormalise in init sequence Date: Wed, 18 Nov 2026 10:57:23 +0100 Message-ID: <20261118095735.170587-17-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/software_isp_instance_gpu.cpp | 8 +++++++- src/libcamera/software_isp/software_isp_instance_gpu.h | 2 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp_instance_gpu.cpp b/src/libcamera/software_isp/software_isp_instance_gpu.cpp index 85820b267..ba364516f 100644 --- a/src/libcamera/software_isp/software_isp_instance_gpu.cpp +++ b/src/libcamera/software_isp/software_isp_instance_gpu.cpp @@ -43,7 +43,7 @@ namespace libcamera { * \param[in] display The EGL display to use */ SoftwareIspInstanceGpu::SoftwareIspInstanceGpu(std::unique_ptr stats, const CameraManager &cm, EGLDisplay display) - : SoftwareIspInstance(cm), stats_(std::move(stats)), egl_(display), gpuIspShaderPassDemosiac_(egl_) + : SoftwareIspInstance(cm), stats_(std::move(stats)), egl_(display), gpuIspShaderPassDemosiac_(egl_), gpuIspShaderPassBlcNormalise_(egl_) { } @@ -99,6 +99,12 @@ int SoftwareIspInstanceGpu::getInputConfig(PixelFormat inputFormat, DebayerInput int SoftwareIspInstanceGpu::initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat) { + int ret; + + ret = gpuIspShaderPassBlcNormalise_.initShaders(inputFormat, outputFormat); + if (ret) + return ret; + return gpuIspShaderPassDemosiac_.initShaders(inputFormat, outputFormat); } diff --git a/src/libcamera/software_isp/software_isp_instance_gpu.h b/src/libcamera/software_isp/software_isp_instance_gpu.h index 9da9e717b..95cbea566 100644 --- a/src/libcamera/software_isp/software_isp_instance_gpu.h +++ b/src/libcamera/software_isp/software_isp_instance_gpu.h @@ -29,6 +29,7 @@ #include #include "software_isp_instance.h" +#include "gpu_pipeline_shader_pass_blc_normalise.h" #include "gpu_pipeline_shader_pass_demosiac.h" namespace libcamera { @@ -87,6 +88,7 @@ private: uint32_t height_; GpuIspShaderPassDemosiac gpuIspShaderPassDemosiac_; + GpuIspShaderPassBlcNormalise gpuIspShaderPassBlcNormalise_; }; } /* namespace libcamera */