From patchwork Wed Nov 18 09:57:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28976 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9F3C1BDE17 for ; Wed, 18 Nov 2026 09:58:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id ACD956A8D5; Wed, 18 Nov 2026 10:58:16 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZlLYC/Zg"; dkim-atps=neutral Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 439D26A8C4 for ; Wed, 18 Nov 2026 10:58:03 +0100 (CET) Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-492690dd5daso527982f8f.1 for ; Wed, 18 Nov 2026 01:58:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995883; x=1795600683; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c8RUvlmpAN9QONOJLKGBt/PTTZXJVrwK7+Zl+r8/8Ck=; b=ZlLYC/ZgXbSlkAvlU8Lkqfg6CH+bDvDWCIU0htGqjD2JNfz6OwAObJTz1wWGYjLmAi y+FybUZnE8JQNPJmPKG/UzOaeNrLSBu9KYWNob29vzY2gvPzR5LMmwWj0JVYABI1XxoT HzyrxZwgZxF79vUediohOj2Lp3+IgNtHM9GyvPMaGFJAwqWU8zwRuDo2NwA7gPHw/AHP oht45KLKmjMczG5C+Ni9mzL4Bfzauqy84EpRHfvbIm7XUCyaFx1tf2ttGWTE5al04EnN m5QrI9r5aEJD3Z8dfmYmn8ldLOd9qO2FaHb53trbDqD8lDdF0eg48ujraOVzB53OhoaM ebgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995883; x=1795600683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=c8RUvlmpAN9QONOJLKGBt/PTTZXJVrwK7+Zl+r8/8Ck=; b=YllHLEHigfNxZf7PTpb4R28ajVVf/SrcWx9vGd3qvQsA7ffDRspFeSl6E54Ni6Vc/a LnofWJcihC+xRIhcWAQeDRXvJFViAYfPn9x8KetM/N+amSadW7QBy1IVUX1Sl9INSXei PXU9CxeKxCTxWz25RoXeOq1VNWy8vL88HZ0zMqbUbtYy/CxpIhQbpgbn/OO0n7jsXp0h 6HcWRXEBSdQgYqr6X7yyzYQbQYtt7A6QL7bwYzfL4Cr0dguq/H7EmE5ANkRqDoZS0WOE bkTQhi3ZLK1B3yJ1gkKkf5c+riTE2D9/qKKXVLHszMGJ6qyAfeGUrKqS/+AT0aXcpXxr RO1w== X-Gm-Message-State: APuU4Z9I7KF/b1Lm18HyYMtu8w6qNFexBNgfIALEVLmUrdBjZhzKUkTA 7XpZwCGXweQDPT7mEvzQblYlgAQMf+SVOrU7pZ7QyTTwkAo/PnECzgzMFJAK2HYt33UqVxHmjeE R2y3qDWc= X-Gm-Gg: AZFdTZcErjDNMqPU9ZvxjTZvmc3+CEBkKl9w+z+09sN43B12SmsI6SCMKJ9YJ/ECOAs SGbRIhJmCrAIPNRXxWXdDAD2L/u8oo9Zfu1Y2/mcp8Pzuuvr8YW98z8/GeRCVkSL5fDFH1wIVYl 5w6uLrFFXneoARdMo7bnDjxjwbPehJnKhwk1Y1Q/Q5Tv6P1RiKwToZd7z6F1rdJPhrI5at9CGeW oRxa5rEBclUF93KCIQJNTBx/X623X41i9bk3tDcMCEMZD0gLpjCOd6tvQN2OUbkxpyQ4UD8a+pa QyPjb4j6tCFEDraVIOj2YvD7Av5SgVJowzOlJKx6sfSCf9gpHCu5x3DbFdb6XnPXbj3qsBmhv93 Kx60xibu7O8eMXsxZXcDgyt2uOvdh8dlYF+7n+SQCB6VwiAZaZ0Cxi6OCPPOjstDaovCFM64Lij XkHscsZEq/5BkBUx0qmKRv4XfBBOjF6XLBYPBVjZhtXc2ImYnELOMvV+6nf8dSlAqwYUDzqwFvs tLRkxYkxndOgNGCfwLywdqMBpeD5Kyh/l7q1HQ01T5DrDr27GQZnQfsWrYiRMFn6TrtMOq+eewI HBCqIK8Dqww99Gy90tMoHOxbSBSbGnOjm0Yi15HuAVjVDQ== X-Received: by 2002:a05:6000:4812:b0:491:49c2:3b3 with SMTP id ffacd0b85a97d-4a63bea7c57mr4419991f8f.51.1794995882763; Wed, 18 Nov 2026 01:58:02 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:58:02 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 14/26] libcamera: software_isp: egl: Use Texture Unit 3 for final output texture Date: Wed, 18 Nov 2026 10:57:21 +0100 Message-ID: <20261118095735.170587-15-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We will use ping/pong buffers as intermediary steps in the GPUISP pipeline. The last texture should logically be texture unit #3. TEXTURE0 = Input TEXTURE1 = Ping TEXTURE2 = Pong TEXTURE3 = Output We don't have ping/pong yet but in preparation make the small change to TEXTURE3 for the existing output framebuffer. Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/software_isp_instance_gpu.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/software_isp/software_isp_instance_gpu.cpp b/src/libcamera/software_isp/software_isp_instance_gpu.cpp index 5c473948c..31b57d2a0 100644 --- a/src/libcamera/software_isp/software_isp_instance_gpu.cpp +++ b/src/libcamera/software_isp/software_isp_instance_gpu.cpp @@ -292,7 +292,7 @@ eGLImage *SoftwareIspInstanceGpu::getCachedOutputFrameBuffer(FrameBuffer *output } eglImageOutCache_.emplace_back(fd, std::make_unique(GL_RGBA, outputSize_.width, - outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1)); + outputSize_.height, outputConfig_.stride, GL_TEXTURE3, 3)); eglImageOut = eglImageOutCache_.back().second.get(); if (egl_.createOutputDMABufTexture2D(*eglImageOut, output->planes()[0].fd.get())) {