From patchwork Wed Nov 18 09:57:20 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28975 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E9A06BDE17 for ; Wed, 18 Nov 2026 09:58:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3CA0D6A8DD; Wed, 18 Nov 2026 10:58:15 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="G1nIG0c5"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CFA26A8BB for ; Wed, 18 Nov 2026 10:58:02 +0100 (CET) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4a2153c8525so5707095e9.3 for ; Wed, 18 Nov 2026 01:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995882; x=1795600682; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oMLh/FIhxkunl1diVPilsxfc7As/nKsyOr2DfYKotSw=; b=G1nIG0c5zd2+Q36wnRh+4bD+UpOLLU8VVNn/tAveQILODzNziw9T1FbqQkeDgIjyRe Ho0kZevusdy9wo3ux/DSVIh4FPdnGJgaOhwXWA/V15hdGWy8/1opzifz0lG1MdLeh4el XY7gmlSBB2PhWrvknv/CxJrJKJ7RG6Pl4/VDXvmEPxlovEHohpnNtXJVsYn5ITpwO0xa C2dE2doFGJwgAHnAZHNjwHzRRJ6i7aEINvKf56CUd+rz2doGkU7u5zG1ZTkc11x2mZRf YyqobRJCVxTvjtWvqGxCzgedSOX/UsR4KaP86+K9Xxe3CM5SFLpGPf/+zIuQ4OtaxvNj g+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995882; x=1795600682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=oMLh/FIhxkunl1diVPilsxfc7As/nKsyOr2DfYKotSw=; b=Wz3KlqKc81XjRQHJ0Qf0hRx3q+MThr2Dz27ADrhSyzbyk9JK2bDTcHnTAiDC2w6viz mSCHb/sfIehCEGcYWYbBnFms3IXB6lhpHTEq5S583j0MbkqhY+qVei3IJP+AnnmbcGmA dNqDD2Y/Txzf/56qgEeykECxBF7gMx3Ejd3Z2jqRt76lCiE8Ql4qnHq+Kucsl/EfXlU5 r8nYxzXn28GyC3c1y+OU0vKia5Ukv8e95DR0lKcRgSqkH3hCsLHxgFEKghgGhIBSutT1 n14c+nwf81VlCYAaK34pAQ4YBq2UYL4CZSRZZFNJ+GFsSJdODsAn4zcPGNChmUg7B3ck /+Yg== X-Gm-Message-State: APuU4Z9KpsLfKjBR9oEgEm2rsLAxJBCjGbkGDMA2LBbs5xys8AFxlf0e W6+Zo2MQWzk2c61ZEG0G6chMj/h3qE022m23IN5SG5gmzyA2irAEfc62Kw1WZAzIGNhVAVXnteP Gu7awvSs= X-Gm-Gg: AYBFou3HIGAvvLSWcwfjtV+84zNa1AlCwUldj+3pD5FlbSAfEKgQOwQy7MnZEHULbb9 wO7R9u1XSCew1S2cV91Jj4eKpxDCpofGxq2KYgnziBYNj2ZbWfF1scV2Cd+p5ad4bLFRbANwyk5 zFBvaRYSptxKKptLVOX88XPupZQASRvUW9SLA7fVbzsjnCTEkvf4LEQdfsm8eI2adIE7o1hzyiW SVvIF1W6u0/ZpL8LIjZUuUpvwflj83vPKlX1BXG/gfdA5TI80XnDDGfsoPSnd8cpU/qGYjvfOT0 0qWql/FYdumUTTvoeF+3AmFbQaroOz2Fl/uq15jgh9YrKlnh+EkNcvr27ZVJVG+qrgNVPjBZV2c gX1tXQqE0UQDmJ58x1kDJ61Mrvog4Ydgkvhk+6V7PjUS7qmS2szbjS60vSwadtdzLARHCBS1gwv esLBWQCRTc2ahbcp8sbPsF89HG7mLcTQ6Q6LEcTnpRWhrvzzkc5ObvfeYcMAGEq0Z1dba1xJrHD C6lLuaTxBC9f1E+Dkc9rwovoThtZro1JW4LHtYP2sMsRTwdwyz7CxnT+DohcxBZALMO24xBVUaS LNOKcJh06+JjeBeHVNm5UulHo5/jQdU1xad+QWXjaLir7g== X-Received: by 2002:a05:600c:b99:b0:4ba:6d8:dfad with SMTP id 5b1f17b1804b1-4bb7da1aa22mr36743825e9.14.1794995881584; Wed, 18 Nov 2026 01:58:01 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:58:01 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 13/26] libcamera: software_isp: egl: Extend eGL::createTexture2D to understand floats Date: Wed, 18 Nov 2026 10:57:20 +0100 Message-ID: <20261118095735.170587-14-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Bryan O'Donoghue --- src/libcamera/egl.cpp | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index ff9e54a19..b5337ccd7 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -288,12 +288,31 @@ int eGL::createOutputDMABufTexture2D(eGLImage &eglImage, int fd) */ void eGL::createTexture2D(eGLImage &eglImage, const void *data, GLint filter) { + GLenum format; + GLenum type = GL_UNSIGNED_BYTE; + assertThread(); activateBindTexture(eglImage); + switch (eglImage.format_) { + case GL_R16F: + format = GL_RED; + type = GL_HALF_FLOAT; + break; + case GL_RG8: + format = GL_RG; + break; + case GL_LUMINANCE: + format = GL_LUMINANCE; + break; + default: + LOG(eGL, Error) << "Unsupported texture format " << eglImage.format_; + return; + } + // Generate texture, bind, associate image to texture, configure, unbind - glTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, eglImage.format_, GL_UNSIGNED_BYTE, data); + glTexImage2D(GL_TEXTURE_2D, 0, eglImage.format_, eglImage.width_, eglImage.height_, 0, format, type, data); // Nearest filtering glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, filter);