From patchwork Wed Nov 18 09:57:18 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28974 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BF275BDE17 for ; Wed, 18 Nov 2026 09:58:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 481FE6A8D8; Wed, 18 Nov 2026 10:58:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="RzbEt1Ti"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 124FB6A8C7 for ; Wed, 18 Nov 2026 10:58:00 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-48e3b22e971so345889f8f.0 for ; Wed, 18 Nov 2026 01:58:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995879; x=1795600679; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BN4LTS/k0y6tXF/ATICS4zHlVufchr5Lxm0QV4AgHrc=; b=RzbEt1Ti4eGYtf1qL/xFRN/05YbYtiC/K/HugXE6kejHF5jpY4QuClEVNuvnGMJCtH TmU8iRhZUtPhyX2Us/gcbEW9JAvL3Gni8Vw+WiPZtvAAuvgEznwILEyVar/3h+4GulPH ZITywacrjaGtZa5IoYddA0GhCQu7/elr/xeeJLnvkmGxpjuB3sGBBHKgFAUn6CTPctRv wMYNJUJc2jIYF/6wccf0oNkT5a/skkPhMICspO8UE+zAgClpxuk508JlXGhApEyK8xSO BgU+Mr6uwfbNVLEWMprJbIcPRyb/uFt4l2Nfo3A6KeubjjYbcuTL03OWt8gG5LG22YFk ZZRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995879; x=1795600679; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BN4LTS/k0y6tXF/ATICS4zHlVufchr5Lxm0QV4AgHrc=; b=u5SmaAX/ShpLlrQKmGD7LIjwvzM00jBGoxdYPMeVLVX4LmdfWk5EhGhG8LAA+M1Y4e 4LvPhEzSxGULwgfrTbw1Qppdv0Dj+d3zdZUA7iZAC37UNhDaQbjqKRmbyAxvnm9GCgiq gwYZgETHhzhC1xRxIQHoV3taSKlJzNFerTSdRmGym7ex+/BbQ1V8qG8IcM4sFmzlNZqS Ih/3IIrEK6LXvYM+3HqTOEjFU0x4Oq/vgvfZLd+Xigj+hl4Emto6tDVm0mHkXsuaLkAO uKmTCoRCQA/YzWaH7hZKmIG03xNQUrPZrV/xg5qOOn+DYohtyW7kgQTNBPpejUPC7d2N urdQ== X-Gm-Message-State: APuU4Z8xhmlq7eLoVsOaICMo//NgX7fSuNRwwhWZ2n3uU3NiaAi908Hw O6+fS+bVfPWrFaQ6PgGfiC9MDRhSlo91rTFLJGjf7DIurdJ6sVVWg0rJ2D/P5h6cXMAYSNeITvU PBltTtBk= X-Gm-Gg: AZFdTZfMQdXnrUL5+JguVf6NQNY70fBd9xQMR4eyMZGwN8RdfHhExtrbKN1bTORlsDE 5FCtD/SeoqrW1j/b50BgOTuLUCmqhKXTcQS3C5JRM5ft1D5B1j+Xm5hxswP/2UdYvzN4v7KaFsJ 11edrBPauy3q+5xFjvE8HUvETgHwKpqbhHyLyvD1sYmjK34paMgyHIA6zHGwvYyD2WPLOb9cGZe lj59wYHQ37RlKxBY3sXtBb9EoBKkzA0a6PgTbLOBwoCTMQ6/QMxA0Ig6rso+F2TF/piSCgQ9e7o EDOLgYxYevLtgnaUvse7Gy0qxfAPGsbwJYT3Uh+Qaa7EB9BG3htbkjy+Q4VzdZsIs3hRtYEsJyZ 6Ax767D5pXdH5rKy/KmAI3AeZCsR2sQDzKtNNjqb6/rOIGPB6a7Xs0q7mEjn3+gHKah9RZ8MeIK VoFkokrcyJFA14FdO1aPmKDzH979R3Cli0/viDdIaro8Zv1o9jT9NryGrUCgbi2FpqCpYhjCziR lVRQ3+4HnGl5bcoRmbTKZjiJcfGqX4dog5E8NaUPxj8oa1j6oQT+WEYG/NuALEEN0mrpIORKvYM 5lZTTw2u2MjO+5no3c2+aiSlRKlZ0V/PVoiUalfmt76llQ== X-Received: by 2002:a5d:6f19:0:b0:491:286f:8e63 with SMTP id ffacd0b85a97d-4a639940d10mr4663747f8f.14.1794995879577; Wed, 18 Nov 2026 01:57:59 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:57:59 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 11/26] libcamera: shaders: bayer_{1x_packed|unpacked}_to_glr16f.frag: Add blacklevel correction to bayer domain shaders Date: Wed, 18 Nov 2026 10:57:18 +0100 Message-ID: <20261118095735.170587-12-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" We want to do our black level correction in the bayer not the RGB domain. Implement the BLC in the first-pass Bayer domain shaders. Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/bayer_1x_packed_to_glr16f.frag | 4 ++++ src/libcamera/shaders/bayer_unpacked_to_glr16f.frag | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/libcamera/shaders/bayer_1x_packed_to_glr16f.frag b/src/libcamera/shaders/bayer_1x_packed_to_glr16f.frag index 57814dc49..418a9e063 100644 --- a/src/libcamera/shaders/bayer_1x_packed_to_glr16f.frag +++ b/src/libcamera/shaders/bayer_1x_packed_to_glr16f.frag @@ -55,6 +55,8 @@ varying vec2 textureOut; uniform vec2 tex_size; uniform vec2 tex_step; +uniform vec3 blacklevel; + uniform sampler2D tex_y; void main(void) @@ -89,5 +91,7 @@ void main(void) float C = texture2D(tex_y, center_bytes).r; + C = (C - blacklevel[0]) / (1.0 - blacklevel[0]); + gl_FragColor = vec4(C, 0.0, 0.0, 0.0); } diff --git a/src/libcamera/shaders/bayer_unpacked_to_glr16f.frag b/src/libcamera/shaders/bayer_unpacked_to_glr16f.frag index 00ed47ce8..dadfbd5e2 100644 --- a/src/libcamera/shaders/bayer_unpacked_to_glr16f.frag +++ b/src/libcamera/shaders/bayer_unpacked_to_glr16f.frag @@ -19,6 +19,8 @@ precision highp float; varying vec2 textureOut; +uniform vec3 blacklevel; + uniform sampler2D tex_y; void main(void) @@ -42,5 +44,7 @@ void main(void) float C = texture2D(tex_y, textureOut).r; #endif + C = (C - blacklevel[0]) / (1.0 - blacklevel[0]); + gl_FragColor = vec4(C, 0.0, 0.0, 1.0); }