From patchwork Wed Nov 18 09:57:11 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28966 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 013C6BDE17 for ; Wed, 18 Nov 2026 09:57:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7075C6A8C5; Wed, 18 Nov 2026 10:57:58 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="GBpVe0cr"; dkim-atps=neutral Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 202036A8BD for ; Wed, 18 Nov 2026 10:57:53 +0100 (CET) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-4a42b34e930so525551f8f.2 for ; Wed, 18 Nov 2026 01:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995872; x=1795600672; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RQVwgEVHMuFWrXov8O0zYvMSEKS3K1ZP00F5l+qtmi4=; b=GBpVe0crrvswMeXR/U4s3xSrTTSw6sHnACyYRVVCKpZopIR16a2ko4p6xxPtuSyVwp emDcElgIO2xodDCV5M5ttKETuIXuu1fbgNseLBlZO5Oh5BkpjqRa9uTfpsz2v175/QvL rp7bhmTIZtsGTzM5nMdjx3Y3WU/6W3dyFhd2L6FmUfgliGszXWmRxghhsNygtaj73Ipx 7Eq3KJF90rwmx37TsOXy375bk8JDIQoxJZQ4fk3ywpiGx9Xjv9wAbDwa82A7j7ConFS6 sDJiCFLqaLAZ4cZ/+cPrF1vX1FurfASSyQqYtfrKPZBVVr3ItxenKArwersXSLqlVHia F2Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995872; x=1795600672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RQVwgEVHMuFWrXov8O0zYvMSEKS3K1ZP00F5l+qtmi4=; b=F5gATkU+02JMrkIF0DLB4V1+oUa1lc9ohoMK4ZhylCoFAl/knYYuP1y/VMq01RJNYF I2zBSIo/U0MF72KCq5yuXGy5bODSPe8H8lL7QGf1GYKHeYj85Kf8TSWYISNSzmTtcEhL rRCLAA56V0e2jb7eoRZCbM+PicIlHjykrhHgQvA/ORSKUj/tC3pMxJtRfnoqlgtfWId1 pgkht7GfXyL3WBXw6O9c1NpXD74uE7pKDcwUEFqw3OvbJeBPBjEMQkURP/ER23dHQ7sH hq6LQ2A2PdqOCQDr4trR4yb1ZfPIqfW2O73rY4b08A6lK13wqSwvXesTgXaFfZDTY/hK Obdg== X-Gm-Message-State: APuU4Z9KnNEe040+7ZuhBPhoCejxZxwXO1+vs37Ne07urmzr4sp1ktn3 4PXp1oa7tcG7/KAO1o+FB0IHGcN6VVf5/Bzj3e0BVk9aEhOEw1W4cZ5Hpv6kI7dPQ9MRXYSwLhW C0e9S/qI= X-Gm-Gg: AZFdTZcMddrhrV3ZIZi8udh0IQ46/wmT6DagjZ668FOE4I3vKduk0an5CHoeMYntEtP IdIf0DLXW4gRvA+jJ63PIrXTQPyrit6gStrrMG3iueu72xX4tHhzDMSdrnQ5gM+ZRoGRp/hdJEH 6cAM6/tjYq08ByhL1hD61kdB4yxryM+UsxJAKTIM3ks9lUcRYR1fuZn+QtkaoBBoxcXRCpGEfaV siX9mmzdp66jnPcoemFDOUmz2/HhULsvplLWU9+yUjDi9YCuPBbQ1Vxc+trjn3Egd9vgkSiao9u 8bDxmXO18WAh5x6OlwCW+1Yhm4/mWe3JK2jlhsbHrpsNZjDOoEau58LpPHqYx5YdMy3caeTYZSO 6a2vSSYpVgZlz/oG/uDjetYctufwgyxb4Fc+FT3EGN+zVal06Ym6KHKfmx57gtVUt1dMpqFS7oV yrwmZRC6aUe4+2FYn2Fjpt8o/LgSqcXtj11rt+AsIMq+T67+sRa6JXv+JLUja8CUcDom5f0O4Ot elQujtsypWgAxEXUnngseuTjYVt6RLeqQNHLDJorBhJ9TKWndV1FWBjKVnEvFukAGHYwv9eLl9q N1pEr8zQiYQjvd/0tFzlsgYNnoGHJTIS8IMMWI7EI+QW0w== X-Received: by 2002:a05:6000:1616:b0:499:3450:5b4c with SMTP id ffacd0b85a97d-4a63d1dab8bmr2822876f8f.51.1794995872430; Wed, 18 Nov 2026 01:57:52 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:57:51 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 04/26] libcamera: software_isp: gpu_pipeline_shader_pass: Add GpuPipelineShaderPassDemosiac Date: Wed, 18 Nov 2026 10:57:11 +0100 Message-ID: <20261118095735.170587-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Signed-off-by: Bryan O'Donoghue --- .../gpu_pipeline_shader_pass_demosiac.cpp | 332 ++++++++++++++++++ .../gpu_pipeline_shader_pass_demosiac.h | 73 ++++ src/libcamera/software_isp/meson.build | 1 + 3 files changed, 406 insertions(+) create mode 100644 src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.cpp create mode 100644 src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.h diff --git a/src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.cpp b/src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.cpp new file mode 100644 index 000000000..1c821c9fd --- /dev/null +++ b/src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.cpp @@ -0,0 +1,332 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2026, Linaro Ltd + * + * GPU ISP Demosiac pass + */ + +#include +#include +#include +#include +#include + +#include +#include +#include + +#include +#include +#include + +#include "libcamera/internal/bayer_format.h" +#include "libcamera/internal/framebuffer.h" +#include "libcamera/internal/ipa_manager.h" +#include "libcamera/internal/software_isp/debayer_params.h" + +#include "gpu_pipeline_shader_pass_demosiac.h" + +/** + * \file software_isp.cpp + * \brief Simple software ISP implementation + */ + +namespace libcamera { + +LOG_DEFINE_CATEGORY(GpuShaderDemosiac) + +int GpuIspShaderPassDemosiac::initShaders(PixelFormat inputFormat, PixelFormat outputFormat) +{ + std::span fragmentShaderData; + std::span vertexShaderData; + std::vector shaderEnv; + GLenum err; + + /* Target gles 100 glsl requires "#version x" as first directive in shader */ + egl_.pushEnv(shaderEnv, "#version 100"); + + /* Specify GL_OES_EGL_image_external */ + egl_.pushEnv(shaderEnv, "#extension GL_OES_EGL_image_external: enable"); + + /* + * Tell shaders how to re-order output taking account of how the pixels + * are actually stored by EGL. + */ + switch (outputFormat) { + case formats::ARGB8888: + case formats::XRGB8888: + break; + case formats::ABGR8888: + case formats::XBGR8888: + egl_.pushEnv(shaderEnv, "#define SWAP_BLUE"); + break; + default: + LOG(GpuShaderDemosiac, Error) << "Unsupported output format"; + return -EINVAL; + } + + /* Pixel location parameters */ + glFormat_ = GL_LUMINANCE; + bytesPerPixel_ = 1; + shaderStridePixels_ = passInputCfg_.stride; + + switch (inputFormat) { + case libcamera::formats::SBGGR8: + case libcamera::formats::SBGGR10_CSI2P: + case libcamera::formats::SBGGR12_CSI2P: + firstRed_x_ = 1.0; + firstRed_y_ = 1.0; + break; + case libcamera::formats::SGBRG8: + case libcamera::formats::SGBRG10_CSI2P: + case libcamera::formats::SGBRG12_CSI2P: + firstRed_x_ = 0.0; + firstRed_y_ = 1.0; + break; + case libcamera::formats::SGRBG8: + case libcamera::formats::SGRBG10_CSI2P: + case libcamera::formats::SGRBG12_CSI2P: + firstRed_x_ = 1.0; + firstRed_y_ = 0.0; + break; + case libcamera::formats::SRGGB8: + case libcamera::formats::SRGGB10_CSI2P: + case libcamera::formats::SRGGB12_CSI2P: + firstRed_x_ = 0.0; + firstRed_y_ = 0.0; + break; + default: + LOG(GpuShaderDemosiac, Error) << "Unsupported input format"; + return -EINVAL; + }; + + /* Shader selection */ + switch (inputFormat) { + case libcamera::formats::SBGGR8: + case libcamera::formats::SGBRG8: + case libcamera::formats::SGRBG8: + case libcamera::formats::SRGGB8: + fragmentShaderData = bayer_unpacked_frag; + vertexShaderData = bayer_unpacked_vert; + break; + case libcamera::formats::SBGGR10_CSI2P: + case libcamera::formats::SGBRG10_CSI2P: + case libcamera::formats::SGRBG10_CSI2P: + case libcamera::formats::SRGGB10_CSI2P: + egl_.pushEnv(shaderEnv, "#define RAW10P"); + if (BayerFormat::fromPixelFormat(inputFormat).packing == BayerFormat::Packing::None) { + fragmentShaderData = bayer_unpacked_frag; + vertexShaderData = bayer_unpacked_vert; + glFormat_ = GL_RG; + bytesPerPixel_ = 2; + } else { + fragmentShaderData = bayer_1x_packed_frag; + vertexShaderData = identity_vert; + shaderStridePixels_ = passInputCfg_.size.width; + } + break; + case libcamera::formats::SBGGR12_CSI2P: + case libcamera::formats::SGBRG12_CSI2P: + case libcamera::formats::SGRBG12_CSI2P: + case libcamera::formats::SRGGB12_CSI2P: + egl_.pushEnv(shaderEnv, "#define RAW12P"); + if (BayerFormat::fromPixelFormat(inputFormat).packing == BayerFormat::Packing::None) { + fragmentShaderData = bayer_unpacked_frag; + vertexShaderData = bayer_unpacked_vert; + glFormat_ = GL_RG; + bytesPerPixel_ = 2; + } else { + fragmentShaderData = bayer_1x_packed_frag; + vertexShaderData = identity_vert; + shaderStridePixels_ = passInputCfg_.size.width; + } + break; + }; + + if (egl_.compileVertexShader(vertexShaderId_, vertexShaderData, + shaderEnv)) { + LOG(GpuShaderDemosiac, Error) << "Compile vertex shader fail"; + return -ENODEV; + } + utils::scope_exit vShaderGuard([&] { glDeleteShader(vertexShaderId_); }); + + if (egl_.compileFragmentShader(fragmentShaderId_, fragmentShaderData, + shaderEnv)) { + LOG(GpuShaderDemosiac, Error) << "Compile fragment shader fail"; + return -ENODEV; + } + utils::scope_exit fShaderGuard([&] { glDeleteShader(fragmentShaderId_); }); + + if (egl_.linkProgram(programId_, vertexShaderId_, fragmentShaderId_)) { + LOG(GpuShaderDemosiac, Error) << "Linking program fail"; + return -ENODEV; + } + + egl_.dumpShaderSource(vertexShaderId_); + egl_.dumpShaderSource(fragmentShaderId_); + + /* Ensure we set the programId_ */ + glUseProgram(programId_); + err = glGetError(); + if (err != GL_NO_ERROR) { + LOG(GpuShaderDemosiac, Error) << "Use program error " << err; + return -ENODEV; + } + + return getShaderVariableLocations(); + +} + +int GpuIspShaderPassDemosiac::getShaderVariableLocations(void) +{ + attributeVertex_ = glGetAttribLocation(programId_, "vertexIn"); + attributeTexture_ = glGetAttribLocation(programId_, "textureIn"); + + textureUniformBayerDataIn_ = glGetUniformLocation(programId_, "tex_y"); + awbUniformDataIn_ = glGetUniformLocation(programId_, "awb"); + ccmUniformDataIn_ = glGetUniformLocation(programId_, "ccm"); + blackLevelUniformDataIn_ = glGetUniformLocation(programId_, "blacklevel"); + gammaUniformDataIn_ = glGetUniformLocation(programId_, "gamma"); + contrastExpUniformDataIn_ = glGetUniformLocation(programId_, "contrastExp"); + + textureUniformStep_ = glGetUniformLocation(programId_, "tex_step"); + textureUniformSize_ = glGetUniformLocation(programId_, "tex_size"); + textureUniformStrideFactor_ = glGetUniformLocation(programId_, "stride_factor"); + textureUniformBayerFirstRed_ = glGetUniformLocation(programId_, "tex_bayer_first_red"); + textureUniformProjMatrix_ = glGetUniformLocation(programId_, "proj_matrix"); + + LOG(GpuShaderDemosiac, Debug) << "vertexIn " << attributeVertex_ << " textureIn " << attributeTexture_ + << " tex_y " << textureUniformBayerDataIn_ + << " awb " << awbUniformDataIn_ + << " ccm " << ccmUniformDataIn_ + << " blacklevel " << blackLevelUniformDataIn_ + << " gamma " << gammaUniformDataIn_ + << " contrastExp " << contrastExpUniformDataIn_ + << " tex_step " << textureUniformStep_ + << " tex_size " << textureUniformSize_ + << " stride_factor " << textureUniformStrideFactor_ + << " tex_bayer_first_red " << textureUniformBayerFirstRed_ + << " proj_matrix " << textureUniformProjMatrix_; + return 0; + +} + +void GpuIspShaderPassDemosiac::setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams ¶ms) +{ + /* + * Raw Bayer 8-bit, and packed raw Bayer 10-bit/12-bit formats + * are stored in a GL_LUMINANCE texture. The texture width is + * equal to the stride. + */ + GLfloat firstRed[] = { firstRed_x_, firstRed_y_ }; + GLfloat imgSize[] = { (GLfloat)passInputCfg_.size.width, + (GLfloat)passInputCfg_.size.height }; + GLfloat Step[] = { static_cast(bytesPerPixel_) / (passInputCfg_.stride - 1), + 1.0f / (passInputCfg_.size.height - 1) }; + GLfloat Stride = (GLfloat)passInputCfg_.size.width / (shaderStridePixels_ / bytesPerPixel_); + /* + * Scale the output size from the native size the algorithm produces for + * the input size. Keep the aspect ratio and prefer cropping over black + * bars. + */ + GLfloat scale = std::max((GLfloat)passOutputCfg_.size.width / passOutputCfg_.window.size().width, + (GLfloat)passOutputCfg_.size.height / passOutputCfg_.window.size().height); + GLfloat trans = -(1.0f - scale); + GLfloat projMatrix[] = { + scale, 0, 0, 0, + 0, scale, 0, 0, + 0, 0, 1, 0, + trans, trans, 0, 1 + }; + /* Static const coordinates */ + static const GLfloat vcoordinates[4][2] = { + { -1.0f, -1.0f }, + { -1.0f, +1.0f }, + { +1.0f, +1.0f }, + { +1.0f, -1.0f }, + }; + static const GLfloat tcoordinates[4][2] = { + { 0.0f, 0.0f }, + { 0.0f, 1.0f }, + { 1.0f, 1.0f }, + { 1.0f, 0.0f }, + }; + + /* vertexIn - bayer_8.vert */ + glEnableVertexAttribArray(attributeVertex_); + glVertexAttribPointer(attributeVertex_, 2, GL_FLOAT, GL_TRUE, + 2 * sizeof(GLfloat), vcoordinates); + + /* textureIn - bayer_8.vert */ + glEnableVertexAttribArray(attributeTexture_); + glVertexAttribPointer(attributeTexture_, 2, GL_FLOAT, GL_TRUE, + 2 * sizeof(GLfloat), tcoordinates); + + /* + * Set the sampler2D to the respective texture unit for each texutre + * To simultaneously sample multiple textures we need to use multiple + * texture units + */ + glUniform1i(textureUniformBayerDataIn_, eglImageIn.texture_unit_uniform_id_); + + /* + * These values are: + * firstRed = tex_bayer_first_red - bayer_8.vert + * imgSize = tex_size - bayer_8.vert + * step = tex_step - bayer_8.vert + * Stride = stride_factor identity.vert + * textureUniformProjMatri = No scaling + */ + glUniform2fv(textureUniformBayerFirstRed_, 1, firstRed); + glUniform2fv(textureUniformSize_, 1, imgSize); + glUniform2fv(textureUniformStep_, 1, Step); + glUniform1f(textureUniformStrideFactor_, Stride); + glUniformMatrix4fv(textureUniformProjMatrix_, 1, GL_FALSE, projMatrix); + + LOG(GpuShaderDemosiac, Debug) << "vertexIn " << attributeVertex_ << " textureIn " << attributeTexture_ + << " tex_y " << textureUniformBayerDataIn_ + << " tex_step " << textureUniformStep_ + << " tex_size " << textureUniformSize_ + << " stride_factor " << textureUniformStrideFactor_ + << " tex_bayer_first_red " << textureUniformBayerFirstRed_; + + LOG(GpuShaderDemosiac, Debug) << "textureUniformY_ = 0 " + << " firstRed.x " << firstRed[0] + << " firstRed.y " << firstRed[1] + << " textureUniformSize_.width " << imgSize[0] + << " textureUniformSize_.height " << imgSize[1] + << " textureUniformStep_.x " << Step[0] + << " textureUniformStep_.y " << Step[1] + << " textureUniformStrideFactor_ " << Stride + << " textureUniformProjMatrix_ " << textureUniformProjMatrix_; + + /* Pre-transpose matrix for GLES 2.0. */ + Matrix ccm = params.combinedMatrix.transpose(); + glUniformMatrix3fv(ccmUniformDataIn_, 1, GL_FALSE, ccm.data().data()); + LOG(GpuShaderDemosiac, Debug) << " ccmUniformDataIn_ " << ccmUniformDataIn_ << " data " << params.combinedMatrix; + + /* + * 0 = Red, 1 = Green, 2 = Blue + */ + glUniform3f(blackLevelUniformDataIn_, params.blackLevel[0], params.blackLevel[1], params.blackLevel[2]); + LOG(GpuShaderDemosiac, Debug) << " blackLevelUniformDataIn_ " << blackLevelUniformDataIn_ << " data " << params.blackLevel; + + glUniform3f(awbUniformDataIn_, params.gains[0], params.gains[1], params.gains[2]); + LOG(GpuShaderDemosiac, Debug) << " awbUniformDataIn_ " << awbUniformDataIn_ << " data " << params.gains; + + /* + * Gamma + */ + glUniform1f(gammaUniformDataIn_, params.gamma); + LOG(GpuShaderDemosiac, Debug) << " gammaUniformDataIn_ " << gammaUniformDataIn_ << " data " << params.gamma; + + /* + * Contrast + */ + glUniform1f(contrastExpUniformDataIn_, params.contrastExp); + LOG(GpuShaderDemosiac, Debug) << " contrastExpUniformDataIn_ " << contrastExpUniformDataIn_ << " data " << params.contrastExp; + + return; +} + +} diff --git a/src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.h b/src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.h new file mode 100644 index 000000000..eccab94f9 --- /dev/null +++ b/src/libcamera/software_isp/gpu_pipeline_shader_pass_demosiac.h @@ -0,0 +1,73 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2026, Linaro Ltd + * + * Authors: + * Bryan O'Donoghue + * + * GpuIspIspShaderPass base class + */ + +#pragma once + +#include + +#include +#include +#include + +#include +#include + +#include "libcamera/internal/egl.h" +#include "libcamera/internal/software_isp/debayer_params.h" + +#include "gpu_pipeline_shader_pass.h" + +namespace libcamera { + +class FrameBuffer; + +class GpuIspShaderPassDemosiac : public GpuIspShaderPass +{ +public: + GpuIspShaderPassDemosiac(eGL& egl) : GpuIspShaderPass(egl) {}; + + /* Things that every ISP pipeline pass will need to do */ + int initShaders(PixelFormat inputFormat, PixelFormat outputFormat) override; + int getShaderVariableLocations(void) override; + void setShaderVariableValues(eGLImage &eglImageIn, const DebayerParams ¶ms) override; + + const char *name() const override { return "GpuIspShaderPassDemosiac"; } +private: + /* Shader parameters */ + float firstRed_x_; + float firstRed_y_; + GLint attributeVertex_; + GLint attributeTexture_; + GLint textureUniformStep_; + GLint textureUniformSize_; + GLint textureUniformStrideFactor_; + GLint textureUniformBayerFirstRed_; + GLint textureUniformProjMatrix_; + GLint textureUniformBayerDataIn_; + + uint32_t shaderStridePixels_; + + /* Per-frame AWB gains */ + GLint awbUniformDataIn_; + + /* Represent per-frame CCM as a uniform vector of floats 3 x 3 */ + GLint ccmUniformDataIn_; + + /* Black Level compensation */ + GLint blackLevelUniformDataIn_; + + /* Gamma */ + GLint gammaUniformDataIn_; + + /* Contrast */ + GLint contrastExpUniformDataIn_; +}; + +} /* namespace libcamera */ diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build index 91274e968..bad821351 100644 --- a/src/libcamera/software_isp/meson.build +++ b/src/libcamera/software_isp/meson.build @@ -33,6 +33,7 @@ if mesa_works '../egl.cpp', 'software_isp_instance_gpu.cpp', 'gpu_pipeline_shader_pass.cpp', + 'gpu_pipeline_shader_pass_demosiac.cpp', ]) libcamera_deps += [ libegl,