From patchwork Wed Nov 18 09:57:09 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 28963 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 24ABEBDE17 for ; Wed, 18 Nov 2026 09:57:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CE4FD6A8B1; Wed, 18 Nov 2026 10:57:51 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Dg2L0Wwv"; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 95B306A7EA for ; Wed, 18 Nov 2026 10:57:50 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-490d59c3f0aso294556f8f.1 for ; Wed, 18 Nov 2026 01:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794995870; x=1795600670; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mu+3zKntSemaZs7194jB7jwYkT7HFXb0haZNtJEHqNU=; b=Dg2L0Wwvlc3yHDAgo5JZ0x81P5yd1ZRRSRIMO7nL7XjTQkH8G+y5i3jS2DqTFpeMbi W9Yzu0a9srxJxAj2y7diw8UaDP3QCVEavHe1tW33PNjiMxzDNE7Bj/v87dlPaPX6/m7p A9SA13vqmWD1fxmyVvkSuSqP06Ix4F+mqCQq7bNGd/LnUaXxNyfACyg3mt/1shzF8Tsd qg+3+FNS+b0af7AChTMUTkYlRDvYpLD4DbU3dI9fx8OXPL8FmFWSbn2Bim9+0eZq0I+A Si/wjs3PRCOZ/XWNpbNqW7cydHTjQgYgoHrbr2b7EbyAasrr/bHXut+W6tGFX1KSR40c UuGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794995870; x=1795600670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mu+3zKntSemaZs7194jB7jwYkT7HFXb0haZNtJEHqNU=; b=EkKuM2MH2NIjLRg102dXYbAR46KDKXRzkba/IwoMTVYwwQ/aAfmLavFx3WGSxpnYH0 ISo6tSYIMy1sjm7p6c9CsfUouYcciZXhr6rht8mtTxjRPdmN90XJsLnTIcPvxp7hRxuZ bmYMezdqlMTVDdcTKegFd8BM8bt8gzeg6e0Rta1goIvKmyMMeCJZ6cXzX9Ss4ucgHCvH LR+nPAeqF9rQwCv0wgWqyZGlRTx8IsxNwWlJFrdQgm8SU9UAHVsDsL1VIMx1fJ0xd1E0 DtDhDvAwnquzb/azXzRZXUn5+sp8zEh4/jjO8oj7m9WjW5zqul+9Ra6owtPFJFjryHtP pQiA== X-Gm-Message-State: APuU4Z+bKPTXweEUWJc9UDFIJ0BQnLwH1WkmAPC9eYtaa2o7lzok2DwI lKsir9/SH50NxHEGLMlLHhZ96E25TaW0hrAPZ4oQA9sKyBW+OAh3iaCdlaGmKpW4iMcsum3BEcZ sG8W7OoE= X-Gm-Gg: AZFdTZdpP4mKNCevkbYWRPxcWK8VHb1o6Wpw5azXCLkfzXIl96kINdrh+KY1ilgfs2Z T0o4WbEaVpqNfwZET8BGR9gFBYP984K5U1Ncr3WMtvhtiJ8TbqnFb4z6A9QHampc5ErXARyFImv Zqp6UmcOC+kKu6fOG1Q8LR8b3KJ44WvPHz3oa9K8FMWMLN6x7SGL367AH/6qsJH+pFMsonxWE2c mhDPjF+3AmM9CEavNcsxy8/7X1R6aKHSwDZk2HUMQqUGMavsvkwA+iuitHvHAzjkstj9yMjiqRU 4QdGWJxYeDUieMMNEI12SMJBnxojJNQChqJnhX3OHVN5DaHvB1gQwA3mUARIa4WvnrWIWjOHMai 90Dy27ueIoRNpwhPLZxVv20wcHexM+1K2FA/sR44Akbmyl0+oQ/vGrt+z3TPLkTgXVnLxIhkhpW xSXUOQJW5cErbhVadVZPftQinNceZws2KswGtplK23y5dKAK9OS66AQ+eFxCpqkMmAqgq3xTazb vuiT4+14cfjtU3KGXcJ8x6t15zqj/UMdm4TrZiX+wOlRvtxRRW3fAPHWBMnwaR3/khBpDLMmJlC S+3yjzN5DOQwuNLeNr+YHMUwGF39NWmXAs2wHpV7xfFGUlY= X-Received: by 2002:a05:6000:3c4:b0:48b:1a0:5630 with SMTP id ffacd0b85a97d-4a63d985408mr4287795f8f.41.1794995870055; Wed, 18 Nov 2026 01:57:50 -0800 (PST) Received: from inspiron14p-linux ([109.76.187.112]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4a655f9f4a7sm3940871f8f.34.2026.11.18.01.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2026 01:57:49 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: rstrode@redhat.com, robert.mader@collabora.com, barnabas.pocze@ideasonboard.com, Bryan O'Donoghue Subject: [RFC PATCH v2 02/26] libcamera: software_isp: gpu: rename debayerGPU to processGPU Date: Wed, 18 Nov 2026 10:57:09 +0100 Message-ID: <20261118095735.170587-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261118095735.170587-1-bryan.odonoghue@linaro.org> References: <20261118095735.170587-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This function will do more than debayer, rename it to reflect. Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/software_isp_instance_gpu.cpp | 4 ++-- src/libcamera/software_isp/software_isp_instance_gpu.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/software_isp/software_isp_instance_gpu.cpp b/src/libcamera/software_isp/software_isp_instance_gpu.cpp index db6b23144..b71413fca 100644 --- a/src/libcamera/software_isp/software_isp_instance_gpu.cpp +++ b/src/libcamera/software_isp/software_isp_instance_gpu.cpp @@ -594,7 +594,7 @@ eGLImage *SoftwareIspInstanceGpu::getCachedOutputFrameBuffer(FrameBuffer *output return eglImageOut; } -int SoftwareIspInstanceGpu::debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *inMapped, std::optional *inDmaSyncer) +int SoftwareIspInstanceGpu::processGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *inMapped, std::optional *inDmaSyncer) { eGLImage *eglImageIn; eGLImage *eglImageOut; @@ -638,7 +638,7 @@ void SoftwareIspInstanceGpu::process(uint32_t frame, FrameBuffer *input, FrameBu std::optional inMapped; std::optional inDmaSyncer; - if (debayerGPU(input, output, params, &inMapped, &inDmaSyncer)) { + if (processGPU(input, output, params, &inMapped, &inDmaSyncer)) { LOG(SoftwareIspInstance, Error) << "debayerGPU failed"; goto error; } diff --git a/src/libcamera/software_isp/software_isp_instance_gpu.h b/src/libcamera/software_isp/software_isp_instance_gpu.h index 90cab1b9e..d729b80e1 100644 --- a/src/libcamera/software_isp/software_isp_instance_gpu.h +++ b/src/libcamera/software_isp/software_isp_instance_gpu.h @@ -67,7 +67,7 @@ private: int initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat); int getShaderVariableLocations(); void setShaderVariableValues(eGLImage &eGLImageIn, const DebayerParams ¶ms); - int debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer); + int processGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional *mappedInputBuffer, std::optional *inputBufferDmaSyncer); eGLImage *getCachedInputFrameBuffer(FrameBuffer *input, std::optional *inMapped, std::optional *inDmaSyncer); eGLImage *getCachedOutputFrameBuffer(FrameBuffer *output);