From patchwork Wed Nov 18 08:08:26 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 28959 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 284B3BDE17 for ; Wed, 18 Nov 2026 08:09:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B3F856A8B0; Wed, 18 Nov 2026 09:09:28 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="i69kOejP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2398A6A7EA for ; Wed, 18 Nov 2026 09:09:27 +0100 (CET) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c67:cdf:7464:6c04:36e4:ee87]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 924354F1; Wed, 18 Nov 2026 09:06:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1794989219; bh=Dh2h/w+X6P79GzGzlO6LgYVBBXbAIpfWaNyMNDL3vcY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=i69kOejPpfj/2e4b3Dx8LWr67AJk0CvYWyoRVJ6AxyT+Z0Jay3uHWmulAQnSNqHNi nyzhxAFUg1sNZ281j5ghMYA3KWhgj14aWTtajPQDvTF4I/n0fSfyTokx9mL3IkSvxj 78QraaHc7jU4C3CNpX33qwQa88U9wUedcGaqLn5s= From: Jai Luthra Date: Wed, 18 Nov 2026 13:38:26 +0530 Subject: [PATCH v4 2/4] libcamera: camera_sensor: Add properties and helpers for Sony IMX675 and IMX832 MIME-Version: 1.0 Message-Id: <20261118-mainline-imx676-v4-2-48ae007f11b4@ideasonboard.com> References: <20261118-mainline-imx676-v4-0-48ae007f11b4@ideasonboard.com> In-Reply-To: <20261118-mainline-imx676-v4-0-48ae007f11b4@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , Laurent Pinchart , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Dave Stevenson , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3165; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=Dh2h/w+X6P79GzGzlO6LgYVBBXbAIpfWaNyMNDL3vcY=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBq/V0lZnWDdBpSd5rPpEt+m9SGV81Otn/h8h85X vBM0pDCqY2JAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCav1dJQAKCRBD3pH5JJpx Rfl6D/9BlQvdsjxS3x6OjoxVc4BuGgkEwWI+djknNtUXwZHUbjd8VUlR3RBz3uvo2/9WI3eO9Up nJmoyiBeQpwHu73rA9PXvIahHfyhSu1yRPY621JsX9XSM+JSGBzMGyzMjMrbB4bQSZnBzv/LWLT zYMRQRRIBCpXExY4yscEtrY1nbaffUytlovVH0akLJnhqvJ0CzJ+kpEZwe/GBNDTxnUQyapAww8 pKqdJVz0otAsJflat/ah1BIQwzSKOT+Id5hVTEdo9zgpe9SS6QTLqVU+cNjAQ429akKsmdQ6p6y 2tjN3DzDKqQiEvImpLKwiemwwFQoD/SsfZYwi9D/Vtiza4dHRlVzLrcM8yVK8fs+F9sn7wO1+gz bWqedsryF++ij+ATXnOvrQVUZTnD2rWxn6cJC8yorEGgb2fxK7hn5L5Uo9a48EbpSLFsCkk8Igu GnXrPib80qW7cxgp/dNH72iEUr5RjtUFq28HRgpmUAq1za+jclHbJuwGmWJtMRKkBBMLbWtxiQP 1A1b+whJehu5QXrrJjmGO15r7+sP6MXDe5iwcgrwQNNfbS2CUuSFbml2qyA9o1X9Wnp4jBCHk1f rMjjMOHq2BLrRkkFp1p1C1t9+G52SGd5aZxKDdw1vo34wBMZ0yGPGOkuZZp31Wv7hY3z467MUPk tm5/6lPQVdr8v0A== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Sony IMX675 (5.12MP) and IMX832 (2.12MP) are Starvis 2 sensors, with very similar properties to IMX662 and IMX678. Add the camera sensor properties for both. To my knowledge, all of these 4 sensors have the same black level and gain models. For convenience use the IMX678 camera sensor helper for all of these 4. This of course can change if differences are found later. Reviewed-by: Kieran Bingham Reviewed-by: Naushir Patuck Signed-off-by: Jai Luthra --- src/ipa/libipa/camera_sensor_helper.cpp | 20 ++++++-------------- src/libcamera/sensor/camera_sensor_properties.cpp | 20 ++++++++++++++++++++ 2 files changed, 26 insertions(+), 14 deletions(-) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index b106070c49d2..770fc474254d 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -702,19 +702,10 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER(CameraSensorHelperImx477, "imx477") -class CameraSensorHelperImx662 : public CameraSensorHelper -{ -public: - CameraSensorHelperImx662() - { - /* From datasheet: 0xc8 at 12bits. */ - blackLevel_ = 3200; - gain_ = AnalogueGainExp{ 1.0, expGainDb(0.3) }; - exposureMargin_ = 4; - } -}; -REGISTER_CAMERA_SENSOR_HELPER(CameraSensorHelperImx662, "imx662") - +/* + * Reusing CameraSensorHelperImx678 for multiple sensors, for convenience. + * They may need to be split apart if any differences are found later. + */ class CameraSensorHelperImx678 : public CameraSensorHelper { public: @@ -726,7 +717,8 @@ public: exposureMargin_ = 4; } }; -REGISTER_CAMERA_SENSOR_HELPER(CameraSensorHelperImx678, "imx678") +REGISTER_CAMERA_SENSOR_HELPER(CameraSensorHelperImx678, "imx662", "imx675", + "imx678", "imx832") class CameraSensorHelperImx708 : public CameraSensorHelper { diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp index 20cfd0bc11a6..9dde76937a28 100644 --- a/src/libcamera/sensor/camera_sensor_properties.cpp +++ b/src/libcamera/sensor/camera_sensor_properties.cpp @@ -350,6 +350,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .hblankDelay = 2 }, } }, + { "imx675", { + .unitCellSize = { 2000, 2000 }, + .testPatternModes = {}, + .sensorDelays = { + .exposureDelay = 2, + .gainDelay = 2, + .vblankDelay = 2, + .hblankDelay = 2 + }, + } }, { "imx678", { .unitCellSize = { 2000, 2000 }, .testPatternModes = {}, @@ -376,6 +386,16 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen .hblankDelay = 3 }, } }, + { "imx832", { + .unitCellSize = { 2900, 2900 }, + .testPatternModes = {}, + .sensorDelays = { + .exposureDelay = 2, + .gainDelay = 2, + .vblankDelay = 2, + .hblankDelay = 2 + }, + } }, { "ov08d10", { .unitCellSize = { 1120, 1120 }, .testPatternModes = {