From patchwork Tue Nov 17 08:47:14 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 28941 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 50B96BDE17 for ; Tue, 17 Nov 2026 08:47:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 025BA6A861; Tue, 17 Nov 2026 09:47:28 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="azktCdSE"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 50BEB6A814 for ; Tue, 17 Nov 2026 09:47:26 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:27fa:cb4b:1d83:9b64]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E0005593; Tue, 17 Nov 2026 09:44:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1794905099; bh=wWsjj6+XJNcQJgloWGO1EBkuO/nud/E8KTF0sBG0YtY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=azktCdSEzjCw8bPWRUVc5zv2T6F77L7IiX3C3UsRoE1ZeQBbZ9cJEMUMglBYNQrwF 6TO4dyv/px9Z+78Fd5JNdcjA9jFurytSiWfLOh9izQXOvp2K1Kzxrlt+753loDNapQ V5BDZHvUrqCGbckAZn8li0zDWk07bjOpRe65/G7s= From: Stefan Klug Date: Tue, 17 Nov 2026 09:47:14 +0100 Subject: [PATCH 04/10] libipa: agc: Rename agEnable to agMode MIME-Version: 1.0 Message-Id: <20261117-sklug-digital-gain-support-v1-v1-4-f0aa342ca877@ideasonboard.com> References: <20261117-sklug-digital-gain-support-v1-v1-0-f0aa342ca877@ideasonboard.com> In-Reply-To: <20261117-sklug-digital-gain-support-v1-v1-0-f0aa342ca877@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug X-Mailer: b4 0.14.3 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The agEnable variable contains a mode. Name it accordingly for better readability. Signed-off-by: Stefan Klug --- src/ipa/libipa/agc.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp index 6ec37756c88e..b2c2feea5ed1 100644 --- a/src/ipa/libipa/agc.cpp +++ b/src/ipa/libipa/agc.cpp @@ -617,10 +617,10 @@ void AgcAlgorithm::queueRequest(const agc::Session &session, agc::ActiveState &s frameContext.autoExposureModeChange = true; } - const auto &agEnable = controls.get(controls::AnalogueGainMode); - if (agEnable && - (*agEnable == controls::AnalogueGainModeAuto) != state.autoGainEnabled) { - state.autoGainEnabled = (*agEnable == controls::AnalogueGainModeAuto); + const auto &agMode = controls.get(controls::AnalogueGainMode); + if (agMode && + (*agMode == controls::AnalogueGainModeAuto) != state.autoGainEnabled) { + state.autoGainEnabled = (*agMode == controls::AnalogueGainModeAuto); LOG(Agc, Debug) << (state.autoGainEnabled ? "Enabling" : "Disabling")