From patchwork Mon Nov 9 20:31:12 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faizel K B X-Patchwork-Id: 28837 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 81B9BC3307 for ; Mon, 9 Nov 2026 20:31:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6CE746A7B0; Mon, 9 Nov 2026 21:31:53 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="F82KcnoX"; dkim-atps=neutral Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 46D79691DA for ; Mon, 9 Nov 2026 21:31:52 +0100 (CET) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2ed41818a4eso621675ad.0 for ; Mon, 09 Nov 2026 12:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794256310; x=1794861110; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=wWiUKzQ+2XSLwntpWLrkH9PwDBP4LgAQvs09d9cA9QU=; b=F82KcnoXAcxrdU7k+tQIvSMHC8josfdAIuQQjqCHIl38Nb5Oet5XtLR8o1qToU14xn huZ/ZcqycNM8Ashu/hU3TD/DI8thjOIYbqTr5iN1L8ftUyuoPctWwMKcD/Khz94mzRVM gPT/OcbJ1IS2j5EHRLDGVI8/peHaN6eiPGzgnNw4CuHG89SzeUFnYhdzztHwcVXTEmzQ I3k4CW14R2sAj9QLIzOsyKblmPLD9liU9UliiNCJiSUThTKe6bCwpHhAlhGkZDJNH4Du h+cBWukBOV7V21UTVQaMaLDXXNGiB/f+YGkBr7cLeWYATbo6xy2CcbaQfImWjOKIWycG 1JJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794256310; x=1794861110; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wWiUKzQ+2XSLwntpWLrkH9PwDBP4LgAQvs09d9cA9QU=; b=p8YmiiKM20rp7NDAdrqOhMNg4Gp6iwE9wfVlUM/7Y9QVIsIwkfueJ/fNLhHNAs+q3w Va+JLeU6neUL/KH5XKvdpv9YP0+nXdMpzqRUR6acsXHWZBb5tbua+c7ZflELpWCVvhOl BPpdwi2lZmoVL9W6qWwcIatJeLQNke7OGqR4Z+fpitSd2uswm+0Z1kBIc/Mc8Z/QkEPo dQ5dBIafKD+33ag/jADWRyuS5GyvmD7PMEdnmjZn4Ahp0locKZA8M84NIWQ/8OfNtsJI wpmQiGTM+GINvafw4AYS1zqsXTVnDIusIh2eVMju79A2vvruJT01F9CiTs7z3ZlZnhf+ dxNg== X-Gm-Message-State: APuU4Z+Zdrm73q5cuJjqZwDmX3euTn2kDBl0cqQtrSBivALfmy69v1eg Cyi4iCNfurcnImERqwPcTv8i+4PWI4KMhEeyw0/HkFElfLi3YRqxWo6XRBAiu48h X-Gm-Gg: AYBFou1kg8SraTbzcIUTonYJ8Ue3rCqiKb09rAcU+jBYQ/jkf7hVEKlNAqb0+tC9dkc FK25zMi1vDSOJW4wh7IO4QU0kstuy39N/w/IH57DXlwI4nYmt5wylIHm46Vwd7VgJpmajdRASyQ pn4YkinknD/tw0wCDxiVIkYBs/1tY9SiXX/XcfTToNxFOUL6jgmfKfmlfeTJ3Eo/bX4Rfdq959F TGMbcvDgKWv9biD6op3NRoUcJfkswygEoMe6OMJb5UtmUgYTJuh3Xka8Td9VCA7GRLJ5B96JfkU KMBWgwlGhdxakAgSD5ywtlJRjsr7xWkiP8U1egplSsWJF0CxaT2nJE51IHRryU6CVW1ZoTxVF4o zxkeLKR8LlmrF/T7WqQWM+kmb3EUIwzniMBIR5H4ZHyzSmiuvtKpX06f5fDC6WVivlAAQsSPZid 150T5/EM5MoHAe/JPz3x4CeVUkDD9ntmN2jun3yOPDU07BUhB0c3dh6k/dyP6EFDXgbHuAWZmrf 0EngBDKUfsdt65bqje3p4dqSKC/8UK9QDkkiTAKuNVPLPqslan+N8+JIqsK0UDUV8MSidklF4xu msdD75dkS/BKtL4zXm1auMucxGZVIBtN4UkfXzVIQe6r2T9hPL0FAogySt8H X-Received: by 2002:a17:902:f789:b0:2e9:65bd:62c7 with SMTP id d9443c01a7336-2edb88a3f0dmr5259605ad.0.1794256310421; Mon, 09 Nov 2026 12:31:50 -0800 (PST) Received: from FAIZEL-KB.. ([2001:569:52f5:4b00:4b92:5a54:3d6f:1e5]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2edb6e1006asm1642655ad.72.2026.11.09.12.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 12:31:50 -0800 (PST) From: Faizel K B To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , Kieran Bingham , Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?= =?utf-8?q?e?= Subject: [PATCH v2] libcamera: pipeline: simple: Set planesCount for the capture format Date: Mon, 9 Nov 2026 13:31:12 -0700 Message-ID: <20261109203112.61688-1-faizel.kb@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The stride requested by the simple pipeline handler is ignored by V4L2VideoDevice::trySetFormatMultiplane(), which copies bytesperline only for planesCount planes, and planesCount is zero. Set it to 1, as the pipeline handler only supports formats stored in a single memory plane. Fixes: ff5cb4f17b0b ("software_isp: debayer_egl: Request input buffer alignment of 256 bytes") Signed-off-by: Faizel K B --- Changes in v2: - Set planesCount to 1 instead of PixelFormatInfo::numPlanes(), which counts colour planes rather than memory planes (Robert) - Link to v1 - https://patchwork.libcamera.org/patch/28662/ The rkcif kernel changes needed to honour the requested stride. https://lore.kernel.org/linux-media/20261105232310.385463-1-faizel.kb@gmail.com src/libcamera/pipeline/simple/simple.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 35e066499..8e22c90c1 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1588,6 +1588,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c) V4L2DeviceFormat captureFormat; captureFormat.fourcc = videoFormat; captureFormat.size = pipeConfig->captureSize; + captureFormat.planesCount = 1; uint32_t requested_bpl = 0; if (data->swIsp_)