From patchwork Thu Feb 27 03:00:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helen Koike X-Patchwork-Id: 2881 Return-Path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 05B5960429 for ; Thu, 27 Feb 2020 04:00:16 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id 002A1293DC8 From: Helen Koike To: libcamera-devel@lists.libcamera.org Cc: kernel@collabora.com, tfiga@chromium.org, niklas.soderlund@ragnatech.se, dafna.hirschfeld@collabora.com Date: Thu, 27 Feb 2020 00:00:01 -0300 Message-Id: <20200227030001.333291-3-helen.koike@collabora.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200227030001.333291-1-helen.koike@collabora.com> References: <20200227030001.333291-1-helen.koike@collabora.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 2/2] libcamera: pipeline: rkisp1: don't enable immutable link X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 03:00:16 -0000 Link between resizer and capture is immutable and doesn't need to be enabled. Signed-off-by: Helen Koike Reviewed-by: Laurent Pinchart --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 7f7e1ad..0589d38 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -915,14 +915,6 @@ int PipelineHandlerRkISP1::initLinks() if (ret < 0) return ret; - link = media_->link("rkisp1_resizer_mainpath", 1, "rkisp1_mainpath", 0); - if (!link) - return -ENODEV; - - ret = link->setEnabled(true); - if (ret < 0) - return ret; - return 0; }