From patchwork Fri Nov 6 12:58:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28787 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0B419C3307 for ; Fri, 6 Nov 2026 12:58:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4A7166A7D1; Fri, 6 Nov 2026 13:58:13 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JtccPYL+"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B8FA6A7C1 for ; Fri, 6 Nov 2026 13:58:11 +0100 (CET) Received: from pb-laptop.local (185.221.143.99.nat.pool.zt.hu [185.221.143.99]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8613918C7 for ; Fri, 6 Nov 2026 13:55:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793969751; bh=UX4yhgK+UDjlwIaW+nAYMg2xSsoviojbIxuwRqhGY60=; h=From:To:Subject:Date:In-Reply-To:References:From; b=JtccPYL+P1Ihsj2LYjVlbLD3+XOQa//E0f+wwg4Ji+x7KFuzbXlPxXV4yM95PjwQ1 UUmi+tu5JbU0vxC6NKenBNxLid1+cbSJAaxddYjR4K5z2WEOYBDUqX0ayBhg8A7Ilh Z60fyrqSd3HOnqaiQmYytcIAZxn5j2AB5m2ZRatM= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [RFC PATCH v2 2/3] ipa: mali-c55: agc: Remove color temperature calculation Date: Fri, 6 Nov 2026 13:58:06 +0100 Message-ID: <20261106125807.1238919-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261106125807.1238919-1-barnabas.pocze@ideasonboard.com> References: <20261106125807.1238919-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The color temperature is already calculated by the "Awb" algorithm, and since usually that runs first, that value goes in the metadata. The "Awb" value is used by the "Ccm" algorithm, the "Agc" value is used by the "Lsc" algorithm. So remove the calculation and adjust the "Lsc" algorithm to use the same color temperature as "Ccm". Signed-off-by: Barnabás Pőcze Reviewed-by: Stefan Klug Reviewed-by: Kieran Bingham --- src/ipa/mali-c55/algorithms/agc.cpp | 5 ----- src/ipa/mali-c55/algorithms/lsc.cpp | 6 +++--- src/ipa/mali-c55/ipa_context.h | 5 +---- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/ipa/mali-c55/algorithms/agc.cpp b/src/ipa/mali-c55/algorithms/agc.cpp index 2c747da891..bf9d3f7d4a 100644 --- a/src/ipa/mali-c55/algorithms/agc.cpp +++ b/src/ipa/mali-c55/algorithms/agc.cpp @@ -257,9 +257,6 @@ void Agc::process(IPAContext &context, } statistics_.parseStatistics(stats); - context.activeState.agc.temperatureK = estimateCCT({ { statistics_.rHist.interQuantileMean(0, 1), - statistics_.gHist.interQuantileMean(0, 1), - statistics_.bHist.interQuantileMean(0, 1) } }); agc_.process(context.configuration.agc, context.activeState.agc, frameContext.agc, {{ .traits = AgcTraits(statistics_), @@ -267,8 +264,6 @@ void Agc::process(IPAContext &context, .exposure = frameContext.sensor.exposure, .gain = frameContext.sensor.gain, }}, metadata); - - metadata.set(controls::ColourTemperature, context.activeState.agc.temperatureK); } REGISTER_IPA_ALGORITHM(Agc, "Agc") diff --git a/src/ipa/mali-c55/algorithms/lsc.cpp b/src/ipa/mali-c55/algorithms/lsc.cpp index e65e2a1807..4944f2aae4 100644 --- a/src/ipa/mali-c55/algorithms/lsc.cpp +++ b/src/ipa/mali-c55/algorithms/lsc.cpp @@ -180,8 +180,8 @@ std::tuple Lsc::findBankAndAlpha(uint32_t ct) const return { i, alpha }; } -void Lsc::prepare(IPAContext &context, [[maybe_unused]] const uint32_t frame, - [[maybe_unused]] IPAFrameContext &frameContext, +void Lsc::prepare([[maybe_unused]] IPAContext &context, [[maybe_unused]] const uint32_t frame, + IPAFrameContext &frameContext, MaliC55Params *params) { /* @@ -192,7 +192,7 @@ void Lsc::prepare(IPAContext &context, [[maybe_unused]] const uint32_t frame, * that table and if we're past the first frame then we can just do * nothing - the config will never change. */ - uint32_t temperatureK = context.activeState.agc.temperatureK; + uint32_t temperatureK = frameContext.awb.colourTemperature; uint8_t bank, alpha; if (colourTemperatures_.size() == 1) { diff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h index 030e0052ad..74585351c7 100644 --- a/src/ipa/mali-c55/ipa_context.h +++ b/src/ipa/mali-c55/ipa_context.h @@ -38,10 +38,7 @@ struct IPASessionConfiguration { }; struct IPAActiveState { - struct Agc : agc::ActiveState { - uint32_t temperatureK; - } agc; - + ipa::agc::ActiveState agc; ipa::awb::ActiveState awb; ipa::ccm::ActiveState ccm; ipa::gamma::ActiveState gamma;