From patchwork Thu Oct 29 12:58:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28668 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C9CA4C3261 for ; Thu, 29 Oct 2026 12:59:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8AEDF690B6; Thu, 29 Oct 2026 13:58:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Smqn2yRx"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 89A7D69094 for ; Thu, 29 Oct 2026 13:58:48 +0100 (CET) Received: from pb-laptop.local (185.221.143.99.nat.pool.zt.hu [185.221.143.99]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CA32802; Thu, 29 Oct 2026 13:56:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793278595; bh=E8zMGakT0PYi1I3aY6CfaNF5VT5/7kCErgkjGkanTaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Smqn2yRxt8SB/1ZlvVNhVxNp9MKWwp0fDGQ9PChhezorO64g3EhqPpX1S3SVqFx1R A5X4nhXPMg9F4StV7bOHE/Bo2UELcLS1kZmqt5rtXsXkk/04iDpPuLhL+G/SdemVZb P1liiyN4IfwXO/TbhA0FZ+TsqDwwrqEy2r4q3v7c= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi Subject: [PATCH v5 02/24] ipa: libipa: agc: Change `AgcMSV` exposure mode Date: Thu, 29 Oct 2026 13:58:22 +0100 Message-ID: <20261029125844.170324-3-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261029125844.170324-1-barnabas.pocze@ideasonboard.com> References: <20261029125844.170324-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The `AgcMSV` implementation does not really support exposure modes like `AgcMeanLuminance`. Instead it works by maximizing exposure time, then analogue gain. This behaviour is best described by the newly introduced "Maximize" exposure mode, so report that. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham --- src/ipa/libipa/agc.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp index 182dd7380e..7438825d30 100644 --- a/src/ipa/libipa/agc.cpp +++ b/src/ipa/libipa/agc.cpp @@ -487,9 +487,9 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, std::visit(utils::overloaded{ [&](AgcMSV &) { - /* No constraint/exposure mode support. */ + /* No constraint mode support. */ state.constraintMode = controls::AeConstraintModeEnum::AeConstraintModeNormal; - state.exposureMode = controls::AeExposureModeEnum::AeExposureModeNormal; + state.exposureMode = controls::AeExposureModeEnum::AeExposureModeMaximize; state.automatic.yTarget = 0; /* Not supported. */