From patchwork Tue Oct 27 21:24:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 28652 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6590DC324C for ; Tue, 27 Oct 2026 21:25:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 11E856906A; Tue, 27 Oct 2026 22:25:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BH0eL7mu"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DF9B69053 for ; Tue, 27 Oct 2026 22:24:54 +0100 (CET) Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 34071929 for ; Tue, 27 Oct 2026 22:22:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793136162; bh=9ULFZRBDcd1HeKHtnSx1h+KdX/4QAAYMU3w5N/0zAFA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=BH0eL7mumxLpMU9K/IHq01z0X1Slkw8jqBXrWEFptqFaZcc04fjvuAiouI4GKn7/N W+wnndvVLxfLZroKFKMmCHqN5z8fhs0p7dSffoqs7Xdwm+yfi/VDEWajUias8/l1DN Fi/UGdPSOHpAfry55qqUxvZ+aD0F5PKyFepGK69Q= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 4/4] v4l2: v4l2_camera_proxy: Set DONE flag on error buffers Date: Tue, 27 Oct 2026 23:24:47 +0200 Message-ID: <20261027212447.2551591-5-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261027212447.2551591-1-laurent.pinchart@ideasonboard.com> References: <20261027212447.2551591-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A buffer that has completed with an error is considered by the V4L2 API as done. videobuf2 sets both V4L2_BUF_FLAG_DONE and V4L2_BUF_FLAG_ERROR flags in that case. Copy that behaviour in v4l2-compat. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/v4l2/v4l2_camera_proxy.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 03b8a4210046..28dfb2c4b63c 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -262,7 +262,7 @@ void V4L2CameraProxy::updateBuffers() buf.flags |= V4L2_BUF_FLAG_DONE; break; case FrameMetadata::FrameError: - buf.flags |= V4L2_BUF_FLAG_ERROR; + buf.flags |= V4L2_BUF_FLAG_DONE | V4L2_BUF_FLAG_ERROR; break; default: break;