From patchwork Tue Oct 27 21:24:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 28649 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 97869C324C for ; Tue, 27 Oct 2026 21:24:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C1CD46905B; Tue, 27 Oct 2026 22:24:53 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="T5sXeaUH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A14A069053 for ; Tue, 27 Oct 2026 22:24:50 +0100 (CET) Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 603A94BB for ; Tue, 27 Oct 2026 22:22:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1793136158; bh=1htp5OeHPFLOiCyoKncYHYUvikbM9ozj21gD+kYKhb4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=T5sXeaUHuNo0jdLh2jmV6eBx7vx2dIVsnIYxcrMBFtN6ocPjQ/uScBDhEElhjzECJ cHTWN/QAC+bFco8AoHywGEwsvauuCjkbTTM1XmpX5aIoh4c3jNRy0NC3/72SbSX3Jw OpI6b2czZxWRbM2VX14GAu5e8kUi/DXcApk/OKgc= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH 1/4] v4l2: v4l2_camera_proxy: Clear PREPARED flag when queuing buffer Date: Tue, 27 Oct 2026 23:24:44 +0200 Message-ID: <20261027212447.2551591-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261027212447.2551591-1-laurent.pinchart@ideasonboard.com> References: <20261027212447.2551591-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When a buffer is queued with VIDIOC_QBUF, the V4L2 API clears the V4L2_BUF_FLAG_PREPARED flag and set V4L2_BUF_FLAG_QUEUED. The v4l2-compat layer instead sets boths flags, which is reported as an error by v4l2-compliance: Streaming ioctls: test read/write: OK (Not Supported) fail: v4l2-test-buffers.cpp(381): buf_states > 1 fail: v4l2-test-buffers.cpp(1548): buf.check(q, Queued, i) fail: v4l2-test-buffers.cpp(1708): setupMmap(node, q) test MMAP (no poll, REQBUFS): FAIL Fix it by clearing the V4L2_BUF_FLAG_PREPARED flag. There is then no need to clear the flag in vidioc_dqbuf() any more. Fixes: 7278a59eba64 ("v4l2: v4l2_camera_proxy: Dispatch VIDIOC_PREPARE_BUF") Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi --- src/v4l2/v4l2_camera_proxy.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp index 210c8e875528..ca1115d017ac 100644 --- a/src/v4l2/v4l2_camera_proxy.cpp +++ b/src/v4l2/v4l2_camera_proxy.cpp @@ -649,8 +649,8 @@ int V4L2CameraProxy::vidioc_qbuf(V4L2CameraFile *file, struct v4l2_buffer *arg) if (ret < 0) return ret; - buffers_[arg->index].flags |= V4L2_BUF_FLAG_QUEUED | - V4L2_BUF_FLAG_PREPARED; + buffers_[arg->index].flags &= ~V4L2_BUF_FLAG_PREPARED; + buffers_[arg->index].flags |= V4L2_BUF_FLAG_QUEUED; arg->flags = buffers_[arg->index].flags; @@ -694,7 +694,7 @@ int V4L2CameraProxy::vidioc_dqbuf(V4L2CameraFile *file, struct v4l2_buffer *arg, struct v4l2_buffer &buf = buffers_[currentBuf_]; - buf.flags &= ~(V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE | V4L2_BUF_FLAG_PREPARED); + buf.flags &= ~(V4L2_BUF_FLAG_QUEUED | V4L2_BUF_FLAG_DONE); buf.length = sizeimage_; *arg = buf;