From patchwork Tue Oct 13 19:43:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28445 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4070EC32F4 for ; Tue, 13 Oct 2026 19:44:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EE42B68D7C; Tue, 13 Oct 2026 21:44:05 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="CePALUch"; dkim-atps=neutral Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 98080689FB for ; Tue, 13 Oct 2026 21:44:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1791920640; cv=none; d=zohomail.com; s=zohoarc; b=UCEVPJCFmSIpCqy57e9X55+DCl921EFxAwY84n0TQnvrA+a/Bqv7TV6k+7J/BC2l7TlVhqHN5Zbhl8tu2hN8DuZkqhchaMr7n9dsubGiFxnW9zqaS2p/uZc0cOaPdA66XQMgE2ACI4ECUW91aR2fbkMCMCyx4kjoqMe5lhbjQ34= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791920640; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=NfE5k/qHVz9t/zuYflWqFUUD0ekuFdaLtS1MWR9EhvI=; b=jI0GEkaBLu9oP7AN/ZFgEUj+uBcj5MfXIidUOFUYJIJaY+Y8Qfh56PogqOpSgzPxCZroincAledS11mZcdsKEpm3CHrsOmtI7DZ5Hx+3+I87Br3KoMeJRxOb8HIMy1jrNS4jMc8rkAtMiB6YAmXdm193kecn8g2kAw3jBMav/us= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791920640; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=NfE5k/qHVz9t/zuYflWqFUUD0ekuFdaLtS1MWR9EhvI=; b=CePALUchNQVGywtovSXXI8aChtjrAZdiQnyBMf/4ATDYo8OJDgVSCfq6E9zhSUYE Nu9XAdGalTQ9R18CS4ySPg7sol0Z41sRZQKvPoUlDCvOC1UGkTiwuugWrUADG8tEryJ XBYKobskGgl86zn28mGfH2rIVx3/wks0vfY4KayE= Received: by smtp.zohomail.com with SMTPS id 1791920638048669.0706230401444; Tue, 13 Oct 2026 12:43:58 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , =?utf-8?q?Barnab=C3=A1s_P?= =?utf-8?b?xZFjemU=?= , Kieran Bingham Subject: [PATCH v3 1/2] virtual: Fill alpha channels Date: Tue, 13 Oct 2026 21:43:44 +0200 Message-ID: <20261013194345.98661-2-robert.mader@collabora.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261013194345.98661-1-robert.mader@collabora.com> References: <20261013194345.98661-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While libyuv::ARGBToNV12() seems to ignore the alpha values, let's set them to fully opaque to avoid potential glitches going forward. Signed-off-by: Robert Mader Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp index 1be3847d63a4..7b53e8b32327 100644 --- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp +++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp @@ -100,7 +100,7 @@ void ColorBarsGenerator::configure(const Size &size) *buf++ = kColorBar[index][2]; /* B */ *buf++ = kColorBar[index][1]; /* G */ *buf++ = kColorBar[index][0]; /* R */ - *buf++ = 0x00; /* A */ + *buf++ = 0xff; /* A */ } } } @@ -127,7 +127,7 @@ void DiagonalLinesGenerator::configure(const Size &size) *buf++ = kColorBar[index][2]; /* B */ *buf++ = kColorBar[index][1]; /* G */ *buf++ = kColorBar[index][0]; /* R */ - *buf++ = 0x00; /* A */ + *buf++ = 0xff; /* A */ } } }