From patchwork Tue Oct 13 10:22:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28441 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AB316BDCB6 for ; Tue, 13 Oct 2026 10:23:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D296268AB7; Tue, 13 Oct 2026 12:23:09 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="E4lmfqJc"; dkim-atps=neutral Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 982FE68A72 for ; Tue, 13 Oct 2026 12:23:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1791886984; cv=none; d=zohomail.com; s=zohoarc; b=nA3mt7UwcNuBC1J8yWNkOIDrTJ1/OOxL0QkEzMF+YNMqD2bH7ErGEA90ECldx9Tftc1cSpKu0yiEORPqo/VQJmvaCKBjOqen5CpbBu7YXCLWapWBgE0LfCcPQP1xR4AoO7d3UyqSDx0jS9ycEZxGMgb7S4FHJiZemaDOva9r7xc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791886984; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=9cvPuGIAqBoPuNHxuohswH5V+goNSYNAuvn2l0e2L2o=; b=ZZSr6Etu6PpYPazpYN6/PkojrBYgYRxnrvAZ2B7EpazcjVCgfTxERoO/P6NDd6VkKo+QQlIRlOIqvGN4SZqdD5w/Nx0jXCL+e7INo1qgzpAnRSDtxmCPOsubA7cyjbMR3za6kHGCpm1Moa/e+XBwrH6lFu1PfO6kbb3CM3mvaYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791886984; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=9cvPuGIAqBoPuNHxuohswH5V+goNSYNAuvn2l0e2L2o=; b=E4lmfqJcNVYZHIvjujv5fGdAl31xKi7NaSD4iJm1Vj0Qhh+uk5NDU7vLddFp2sll SRdv6ISvxxj/CRweL6NpfQGPd7PVWvlqIj+ehjHP0KsVlelUsn7YKCjnK6FPf1/q77t yFskFsVflV3/wWrryJkd4+JE+GeQwBbwKVLhgh5A= Received: by smtp.zohomail.com with SMTPS id 1791886981977659.1960533232441; Tue, 13 Oct 2026 03:23:01 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH v2] virtual: Implement framerate handling Date: Tue, 13 Oct 2026 12:22:56 +0200 Message-ID: <20261013102256.41602-1-robert.mader@collabora.com> X-Mailer: git-send-email 2.56.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Throttle requests to the minimal frame duration in order to honor the configured framerates. Client-requested values are ignored for now. Signed-off-by: Robert Mader --- Changes in v2: - Remove debug log in order to avoid CI issues. - Simplify code in queueRequestDevice(), hopefully making it easier to follow. Changes in v1 (from RFC version): - Use std::this_thread::sleep_for() instead usleep() (Barnabás) - Sleep only once per request, after generating all frames - Remove control handling in start() (defer that for later) - Reset state in stop() instead of start() --- src/libcamera/pipeline/virtual/virtual.cpp | 42 ++++++++++++++++++---- src/libcamera/pipeline/virtual/virtual.h | 1 + 2 files changed, 37 insertions(+), 6 deletions(-) diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index e25dd85a7391..5f00f7cc6b37 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -130,6 +130,9 @@ VirtualCameraData::VirtualCameraData(PipelineHandler *pipe, void VirtualCameraData::processRequest(Request *request) { + int64_t sensorTimestamp = *request->metadata().get(controls::SensorTimestamp); + std::vector buffers; + for (const auto &[stream, buffer] : request->buffers()) { bool found = false; /* map buffer and fill test patterns */ @@ -139,7 +142,7 @@ void VirtualCameraData::processRequest(Request *request) fmd.status = FrameMetadata::Status::FrameSuccess; fmd.sequence = streamConfig.seq++; - fmd.timestamp = currentTimestamp(); + fmd.timestamp = sensorTimestamp; std::span planes = buffer->planes(); for (const auto [i, p] : utils::enumerate(planes)) @@ -151,12 +154,21 @@ void VirtualCameraData::processRequest(Request *request) stream->configuration().size, buffer)) fmd.status = FrameMetadata::Status::FrameError; - bufferCompleted.emit(buffer); + buffers.push_back(buffer); break; } } ASSERT(found); } + + const uint64_t now = currentTimestamp(); + if (now < static_cast(sensorTimestamp)) { + std::chrono::nanoseconds duration(sensorTimestamp - now); + std::this_thread::sleep_for(duration); + } + + for (auto buffer : buffers) + bufferCompleted.emit(buffer); } VirtualCameraConfiguration::VirtualCameraConfiguration(VirtualCameraData *data) @@ -349,18 +361,36 @@ void PipelineHandlerVirtual::stopDevice(Camera *camera) /* Process pending `bufferCompleted` signals. */ thread()->dispatchMessages(Message::Type::InvokeMessage, this); data->bufferCompleted.disconnect(this); + data->lastTimestamp = 0; while (!data->queuedRequests_.empty()) cancelRequest(data->queuedRequests_.front()); } -int PipelineHandlerVirtual::queueRequestDevice([[maybe_unused]] Camera *camera, - Request *request) +int PipelineHandlerVirtual::queueRequestDevice(Camera *camera, Request *request) { VirtualCameraData *data = cameraData(camera); - const auto timestamp = currentTimestamp(); + const uint64_t now = currentTimestamp(); + uint64_t minFrameDurationNsec; + uint64_t targetTimestamp; + + auto frameDurationLimits = camera->controls().find(&controls::FrameDurationLimits); + if (false && frameDurationLimits != camera->controls().end()) { + minFrameDurationNsec = + frameDurationLimits->second.min().get() * 1000; + } else { + /* Default to 30 FPS */ + minFrameDurationNsec = 33333 * 1000; + } + + targetTimestamp = data->lastTimestamp + minFrameDurationNsec; + if (targetTimestamp < now) + targetTimestamp = now; + data->lastTimestamp = targetTimestamp; + + request->_d()->metadata().set(controls::SensorTimestamp, + targetTimestamp); - request->_d()->metadata().set(controls::SensorTimestamp, timestamp); data->invokeMethod(&VirtualCameraData::processRequest, ConnectionTypeQueued, request); diff --git a/src/libcamera/pipeline/virtual/virtual.h b/src/libcamera/pipeline/virtual/virtual.h index 215e56fa3b9d..84b53dfb66f3 100644 --- a/src/libcamera/pipeline/virtual/virtual.h +++ b/src/libcamera/pipeline/virtual/virtual.h @@ -66,6 +66,7 @@ public: std::vector streamConfigs_; Signal bufferCompleted; + uint64_t lastTimestamp = 0; }; } /* namespace libcamera */