From patchwork Fri Oct 9 19:40:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28432 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 241C1BDCB2 for ; Fri, 9 Oct 2026 19:40:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DF32868A3C; Fri, 9 Oct 2026 21:40:40 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="Px1yT7lY"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BC1168A36 for ; Fri, 9 Oct 2026 21:40:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1791574834; cv=none; d=zohomail.com; s=zohoarc; b=iuWtFgudK4m5mKpQQhpchWOb8cQBXJR/nalYSNFAPf1wGXJIOzwIfAXx2s9oCU39mYeRrpfUJVVL7pSfe0iSd/LnAcJKVVNPcbOmcuBJZSD+jApDsxGoYuYSGji/KhFAHHnsBCJ4aFgaYuqy6Vx9V6s0AG71plME/W/cNqvk6QI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791574834; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=AWRDyyHQrD707ihL5DnV8Cawmazt7IE9MJNG9Kln4Qs=; b=MbC+M3RJyqbRiiQMV8kgyFR3Pp4fWMHJaWQtRXdaiuTQwOWQQZqzjDD5Xr4NGgLKZMEC2YjgGB5UpIzeoToHLbehrj7taBJa1udVL14ngPchIssemO+CR1l8n0U1rD3scygs4swLEqrEVqDD/CaY1UP1IiLQflpd0+YNrzbvshs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791574834; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=AWRDyyHQrD707ihL5DnV8Cawmazt7IE9MJNG9Kln4Qs=; b=Px1yT7lYZ3k0VS9AE8lFpZtZXlTkpbEOu+99aNBJo++hIs/SuGCFXTjhOpZng4fg usmWJBeXvrTMiOL+dHojdg2jdAU0d7WRLSOzVzfGOk6X5KznKEJWWsD70Le+q3wSsgk COIFoHwhKXct2s7fJGGzhdSok7U4mxq0J9oy5Fxs= Received: by smtp.zohomail.com with SMTPS id 179157483448942.570832211052675; Fri, 9 Oct 2026 12:40:34 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH v2 3/4] virtual: Validate stride and frameSize Date: Fri, 9 Oct 2026 21:40:06 +0200 Message-ID: <20261009194007.23175-4-robert.mader@collabora.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009194007.23175-1-robert.mader@collabora.com> References: <20261009194007.23175-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" If a client requested a specific stride that's incompatible with what we'll produce, let the client know. Signed-off-by: Robert Mader --- src/libcamera/pipeline/virtual/virtual.cpp | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index 7ed2d0b7f596..6e97981b0f40 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -240,13 +240,20 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate() adjusted = true; } + auto stride = info.stride(cfg.size.width, 0); + auto frameSize = info.frameSize(cfg.size); + if ((cfg.stride && cfg.stride != stride) || + (cfg.frameSize && cfg.frameSize != frameSize)) { + status = Adjusted; + adjusted = true; + } + cfg.stride = stride; + cfg.frameSize = frameSize; + if (adjusted) LOG(Virtual, Info) << "Stream configuration adjusted to " << cfg.toString(); - cfg.stride = info.stride(cfg.size.width, 0, 1); - cfg.frameSize = info.frameSize(cfg.size, 1); - cfg.bufferCount = VirtualCameraConfiguration::kBufferCount; }