From patchwork Fri Oct 9 19:40:04 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28430 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D46B2BDCB2 for ; Fri, 9 Oct 2026 19:40:35 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8A74568A21; Fri, 9 Oct 2026 21:40:35 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="jyPmbLXq"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CAE2C68A13 for ; Fri, 9 Oct 2026 21:40:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1791574830; cv=none; d=zohomail.com; s=zohoarc; b=bQlKonPIpjE9syHXQdruqmhZlTU8QMUJdgAwyFJCO4kRTUvR+7SrZQNMECDq6RkOMW6cx1D4mNOFGtyi1OjCQ9+93nQlMtuK+570qYK7s9a3C8IKOMuGyc3LvKxp6vZzd1mH5BD2xGKVgdi7m3vUjLTaGHh413ZLeeQizOv5lOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791574830; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=0SCss57sCwknN2/GCYARPpt4ehPzBJOLo6rMcAnPDbQ=; b=ESr9mf6uTFEhqBBwk4SytgjpXmPrkc7BBN0//kIXyDE0zwXryCCHVBVZQVx9RENRAtOMjYt3YVzCFalzuC4RkfLiYb8ZFHJ+90zREtePjDvTvdzHWnXx7HnYaHLt6a+IxcF+11n4Sb/OB/FpuVm0qPmH7alHWQaQ4PvjCQya8tE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791574830; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=0SCss57sCwknN2/GCYARPpt4ehPzBJOLo6rMcAnPDbQ=; b=jyPmbLXq0SeIYq5vOUCcWp0cMi7bhS8B0en5aR2l2GakOU9zyam4k1V0N/1Z6FO7 a3Fgenn+hqJ0pfQoRJayLA2wWCMXIAk/IC12ARcua8B9nxHi7JV3+buZTSyrW9opPmc /o0ni9SI9f4GVv3R1ccsgkXvZ+9zC4EhizN4xu5Y= Received: by smtp.zohomail.com with SMTPS id 1791574829997535.7908148987516; Fri, 9 Oct 2026 12:40:29 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , =?utf-8?q?Barnab=C3=A1s_P?= =?utf-8?b?xZFjemU=?= Subject: [PATCH v2 1/4] virtual: Fill alpha channels Date: Fri, 9 Oct 2026 21:40:04 +0200 Message-ID: <20261009194007.23175-2-robert.mader@collabora.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261009194007.23175-1-robert.mader@collabora.com> References: <20261009194007.23175-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While libyuv::ARGBToNV12() seems to ignore the alpha values, let's set them to fully opaque to avoid potential glitches going forward. Signed-off-by: Robert Mader Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp index 1be3847d63a4..7b53e8b32327 100644 --- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp +++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp @@ -100,7 +100,7 @@ void ColorBarsGenerator::configure(const Size &size) *buf++ = kColorBar[index][2]; /* B */ *buf++ = kColorBar[index][1]; /* G */ *buf++ = kColorBar[index][0]; /* R */ - *buf++ = 0x00; /* A */ + *buf++ = 0xff; /* A */ } } } @@ -127,7 +127,7 @@ void DiagonalLinesGenerator::configure(const Size &size) *buf++ = kColorBar[index][2]; /* B */ *buf++ = kColorBar[index][1]; /* G */ *buf++ = kColorBar[index][0]; /* R */ - *buf++ = 0x00; /* A */ + *buf++ = 0xff; /* A */ } } }