From patchwork Fri Oct 9 10:48:03 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 28425 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 40304BDCB6 for ; Fri, 9 Oct 2026 10:48:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EBD4668A26; Fri, 9 Oct 2026 12:48:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UMY3+Kj5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2970F689C3 for ; Fri, 9 Oct 2026 12:48:35 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a01:599:814:de78:3e2b:9bce:b9f5:d608]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B4C4C4A; Fri, 9 Oct 2026 12:46:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1791542796; bh=F8pgB8k5pbTwSVBo7VeQIvgHKVHF8KbHt88yQWgygds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UMY3+Kj5hxJN8cRs8xUyXFqoTVa1NYpE1AsX0OMocZTOZsGoQ/9vcbsm8FzLNuPuP NJoFwOi6gfjr7lgFieAd31Bzk3lmmNP6LjbtaLvhrsoJH/ZxS2boWV5rqn3dhrTQd9 2CFpnsJtsZXKj59wspfFb3pxZU2cxsS950U4JIZk= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Kieran Bingham , Daniel Scally Subject: [PATCH v2 1/3] libcamera: converter: dw100_vertexmap: Add debug logging of dewarp parameters Date: Fri, 9 Oct 2026 12:48:03 +0200 Message-ID: <20261009104826.45426-2-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261009104826.45426-1-stefan.klug@ideasonboard.com> References: <20261009104826.45426-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When analyzing issues with the dewarper it is very helpful to be able to get a log of the complete dewarper parameter set. Add the missing lens dewarp parameters. Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Daniel Scally --- Changes in v2: - Collected tags --- .../converter/converter_dw100_vertexmap.cpp | 22 ++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/libcamera/converter/converter_dw100_vertexmap.cpp b/src/libcamera/converter/converter_dw100_vertexmap.cpp index 5b813435706e..b36814c80a19 100644 --- a/src/libcamera/converter/converter_dw100_vertexmap.cpp +++ b/src/libcamera/converter/converter_dw100_vertexmap.cpp @@ -578,7 +578,27 @@ std::vector Dw100VertexMap::getVertexMap() << " scaleX: " << effectiveScaleX_ << " scaleY: " << effectiveScaleX_ << " rotation: " << rotation_ - << " offset: " << effectiveOffset_; + << " offset: " << effectiveOffset_ + << " lensDewarpEnable: " << lensDewarpEnable_; + + if (dewarpParams_.has_value()) + LOG(Converter, Debug) + << "Lens dewarp parameters cm: " << dewarpParams_->cm + << " coeffs: [" << dewarpParams_->coefficients.k1 + << ", " << dewarpParams_->coefficients.k2 + << ", " << dewarpParams_->coefficients.p1 + << ", " << dewarpParams_->coefficients.p2 + << ", " << dewarpParams_->coefficients.k3 + << ", " << dewarpParams_->coefficients.k4 + << ", " << dewarpParams_->coefficients.k5 + << ", " << dewarpParams_->coefficients.k6 + << ", " << dewarpParams_->coefficients.s1 + << ", " << dewarpParams_->coefficients.s2 + << ", " << dewarpParams_->coefficients.s3 + << ", " << dewarpParams_->coefficients.s4 + << "]"; + else + LOG(Converter, Debug) << "Lens dewarp parameters: None"; Matrix3x3 outputToSensor = Matrix3x3::identity(); /* Move to center of output */