From patchwork Thu Oct 8 21:11:46 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 28419 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BC483C3305 for ; Thu, 8 Oct 2026 21:12:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5473E68DEF; Thu, 8 Oct 2026 23:12:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="USpOhsn5"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C17D68A07 for ; Thu, 8 Oct 2026 23:12:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1791493925; cv=none; d=zohomail.com; s=zohoarc; b=Y8P0GMn6sHcbJo794kYCnIwUB6eX64dGWeERZ7hMvcT9XmCSKKQHhDmdC9Nzws0k8gMmSd12/aSY+n3cJ2b4NlDXJyn7N15eDv84zjfxKOHNN9CFhNYOTtXZpXmtRMhuQSXCAcPT4KxwawefIZVRbMA56hOWHCbR1VI/20YEhFA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791493925; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=HlwzqNZxV8BeLYIzrgOvzGwRneQuQKJbnngjNwC0/8g=; b=FMqCwl91Yg2dmLVDvP4pKy7z1w5zBxfk2K6tAZLP25+tZoct3Xp361T9JBE4JZ0Hdz+P6PLgnnICPIb/b1DQSyPkRTA6hWwXxheL9Wn9HjO1f7YoR///AIY39lfXK9PmX/dMk8/QGFTVBbtsjzCjn3KOQ43b2IJetfoEDgpszd4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791493925; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=HlwzqNZxV8BeLYIzrgOvzGwRneQuQKJbnngjNwC0/8g=; b=USpOhsn5TWudUOc43kLDPQWDrqzfRzY3iq8T8LYCRP/wU6gq04zabzzJ+UoAZ5Sj Uer3ohitIAEsLpnNQKafRRH9qGd5rvF0h9zO1bUFav8FNdLXZFCd/qcD00fHgFFbTZU j6/eRPJQxGk2MUSojm2lwDz0lLPrAE9wcaSEO4Gw= Received: by smtp.zohomail.com with SMTPS id 1791493924150713.6893504032488; Thu, 8 Oct 2026 14:12:04 -0700 (PDT) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH 1/4] virtual: Fill alpha channels Date: Thu, 8 Oct 2026 23:11:46 +0200 Message-ID: <20261008211149.51765-2-robert.mader@collabora.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261008211149.51765-1-robert.mader@collabora.com> References: <20261008211149.51765-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" While libyuv::ARGBToNV12() seems to ignore the alpha values, let's set them to fully opaque to avoid potential glitches going forward. Signed-off-by: Robert Mader Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/virtual/test_pattern_generator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp index 1be3847d63a4..7b53e8b32327 100644 --- a/src/libcamera/pipeline/virtual/test_pattern_generator.cpp +++ b/src/libcamera/pipeline/virtual/test_pattern_generator.cpp @@ -100,7 +100,7 @@ void ColorBarsGenerator::configure(const Size &size) *buf++ = kColorBar[index][2]; /* B */ *buf++ = kColorBar[index][1]; /* G */ *buf++ = kColorBar[index][0]; /* R */ - *buf++ = 0x00; /* A */ + *buf++ = 0xff; /* A */ } } } @@ -127,7 +127,7 @@ void DiagonalLinesGenerator::configure(const Size &size) *buf++ = kColorBar[index][2]; /* B */ *buf++ = kColorBar[index][1]; /* G */ *buf++ = kColorBar[index][0]; /* R */ - *buf++ = 0x00; /* A */ + *buf++ = 0xff; /* A */ } } }