From patchwork Wed Sep 16 14:39:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 28303 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B7D6FBDE6B for ; Wed, 16 Sep 2026 14:40:25 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 690EA686F0; Wed, 16 Sep 2026 16:40:25 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UOR2tHkK"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CF0CD68244 for ; Wed, 16 Sep 2026 16:40:24 +0200 (CEST) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c69:85de:a3c9:9357:b164:bf0b]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 03ED4558; Wed, 16 Sep 2026 16:38:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789569523; bh=4P7woN9YgkXgv+PekPP4ElflpwUnxxN30DeldC0cgDY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=UOR2tHkKdkr7TNldFnVXGrmqOX+32iycH7D1EUEqfxq1Er+pkzqdS9UnIxBLMj+xZ i/tvvXe5y9AbtoQ0cKW4IzNGjnVGGb5choD62Vk6o/JDKKxTyiIlyQKiyzLdHtL4cx ZuZwoPMS3+zocttyKhxxClrHuH8YtQtNfBMtwIzA= From: Jai Luthra Date: Wed, 16 Sep 2026 20:09:39 +0530 Subject: [PATCH v3 3/8] ipa: rpi: vc4: Add Bcm2835Params helper MIME-Version: 1.0 Message-Id: <20260916-pi4-upstream-v3-3-4666708d8829@ideasonboard.com> References: <20260916-pi4-upstream-v3-0-4666708d8829@ideasonboard.com> In-Reply-To: <20260916-pi4-upstream-v3-0-4666708d8829@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart , Kieran Bingham , Paul Elder , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2656; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=4P7woN9YgkXgv+PekPP4ElflpwUnxxN30DeldC0cgDY=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBqqqo/J5WgwF2HKa5ms6iDnw1e3NGyYl5VRfShd mWzVdHCaM2JAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCaqqqPwAKCRBD3pH5JJpx RfToD/wOoJsBas5oZM0YbxFLTHtfz7LpZ0qYf89+deJaIU9Jexv/ucgxxeLsXWu6AopqLNb/5BI 8lRlSa/u/xwYK6l+LLIasI0nk41elQstvdFIWit7AQlz8elHFu8UoDTwTUxNe/XHa9U0BXF7iUy eKJOxdgGUkIl+uFBljxCljYhPzqnxQnBxDgAI/MNsbwYIPIhZUyHL823cf5Ah03c/UdmuoKbipC 2axjn3N3AqBrejwjV8ckpenlI5mxSHpt7WCzqNjrnzx8lY97WpQtqx3R2bByQl/c98qciFXcYQD EMQx7/5reX0MW372fX/H/LjJxJeaZujcL6BryakDzYRq69C/47ymcAw/cm2DEu5pRrDsMDmbGQl dG+wOJRTgxtHChfOH5OfRySN1bsfVxRCuTDvPiXAuWAkzKhd6HI9sh9IDk/4Lfba1YUDW2IwXor yJsCW8Qz0kT076JzWHca0IGWg747LL0FaJmhJJxDkQO0UBPkNLvBo6B7O5dj/dEjeDoSh8uMXRd QqOtaI1hZR5E27a6/0cEjtqEEeTY8BITWuX6/mwpx69a+HEMXoXWpHlnLeO3Ov/kncUuhP/ZDFV hfhedroxEQuQlpH0Iyi+/0SQkhZN3cwOXMMMP0tbASswOpDwvtsagH0zLLwP7bFYLUqkDXxXmGq HDbS00T7l2Nyobw== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Implement Bcm2835Params to derive from V4L2Params. The mainline driver uses extensible V4L2 parameter for configuration instead of custom V4L2 controls. Reviewed-by: Paul Elder Tested-by: Paul Elder Signed-off-by: Jai Luthra --- src/ipa/rpi/vc4/params.h | 79 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+) diff --git a/src/ipa/rpi/vc4/params.h b/src/ipa/rpi/vc4/params.h new file mode 100644 index 000000000000..3eb7794e7c79 --- /dev/null +++ b/src/ipa/rpi/vc4/params.h @@ -0,0 +1,79 @@ +/* SPDX-License-Identifier: LGPL-2.1-or-later */ +/* + * Copyright (C) 2026, Ideas On Board + * + * Raspberry Pi VC4/BCM2835 ISP Parameters + */ + +#pragma once + +#include + +#include + +#include + +namespace libcamera { + +namespace ipa::RPi { + +enum class BlockType : uint16_t { + BlackLevel, + Geq, + Gamma, + Denoise, + Sharpen, + Dpc, + Cdn, + CcMatrix, + LensShading, + AwbGains, + DGain, +}; + +namespace details { + +template +struct block_type { +}; + +#define BCM2835_DEFINE_BLOCK_TYPE(id, structName, blockId) \ + template<> \ + struct block_type { \ + using type = struct bcm2835_isp_params_##structName; \ + static constexpr bcm2835_isp_param_block_type blockType = \ + BCM2835_ISP_PARAM_BLOCK_##blockId; \ + }; + +BCM2835_DEFINE_BLOCK_TYPE(BlackLevel, black_level, BLACK_LEVEL) +BCM2835_DEFINE_BLOCK_TYPE(Geq, geq, GEQ) +BCM2835_DEFINE_BLOCK_TYPE(Gamma, gamma, GAMMA) +BCM2835_DEFINE_BLOCK_TYPE(Denoise, denoise, DENOISE) +BCM2835_DEFINE_BLOCK_TYPE(Sharpen, sharpen, SHARPEN) +BCM2835_DEFINE_BLOCK_TYPE(Dpc, dpc, DPC) +BCM2835_DEFINE_BLOCK_TYPE(Cdn, cdn, CDN) +BCM2835_DEFINE_BLOCK_TYPE(CcMatrix, cc_matrix, CC_MATRIX) +BCM2835_DEFINE_BLOCK_TYPE(LensShading, lens_shading, LENS_SHADING) +BCM2835_DEFINE_BLOCK_TYPE(AwbGains, awb_gains, AWB_GAINS) +BCM2835_DEFINE_BLOCK_TYPE(DGain, digital_gain, DIGITAL_GAIN) + +struct params_traits { + using id_type = BlockType; + template + using id_to_details = block_type; +}; + +} /* namespace details */ + +class Bcm2835Params : public V4L2Params +{ +public: + Bcm2835Params(std::span data) : + V4L2Params(data, BCM2835_ISP_PARAM_BUFFER_V1) + { + } +}; + +} /* namespace ipa::RPi */ + +} /* namespace libcamera */