From patchwork Wed Sep 16 14:39:37 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jai Luthra X-Patchwork-Id: 28301 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3B890BDE6B for ; Wed, 16 Sep 2026 14:40:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D82E3686F0; Wed, 16 Sep 2026 16:40:15 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QTZRqvP1"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AB614686D9 for ; Wed, 16 Sep 2026 16:40:14 +0200 (CEST) Received: from mail.ideasonboard.com (unknown [IPv6:2401:4900:1c69:85de:a3c9:9357:b164:bf0b]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD4D414C2; Wed, 16 Sep 2026 16:38:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789569513; bh=xtKGr82pWjbCnz3a9rHn0h6hzgB6pA0urZdCVqMBNO0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QTZRqvP11F7wzmFcFJu6UDpC9Qb2zuIYMpNoRh+JYm+G1wlveRVRlCVqWme+vGjJ3 ZQodxZhqUb5Pjnf696uQYixRlk1JtjFUhcusuAolqFAq4W7qGRANpqwFo3+IgOt91F x2CRQDKi6L/aabR0bi/655R5odzXMLAfNVnfvhuo= From: Jai Luthra Date: Wed, 16 Sep 2026 20:09:37 +0530 Subject: [PATCH v3 1/8] ipa: rpi: Drop unused params argument from platformPrepareIsp() MIME-Version: 1.0 Message-Id: <20260916-pi4-upstream-v3-1-4666708d8829@ideasonboard.com> References: <20260916-pi4-upstream-v3-0-4666708d8829@ideasonboard.com> In-Reply-To: <20260916-pi4-upstream-v3-0-4666708d8829@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Naushir Patuck , David Plowman , Laurent Pinchart , Kieran Bingham , Paul Elder , Jai Luthra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4069; i=jai.luthra@ideasonboard.com; h=from:subject:message-id; bh=xtKGr82pWjbCnz3a9rHn0h6hzgB6pA0urZdCVqMBNO0=; b=owEBbQKS/ZANAwAKAUPekfkkmnFFAcsmYgBqqqo9QiXrG+pGhWJCGPU/kW5ts6LjknDy1GgYx U0Cpl5sg+aJAjMEAAEKAB0WIQRN4NgY5dV16NRar8VD3pH5JJpxRQUCaqqqPQAKCRBD3pH5JJpx RdvAEACxyePSLS3u9QYc+8DCQ5JT7yTCi4fhtSCzl63C9wkW/wqwHTo/AZuI52uL+zUQErWJ6Ch kDjY77lDijRj9WFXJzOCrbS9v+qRy4JE+XeeslXRYeDtaipFX3iZOnsmX4eJXTq1+AkvrJfhetx laQH4458Lr40ete+JSouNUHxpU7x7uFoPis1iiFjM48so9NV81FtOdLaUDPIp9wRlmNQvJ4c/bC q43VZV361BakEFgOvYPv6TaZvDdjaAb2PoayOJXEIWHNXGbpV5/IcKAS9fzwJqlJYUTI9x38s3Z diE251FcBCApan04Z6ep6MdfmEr5887ya0LQiY3X+kjf0e+SzLdhSMzapIoriFbxdqUBvLK4x6C b+1Lnd4G8zFz39FfGDK/oYVqfJhDftAkCrLV6Res1aKOvYdSkYJOgoaWTXg9gD8bLOV2FWyqK2N 13zAe6b+NA2yjnwH4UGuQZgv6ef19Ofqoo9OuStO9NQkjbKto0xvMS6lB0o/X8Rx1GYNREPOOGG WsYU7ebGvB/5uTjnorWoI+wflrezZTIrscqjqZAj6xnFI6S47RBIt6CU5n0FZD7SBj/mPHgU9A1 nD5aHHXggBrBtzHo5m4M6emtnnBR/zN6vW5P5g4ZGoQh9jn053bRFhbwKZh+qYMqUMGO4m8Tad0 HwQpwPoDO9G4kWA== X-Developer-Key: i=jai.luthra@ideasonboard.com; a=openpgp; fpr=4DE0D818E5D575E8D45AAFC543DE91F9249A7145 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In IPABase::platformPrepareIsp() we pass PrepareParams but none of the IPAs (vc4 and pisp) use them. So drop it. Reviewed-by: Paul Elder Tested-by: Paul Elder Signed-off-by: Jai Luthra --- src/ipa/rpi/common/ipa_base.cpp | 2 +- src/ipa/rpi/common/ipa_base.h | 3 +-- src/ipa/rpi/pisp/pisp.cpp | 6 ++---- src/ipa/rpi/vc4/vc4.cpp | 5 ++--- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index bc8e65cb0811..293f68454a84 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -501,7 +501,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms) if (processPending_) { controller_.prepare(&rpiMetadata); /* Actually prepare the ISP parameters for the frame. */ - platformPrepareIsp(params, rpiMetadata); + platformPrepareIsp(rpiMetadata); platformPrepareAgc(rpiMetadata); } else platformPrepareAgc(rpiMetadata); diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h index 0d7842f1f742..1c375669c9f7 100644 --- a/src/ipa/rpi/common/ipa_base.h +++ b/src/ipa/rpi/common/ipa_base.h @@ -87,8 +87,7 @@ private: virtual int32_t platformStart(const ControlList &controls, StartResult *result) = 0; virtual int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) = 0; - virtual void platformPrepareIsp(const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) = 0; + virtual void platformPrepareIsp(RPiController::Metadata &rpiMetadata) = 0; virtual void platformPrepareAgc(RPiController::Metadata &rpiMetadata) = 0; virtual RPiController::StatisticsPtr platformProcessStats(std::span mem) = 0; diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index 835934d57897..ed31867786f6 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -232,8 +232,7 @@ private: int32_t platformStart(const ControlList &controls, StartResult *result) override; int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override; - void platformPrepareIsp(const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) override; + void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override; void platformPrepareAgc(RPiController::Metadata &rpiMetadata) override; RPiController::StatisticsPtr platformProcessStats(std::span mem) override; @@ -354,8 +353,7 @@ int32_t IpaPiSP::platformConfigure([[maybe_unused]] const ConfigParams ¶ms, return 0; } -void IpaPiSP::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) +void IpaPiSP::platformPrepareIsp(RPiController::Metadata &rpiMetadata) { std::scoped_lock l(rpiMetadata); diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index 122657b2d0a8..298cf8829258 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -59,7 +59,7 @@ private: int32_t platformStart(const ControlList &controls, StartResult *result) override; int32_t platformConfigure(const ConfigParams ¶ms, ConfigResult *result) override; - void platformPrepareIsp(const PrepareParams ¶ms, RPiController::Metadata &rpiMetadata) override; + void platformPrepareIsp(RPiController::Metadata &rpiMetadata) override; void platformPrepareAgc([[maybe_unused]] RPiController::Metadata &rpiMetadata) override; RPiController::StatisticsPtr platformProcessStats(std::span mem) override; @@ -144,8 +144,7 @@ int32_t IpaVc4::platformConfigure(const ConfigParams ¶ms, [[maybe_unused]] C return 0; } -void IpaVc4::platformPrepareIsp([[maybe_unused]] const PrepareParams ¶ms, - RPiController::Metadata &rpiMetadata) +void IpaVc4::platformPrepareIsp(RPiController::Metadata &rpiMetadata) { ControlList &ctrls = ctrls_;