From patchwork Mon Sep 14 14:53:42 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 28289 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3B83FC3272 for ; Mon, 14 Sep 2026 14:54:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D1D4C686CE; Mon, 14 Sep 2026 16:54:03 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="wagAXAxi"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A150F6869A for ; Mon, 14 Sep 2026 16:53:56 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CFA9EC3B; Mon, 14 Sep 2026 16:52:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789397536; bh=JoTrIF603LB9DWr0bLebkjy8a99o0Xs1KZ/rAQ8/AGQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=wagAXAxiOGzyFF92oZ6yjnFEpjuuy2oNBlsEaqeCgAtgogt7959vOXT5BqhFeJZUN 85dL+Nu/U7vCQaGg/NDSAI7kmFmSYhI1icVkK2BLyMJwpdo9fe02U6MDq3aJCzzYns qY7h1ryfLo/BG4ygGbAFXnmq297w//nwsrjHA4Yc= From: Daniel Scally Date: Mon, 14 Sep 2026 15:53:42 +0100 Subject: [PATCH v4 02/10] ipa: ipu3: Remove ~Awb() from source and header MIME-Version: 1.0 Message-Id: <20260914-ipu3-libipa-rework-v4-2-ff8ee2d3dd24@ideasonboard.com> References: <20260914-ipu3-libipa-rework-v4-0-ff8ee2d3dd24@ideasonboard.com> In-Reply-To: <20260914-ipu3-libipa-rework-v4-0-ff8ee2d3dd24@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally , =?utf-8?q?Barnab=C3=A1s_?= =?utf-8?b?UMWRY3pl?= , Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1468; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=JoTrIF603LB9DWr0bLebkjy8a99o0Xs1KZ/rAQ8/AGQ=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBqqAqA0fLCxOolz2NGoytWBF06ehB8pMPROzzVi KOv4NeVAziJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaqgKgAAKCRDISVd6bEV1 MheFD/4uuaCJCfv8OQ96kwQ1dEnQ7a/YMgjyFmgmf5bIB2LSBMn+bysklwm29Xz1CPADtVyCwA7 rllKMGKPfh5h+FfMq68XA+ySt0vQWil3ZdRpdfCtf87GlBC+5VqCy4eRL33aDQNqZrY0toWeEVM UXdWTcd8+D7ho/HFL+1pKZFm3zZnIQz5Byop6y1NnArWYTAGjyG5gZFfLx582spyEmhnntBoM3W b4vg4tKVPMYSAL5NUltEAGxti5o4VVPvscSf0Qw5ju6E2xmqmtwlcRxkyWK6BUz5sIvhqvjnq4E S0PnT89v3o/2FosgIgY9JbofM9D1i8/kgKqVitB2VKX2c0E15vds/QcRIHjlqcOgrBvmtqWZC2w Y/Xg+ECSOou8pUmP8JpSZQ5FTtK+UaGIOc4vOFHLuk672k/8PYPkEx/SI3hyPRpk9L7tps4z6E8 8S5dCdu4m2e5iVnAtk3DFuXSD9vrhcLXUYsQ4q6/roY2E6a3l8a1gc1tPkg+QLeMHmAXbgyMhfx q/QRpdycSuPwBgcBpq+wIWCnrJfv8h20c4ACM9xgvjxoXC2pTymg6D6eO0IA9znaO2fqd8sxRY4 k993uQj92VS5uuc8ikUheRYS6hZxE8Gx8Tb8ZUk6GeQ7IV2grAYTt5M7t3mYvUgkoR1zkwvyH44 D1L9fd0g2AmifRQ== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove the ~Awb() definition from the source and header files and simply allow the compiler to provide the default implementations. Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Signed-off-by: Daniel Scally --- Changes in v4: - None Changes in v3: - None Changes in v2: - None --- src/ipa/ipu3/algorithms/awb.cpp | 2 -- src/ipa/ipu3/algorithms/awb.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -195,8 +195,6 @@ Awb::Awb() zones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY); } -Awb::~Awb() = default; - /** * \copydoc libcamera::ipa::Algorithm::configure */ diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h index dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644 --- a/src/ipa/ipu3/algorithms/awb.h +++ b/src/ipa/ipu3/algorithms/awb.h @@ -38,7 +38,6 @@ class Awb : public Algorithm { public: Awb(); - ~Awb(); int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; void prepare(IPAContext &context, const uint32_t frame,