From patchwork Mon Sep 14 14:02:54 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 28285 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CE189C327D for ; Mon, 14 Sep 2026 14:05:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 13C396872B; Mon, 14 Sep 2026 16:05:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="i1tC5Q9K"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 980D7686FC for ; Mon, 14 Sep 2026 16:05:14 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a279:75fa:1f6c:7f40]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D9AEC14; Mon, 14 Sep 2026 16:03:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789394614; bh=5Fv6TX6SsefuJFcdFIpAt6c+RZ+DeHocFzw/lruY12c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i1tC5Q9KymjFCfxZRQLB9gENPjWQd53rEfTmwlttV6Hg8D4XjWMsJMxjLeM9o8vL3 /ywJwRAJldAaeRHMFsPpX9qITIf+a/fp3g1Q9N5gl2lxpXWhKUXGhmdAHHRLX+1IN0 Ly1sRWHJjuVYfq1Cs0AKtYDnWz9O9VUDThxRpihQ= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 41/41] ipa: rkisp1: Increase regulation speed Date: Mon, 14 Sep 2026 16:02:54 +0200 Message-ID: <20260914140309.3354666-42-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914140309.3354666-1-stefan.klug@ideasonboard.com> References: <20260914140309.3354666-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that the rkisp1 is well synchronized, we can safely increase the regulation speed and reduce the number of startup frames. With current settings, the results based on the stats for frame 0 are active on frame 5. Setting the startup frames to 7 leaves room for one additional lost frame. While at it, format the code in a checkstyle compatible way. Signed-off-by: Stefan Klug --- src/ipa/rkisp1/algorithms/agc.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp index 41680e5c4ffd..0c1ad3b6c525 100644 --- a/src/ipa/rkisp1/algorithms/agc.cpp +++ b/src/ipa/rkisp1/algorithms/agc.cpp @@ -137,11 +137,13 @@ int Agc::init(IPAContext &context, const ValueNode &tuningData) { int ret; - ret = agc_.init(tuningData, context.camHelper.get(), { - .sensorInfo = context.sensorInfo, - .sensorControls = context.sensorControls, - .ctrlMap = context.ctrlMap, - }); + ret = agc_.init(tuningData, context.camHelper.get(), + { .sensorInfo = context.sensorInfo, + .sensorControls = context.sensorControls, + .ctrlMap = context.ctrlMap, + /* rkisp1 is well synchronized, increase the speed. */ + .numStartupFrames = 7, + .regulationSpeed = 0.6 }); if (ret) return ret;