From patchwork Mon Sep 14 14:02:34 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 28265 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 26C9FC335B for ; Mon, 14 Sep 2026 14:04:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8FFD9686E0; Mon, 14 Sep 2026 16:04:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="S79LZzHx"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F6206869A for ; Mon, 14 Sep 2026 16:04:24 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a279:75fa:1f6c:7f40]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BDBC929; Mon, 14 Sep 2026 16:02:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789394564; bh=CqHZMSbuFPqXSDjcwGf1Sq/oLtjBHdFYKPLZUd+H6bU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S79LZzHxAa1Q+RSMX0FiX1tlkRAAPMTnuXCiNYk09YiaymFK9EyYYmFz/TgfaCm+A mLGesMXO8A6+RGGCsp1P8sjI8RejfQf7gVeTFXP+uERIu0YExURb+AsfPemqYa6ZXp AfXw24FMB7m5PW0tVMIJGTdNJmYHzcGOMvEXbM6A= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug Subject: [PATCH v3 21/41] ipa: rksip1: Call libipa::Awb::process() when stats are null Date: Mon, 14 Sep 2026 16:02:34 +0200 Message-ID: <20260914140309.3354666-22-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914140309.3354666-1-stefan.klug@ideasonboard.com> References: <20260914140309.3354666-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Call process() on the algorithm implementation even without a stats buffer to ensure that metadata is populated unconditionally. Print the error only in the case that there was a stats buffer. Having no stats buffer at all is a legal condition. Signed-off-by: Stefan Klug --- src/ipa/rkisp1/algorithms/awb.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index cf8dc14308e2..f39153355a12 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -195,7 +195,10 @@ void Awb::process(IPAContext &context, ControlList &metadata) { if (!stats || !(stats->meas_type & RKISP1_CIF_ISP_STAT_AWB)) { - LOG(RkISP1Awb, Error) << "AWB data is missing in statistics"; + if (stats) + LOG(RkISP1Awb, Error) << "AWB data is missing in statistics"; + awbAlgo_.process(context.activeState.awb, frameContext.awb, RkISP1AwbStats({}), + frameContext.lux.lux, metadata); return; }