From patchwork Mon Sep 14 14:02:22 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 28253 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ECF6DC3226 for ; Mon, 14 Sep 2026 14:03:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8DFB9686BC; Mon, 14 Sep 2026 16:03:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="vSstf5ie"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 60076686B0 for ; Mon, 14 Sep 2026 16:03:51 +0200 (CEST) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:a279:75fa:1f6c:7f40]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F49F9A4; Mon, 14 Sep 2026 16:02:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789394531; bh=BEF9XjIpOJrqROwo03ZcUJTqHJg/IM34H063Q1tBce8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vSstf5ietrRSd7VNACizduuqEfT8UzMAhaC8JPj5Z1R3rjFPvlHqRwFVT3Uwg9WLz uPIpwXuHb6bh5eumU5dWzSMxFeU5JLMAvjTpN6Iygd7CTp8ZpOBsVo7oLj3koahBeF TlDLGRGZl0sHpbli0xeLAhjnoU7VkzK8eSX7binU= From: Stefan Klug To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Paul Elder Subject: [PATCH v3 09/41] libcamera: delayed_controls: Ignore double pushes for the same frame number Date: Mon, 14 Sep 2026 16:02:22 +0200 Message-ID: <20260914140309.3354666-10-stefan.klug@ideasonboard.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260914140309.3354666-1-stefan.klug@ideasonboard.com> References: <20260914140309.3354666-1-stefan.klug@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" For successful PFC a single sequence must only be pushed once to delayed controls. Such a situation can occur if no-ops were pushed in delayed controls due to a buffer underrun. Signed-off-by: Stefan Klug Reviewed-by: Paul Elder --- Changes in v2: - Collated double log message - Collected tag --- src/libcamera/delayed_controls.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp index 90c7046c66f7..10246d31cbb1 100644 --- a/src/libcamera/delayed_controls.cpp +++ b/src/libcamera/delayed_controls.cpp @@ -174,8 +174,9 @@ bool DelayedControls::push(uint32_t sequence, const ControlList &controls) { if (sequence < queueCount_) { LOG(DelayedControls, Warning) - << "Double push for sequence " << sequence - << " current queue index: " << queueCount_; + << "Ignored double push for sequence " << sequence + << ". Current queue index: " << queueCount_; + return true; } while (sequence > queueCount_) { @@ -282,7 +283,10 @@ ControlList DelayedControls::get(uint32_t sequence) */ void DelayedControls::applyControls(uint32_t sequence) { - LOG(DelayedControls, Debug) << "frame " << sequence << " started"; + LOG(DelayedControls, Debug) + << "Apply controls for: " << sequence + << " (instant controls for frame " + << (sequence - maxDelay_) << ")"; while (queueCount_ - 1 < sequence) { LOG(DelayedControls, Warning)