From patchwork Fri Sep 11 15:39:17 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "D. Manresa" X-Patchwork-Id: 28232 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 18807C3352 for ; Fri, 11 Sep 2026 15:39:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 831F468678; Fri, 11 Sep 2026 17:39:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a2cNqwaS"; dkim-atps=neutral Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E41968643 for ; Fri, 11 Sep 2026 17:39:04 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-495437bb891so5211405e9.1 for ; Fri, 11 Sep 2026 08:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789141143; x=1789745943; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XNXMcyspmux818VLtqPgFj0iz0r6K4vaSIAs+CfWaBw=; b=a2cNqwaSxs+jbXny3ZLj+mwCtMHg2ZWVO+2RrRq8S2n+HImZObM8rVI8MLIRMaMOKu C+nqmQRicUB/ePVnGUKjPngxQ253Zk7TX0ZaGPTNjyV4w1aoFJWjBx9bzh+mnmB8qCSC JDco3mfsCyVKru9XgOzH0SQ49XwLpRuvE6fE3uYuo0yss5mSiMQ9LLXp59TYIruAqMxy zDNbfzpS5RU9IQB8tMT+JIZF+0a7K0C1PN8CjBhfqYUBhAq8+wryqEQ0qQ7qBbYIlcSU QeNzwzlhjmtuCR+G2aLN5+EN575cwzM/ojqjnweS59eTCZFrJVrginRuu0ja5WyHze/n nTVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789141143; x=1789745943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XNXMcyspmux818VLtqPgFj0iz0r6K4vaSIAs+CfWaBw=; b=CqauTlO+3ayj6BTjSaleyC7InqindTzrHaK0NJwsPv/UHvyi77ff6iQxwcGL8EvFQN GpG09Ckpf5bF+I5gD3cedDQ4PP6FTHbrApb8xPWd1v0wnti6zfBEfo/+IpzenBAgO5f7 Apeg62aRbjqwM1UB5+g7Nl4jpVQAcxfwLI3SZ9/1iZKXA7iCL5HBsPuYa7cLw7mQjeTK 3h7dPKYgIS6vfqd6NRsDlInxS2m3yBrWznk3Ux37/BEcQ5y4jPNkeyhC0PdrMnnxak1c hrXadPRkVtUCNWY8XqZ0A+vJkuYcBHcrVEQVHYV+pUOT+0MRpX/sA6Qnpn7X10lsOxgM Ca1Q== X-Gm-Message-State: AFuF++kG2uqY4abplJWbg3asCbiijzxAc0h8jNIlX+DXYhomGWKlGktr xdxqkZ5N3N9SmeVWxI3IAmxx0hqCsUtzCSGRAUWWQ8su1h4Zm4wahjwCqH6kLHI= X-Gm-Gg: AYBFou1CNMbKO7ZVE+D7nKkMAyedd7S3xvCwtbFbd0MW3dXy7aYpjW/ICE9s4c/hgxl lTAwiUmWS+aHBj2KeyR16sP8bx7BWhZJsMt5enDFKEr52z2uIm5+40B18Q8dQM05kE0Yko4SAwl yLBuWWtPMCiA0Jbb8rt928WuWf55qWwG3MIJyy0ZGsfPcOna+33iGEpuzTi1O1e3LO6CJ5e06TX Jy+HLB8fNCGFOOxWjsRvIZST75S3IK6GZgvFKeUe0w3iOXJxAtTnhe9TWLSF0wrHGppQh6oIbbA HlbXysHnnPBkAs9BDQkVz+fCdtuqhNnhLSONw40TjvqhL3D4DtNmauQpH324UqMIc3+eOJkX6lp tRYDHpX/CBCDeeS1kE8OCz8+JrBjTc4LMntBJDdFejnQaSTStIQvOxoYquJ7m3CfqqvKJf6ujgr 1MEIcw8nYO0LUhdAoJtJNOaXzW5w4ioEi+pBf1BZXSjmR3eN7Iq7C9z/DoAL9kmyeAnMh3kvMaB aFMNmmAyetwZ5G+T9+fHwJwOddtbcDzysnqwBbEV4TViSrIQ3HaYjcrtSgX+VWFmbnZXQ== X-Received: by 2002:a05:600d:4445:10b0:49d:28fc:d6a0 with SMTP id 5b1f17b1804b1-49d28fcd72fmr93444385e9.18.1789141143363; Fri, 11 Sep 2026 08:39:03 -0700 (PDT) Received: from latitude7275 (84.124.213.91.dyn.user.ono.com. [84.124.213.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-486eb33ee5csm6851570f8f.20.2026.09.11.08.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 08:39:02 -0700 (PDT) From: "D. Manresa" To: libcamera-devel@lists.libcamera.org Cc: Laurent Pinchart , Daniel Scally Subject: [PATCH v4 1/2] ipa: libipa: camera_sensor_helper: Add OV5670 black level Date: Fri, 11 Sep 2026 17:39:17 +0200 Message-ID: <20260911153918.96470-2-dmanresa@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260911153918.96470-1-dmanresa@gmail.com> References: <20260910172120.73148-1-dmanresa@gmail.com> <20260911153918.96470-1-dmanresa@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The OV5670 outputs a data pedestal of 64 at 10 bits. The black level characterisation in the OEM tuning data for a Dell Latitude 7275 camera module measures 64.1 to 64.4 at unity gain over six exposure times, and stays within 62.0 to 64.5 up to a gain of 15.9. Provide it in the camera sensor helper so that IPAs can use it instead of hard-coded or tuning-file values. Signed-off-by: D. Manresa --- src/ipa/libipa/camera_sensor_helper.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 82bf255..eeb3277 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -802,6 +802,8 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper public: CameraSensorHelperOv5670() { + /* Default BLC target of 64 at 10bits, confirmed by measurement. */ + blackLevel_ = 4096; gain_ = AnalogueGainLinear{ 1, 0, 0, 128 }; } };