From patchwork Thu Sep 10 16:03:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28221 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 72D1ABDCBE for ; Thu, 10 Sep 2026 16:03:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9979E68660; Thu, 10 Sep 2026 18:03:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="g+CACuj1"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 32B0C68655 for ; Thu, 10 Sep 2026 18:03:14 +0200 (CEST) Received: from pb-laptop.local (185.221.140.18.nat.pool.zt.hu [185.221.140.18]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B0626DF for ; Thu, 10 Sep 2026 18:01:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1789056097; bh=sCJuvZsnGkqJWuexS03ZhwlGY38zHdNufcKs/Hcl9ic=; h=From:To:Subject:Date:In-Reply-To:References:From; b=g+CACuj125Jwzm8cqDsIgxYedG9T2UaYwOHUgn1dCygr8sbqP6Y+XzKq5DAh4wjDI lWF2g3GPNb8g/OS+aEuZwKaQ38cAZlFUE0gVbqrk7fy+s+bOOalpH80lqeyYpGtT8N u/Y92bHDSxRDV6Ikf6rxbzv7BlSSWyx2Odp0JgDc= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 2/5] libcamera: v4l2_{video, sub}device: {get, set, try}Format(): Log format Date: Thu, 10 Sep 2026 18:03:06 +0200 Message-ID: <20260910160309.940584-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260910160309.940584-1-barnabas.pocze@ideasonboard.com> References: <20260910160309.940584-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" These functions have not been logging the v4l2 formats that they receive and the ones that the device actually returns. This makes debugging much more difficult. And multiple pipeline handlers work around this by adding logging around `setFormat()` calls, but those can be missed, and they don't necessarily include the path of the device node. So add these log messages into the `{get,set,try}Format()` methods themselves. Example: DEBUG V4L2 v4l2_videodevice.cpp:859 /dev/video0[13:cap]: trying format: 640x480-YUYV[]/Unset DEBUG V4L2 v4l2_videodevice.cpp:882 /dev/video0[13:cap]: returned format: 640x480-YUYV[614400/1280]/Rec709/Rec709/Rec601/Limited DEBUG V4L2 v4l2_subdevice.cpp:1424 'imx708': setting format on 0/0: 4608x2592-SRGGB10_1X10/Unset DEBUG V4L2 v4l2_subdevice.cpp:1439 'imx708': returned format on 0/0: 4608x2592-SRGGB10_1X10/RAW Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- changes in v2: * same changes in `V4L2Subdevice` --- src/libcamera/v4l2_subdevice.cpp | 6 ++++ src/libcamera/v4l2_videodevice.cpp | 48 +++++++++++++++++++++++++----- 2 files changed, 46 insertions(+), 8 deletions(-) -- 2.55.0 diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp index a69de154e8..511cc12e2f 100644 --- a/src/libcamera/v4l2_subdevice.cpp +++ b/src/libcamera/v4l2_subdevice.cpp @@ -1374,6 +1374,8 @@ int V4L2Subdevice::getFormat(const Stream &stream, V4L2SubdeviceFormat *format, format->code = subdevFmt.format.code; format->colorSpace = toColorSpace(subdevFmt.format); + LOG(V4L2, Debug) << "returned format on " << stream << ": " << *format; + return 0; } @@ -1419,6 +1421,8 @@ int V4L2Subdevice::setFormat(const Stream &stream, V4L2SubdeviceFormat *format, subdevFmt.format.flags |= V4L2_MBUS_FRAMEFMT_SET_CSC; } + LOG(V4L2, Debug) << "setting format on " << stream << ": " << *format; + int ret = ioctl(VIDIOC_SUBDEV_S_FMT, &subdevFmt); if (ret) { LOG(V4L2, Error) @@ -1432,6 +1436,8 @@ int V4L2Subdevice::setFormat(const Stream &stream, V4L2SubdeviceFormat *format, format->code = subdevFmt.format.code; format->colorSpace = toColorSpace(subdevFmt.format); + LOG(V4L2, Debug) << "returned format on " << stream << ": " << *format; + return 0; } diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index bc539884e5..ea6270fdf2 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -814,19 +814,32 @@ std::string V4L2VideoDevice::logPrefix() const */ int V4L2VideoDevice::getFormat(V4L2DeviceFormat *format) { + int ret; + switch (bufferType_) { case V4L2_BUF_TYPE_VIDEO_CAPTURE: case V4L2_BUF_TYPE_VIDEO_OUTPUT: - return getFormatSingleplane(format); + ret = getFormatSingleplane(format); + break; case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE: case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: - return getFormatMultiplane(format); + ret = getFormatMultiplane(format); + break; case V4L2_BUF_TYPE_META_CAPTURE: case V4L2_BUF_TYPE_META_OUTPUT: - return getFormatMeta(format); + ret = getFormatMeta(format); + break; default: - return -EINVAL; + ret = -EINVAL; + break; } + + if (ret) + return ret; + + LOG(V4L2, Debug) << "returned format: " << *format; + + return 0; } /** @@ -841,19 +854,34 @@ int V4L2VideoDevice::getFormat(V4L2DeviceFormat *format) */ int V4L2VideoDevice::tryFormat(V4L2DeviceFormat *format) { + int ret; + + LOG(V4L2, Debug) << "trying format: " << *format; + switch (bufferType_) { case V4L2_BUF_TYPE_VIDEO_CAPTURE: case V4L2_BUF_TYPE_VIDEO_OUTPUT: - return trySetFormatSingleplane(format, false); + ret = trySetFormatSingleplane(format, false); + break; case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE: case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: - return trySetFormatMultiplane(format, false); + ret = trySetFormatMultiplane(format, false); + break; case V4L2_BUF_TYPE_META_CAPTURE: case V4L2_BUF_TYPE_META_OUTPUT: - return trySetFormatMeta(format, false); + ret = trySetFormatMeta(format, false); + break; default: - return -EINVAL; + ret = -EINVAL; + break; } + + if (ret) + return ret; + + LOG(V4L2, Debug) << "returned format: " << *format; + + return 0; } /** @@ -869,6 +897,8 @@ int V4L2VideoDevice::setFormat(V4L2DeviceFormat *format) { int ret; + LOG(V4L2, Debug) << "setting format: " << *format; + switch (bufferType_) { case V4L2_BUF_TYPE_VIDEO_CAPTURE: case V4L2_BUF_TYPE_VIDEO_OUTPUT: @@ -894,6 +924,8 @@ int V4L2VideoDevice::setFormat(V4L2DeviceFormat *format) format_ = *format; formatInfo_ = &PixelFormatInfo::info(format_.fourcc); + LOG(V4L2, Debug) << "returned format: " << *format; + return 0; }