From patchwork Tue Sep 8 16:37:07 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "D. Manresa" X-Patchwork-Id: 28209 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 84957BD160 for ; Tue, 8 Sep 2026 16:37:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 344FF68637; Tue, 8 Sep 2026 18:37:07 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DRuzmv+3"; dkim-atps=neutral Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6CB3D68625 for ; Tue, 8 Sep 2026 18:37:03 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-485843aeab8so5396880f8f.1 for ; Tue, 08 Sep 2026 09:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788885423; x=1789490223; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=se6BENrywLu0mAUaUSqbrUeQSArODb2U+yBezrMFg+M=; b=DRuzmv+3XSlEQw+mKytijLsw8quHYfnciIqq1wwr8b2I3g7TUkxJIgFE9caIDqJjMu mlDRodEh1g5s3ZkUVh6deiUmmwrUP+6V0BUYC7qVT2KrOjN9uXA0tIq6LGYbNge1E5Mm LSetkfOX9C2RQ7B7RQE6kRg0Y1a2IuwRCb3MGw1GENM7tpWnT1k1VoO4fzyee0srZ0fi u1XjB5B0s0ynNBpQfKgPMsr/T//NMN1R+fU9F2tCeH5uwT8UU6zq/r6J41xrc0Eiwj5/ k2o5fljh6o8B71+A/fbv7EqBqeV9KRyMi5WkphnuW2y1WMozwkow4QuRox6oXMdZzx+1 L56A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788885423; x=1789490223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=se6BENrywLu0mAUaUSqbrUeQSArODb2U+yBezrMFg+M=; b=TK5qiJVDkI1yLOWxTX4Jf9IBixrapvUi+kzl4hPytlj9bwmoRuH2lHase3PtDXSW+A Fr+5U+V/SbzGAgoxsLg6Mr6AI/oKqjeCu0n6H6CkqmI3x36Belc2H49EHLF0Onk0TeU3 Vf8mED+6EhgibL4/+f4InD/tp6z6Mok6d/JkWO08k2HauZlRR8Fva5kFil6n6Y4fpeqD 4KOBn/MlOS5LhiDHSL5Qid6HZ1cav6GpfgFOOXhkxtvlM0z9lguLRiuRNG5+cS1Ioh0r WvwhsYsJJCJo4uvDn7wps1aeNel9qtZyhG06RTapXz6g/RO7FteG0rB1qaOICuivgHZ8 moIg== X-Gm-Message-State: AFuF++nM3S9kuuyuuSAiOI/CzXHhgigABwx6jRkB1H64RbP9ja2wSINC q2AyifYUYr5oXa6y98tb+4bTOIdysDDM1qB6pk8fLM5OsIDqCs2zyChndo2+gFBGcA== X-Gm-Gg: AYBFou1qm627IsMd7IkqeO4oT9TlUPmiezWR2edVbr9rzig7f+C7lYNReFPIAmfCfO8 208tpKadD+OwrSACaqCSBlI7TT2fPEQx4uLnfmnISGX+e+lnokB3bnqQHUvheMhNNdjJt/jKg4V 4tXrCU4y6kcDVLbjlkvokv+F2ma63xaqGN42kpTAdScmP/RTBx8K/SQ4uHJZKmbRHsJiKX9/ceV 8L8fIje8S+FppqzvXLq5PdaMppn2sx7UsAhFkpWUOgRg+K9YCxeDzqqy/gTMv1edpgAHteVkQWP SwiNeocrTpvIv4O7UsuJK1XCUXDTW3dZBE13wUsPEy9NJxtCjouLCpHVSxvf+B2bFRymqDIHvhU K3lNEeC0R32BSJu7nklzU06vu/NcMMFZ3vcChRy2DAm3RTYN0VNhw/aiqLq15JLdqlpxbTAYmdl T4r47sg00w2YPBNKVDEqJXCXHGiDwDm5xZdCCriRwZUf292uTkvLlqYCVhj+DsKpB3NFECFWTj0 OfZE0A5o2+9n+MsogcfVgf97B2Afjtc8qVIvX2TZI70e+ya X-Received: by 2002:a05:6000:70b:b0:485:8be1:378d with SMTP id ffacd0b85a97d-4858be14b94mr59649659f8f.12.1788885422354; Tue, 08 Sep 2026 09:37:02 -0700 (PDT) Received: from latitude7275 (84.124.213.91.dyn.user.ono.com. [84.124.213.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48588394fa1sm35268362f8f.8.2026.09.08.09.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 09:37:01 -0700 (PDT) From: "D. Manresa" To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally Subject: [PATCH v2 1/2] ipa: libipa: camera_sensor_helper: Add OV5670 black level Date: Tue, 8 Sep 2026 18:37:07 +0200 Message-ID: <20260908163708.341308-2-dmanresa@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260908163708.341308-1-dmanresa@gmail.com> References: <20260904062840.46739-3-dmanresa@gmail.com> <20260908163708.341308-1-dmanresa@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The OV5670 has a black level of 64 at 10 bits, the sensor's default BLC target. This was confirmed on a Dell Latitude 7275 by reading the ImgU statistics and dark frames with different black level corrections. Provide it in the camera sensor helper so that IPAs can use it instead of hard-coded or tuning-file values. Signed-off-by: D. Manresa --- src/ipa/libipa/camera_sensor_helper.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 82bf255..eeb3277 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -802,6 +802,8 @@ class CameraSensorHelperOv5670 : public CameraSensorHelper public: CameraSensorHelperOv5670() { + /* Default BLC target of 64 at 10bits, confirmed by measurement. */ + blackLevel_ = 4096; gain_ = AnalogueGainLinear{ 1, 0, 0, 128 }; } };