From patchwork Tue Sep 8 07:36:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 28197 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 100AAC3257 for ; Tue, 8 Sep 2026 07:36:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 93EE568620; Tue, 8 Sep 2026 09:36:46 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="DgF9P1Xu"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A368685D7 for ; Tue, 8 Sep 2026 09:36:44 +0200 (CEST) Received: from pb-laptop.local (185.221.140.18.nat.pool.zt.hu [185.221.140.18]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 82848C13 for ; Tue, 8 Sep 2026 09:35:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1788852908; bh=XitR50jVsz+tEh4uSFjdob3gm0RBbKKqjTlYZ/gQzdk=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DgF9P1Xuzi32TXDBLETnd83z+Cjlug3C5kc38cR55iQ6Hnaf6qSmPLLeoZIcqGB8S 6nnvnQahMKuygI0dlD1Z7vkHrB0epvi5y90b01rNWBjai9h3F+0Qhk4X5pymgyG7ab +Oh+OyQqKV193yDlHx+jDAh24JsNdikIAk+ti0zA= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 2/3] libcamera: v4l2_videodevice: {get, set, try}Format(): Log format Date: Tue, 8 Sep 2026 09:36:39 +0200 Message-ID: <20260908073640.39654-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260908073640.39654-1-barnabas.pocze@ideasonboard.com> References: <20260908073640.39654-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" These functions have not been logging the v4l2 formats that they receive and the ones that the device actually returns. This makes debugging much more difficult. And multiple pipeline handlers work around this by adding logging around `setFormat()` calls, but those can be missed, and they don't necessarily include the path of the device node. So add these log messages into the `{get,set,try}Format()` methods themselves. Example: DEBUG V4L2 v4l2_videodevice.cpp:859 /dev/video0[13:cap]: trying format: 640x480-YUYV[]/Unset DEBUG V4L2 v4l2_videodevice.cpp:882 /dev/video0[13:cap]: returned format: 640x480-YUYV[614400/1280]/Rec709/Rec709/Rec601/Limited Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham --- src/libcamera/v4l2_videodevice.cpp | 48 +++++++++++++++++++++++++----- 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp index bc539884e5..ea6270fdf2 100644 --- a/src/libcamera/v4l2_videodevice.cpp +++ b/src/libcamera/v4l2_videodevice.cpp @@ -814,19 +814,32 @@ std::string V4L2VideoDevice::logPrefix() const */ int V4L2VideoDevice::getFormat(V4L2DeviceFormat *format) { + int ret; + switch (bufferType_) { case V4L2_BUF_TYPE_VIDEO_CAPTURE: case V4L2_BUF_TYPE_VIDEO_OUTPUT: - return getFormatSingleplane(format); + ret = getFormatSingleplane(format); + break; case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE: case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: - return getFormatMultiplane(format); + ret = getFormatMultiplane(format); + break; case V4L2_BUF_TYPE_META_CAPTURE: case V4L2_BUF_TYPE_META_OUTPUT: - return getFormatMeta(format); + ret = getFormatMeta(format); + break; default: - return -EINVAL; + ret = -EINVAL; + break; } + + if (ret) + return ret; + + LOG(V4L2, Debug) << "returned format: " << *format; + + return 0; } /** @@ -841,19 +854,34 @@ int V4L2VideoDevice::getFormat(V4L2DeviceFormat *format) */ int V4L2VideoDevice::tryFormat(V4L2DeviceFormat *format) { + int ret; + + LOG(V4L2, Debug) << "trying format: " << *format; + switch (bufferType_) { case V4L2_BUF_TYPE_VIDEO_CAPTURE: case V4L2_BUF_TYPE_VIDEO_OUTPUT: - return trySetFormatSingleplane(format, false); + ret = trySetFormatSingleplane(format, false); + break; case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE: case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE: - return trySetFormatMultiplane(format, false); + ret = trySetFormatMultiplane(format, false); + break; case V4L2_BUF_TYPE_META_CAPTURE: case V4L2_BUF_TYPE_META_OUTPUT: - return trySetFormatMeta(format, false); + ret = trySetFormatMeta(format, false); + break; default: - return -EINVAL; + ret = -EINVAL; + break; } + + if (ret) + return ret; + + LOG(V4L2, Debug) << "returned format: " << *format; + + return 0; } /** @@ -869,6 +897,8 @@ int V4L2VideoDevice::setFormat(V4L2DeviceFormat *format) { int ret; + LOG(V4L2, Debug) << "setting format: " << *format; + switch (bufferType_) { case V4L2_BUF_TYPE_VIDEO_CAPTURE: case V4L2_BUF_TYPE_VIDEO_OUTPUT: @@ -894,6 +924,8 @@ int V4L2VideoDevice::setFormat(V4L2DeviceFormat *format) format_ = *format; formatInfo_ = &PixelFormatInfo::info(format_.fourcc); + LOG(V4L2, Debug) << "returned format: " << *format; + return 0; }