From patchwork Thu Sep 3 14:51:52 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 28187 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 05DD8C334A for ; Thu, 3 Sep 2026 14:53:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 45910685FB; Thu, 3 Sep 2026 16:53:20 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="sRpy9MFC"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 83FAF685E2 for ; Thu, 3 Sep 2026 16:53:15 +0200 (CEST) Received: from ping.linuxembedded.co.uk (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 91E3F26D7; Thu, 3 Sep 2026 16:51:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1788447103; bh=PQ6pYrB09k7kA1NfUAqHSmojQyp/LzHn9WtIKSbMexE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sRpy9MFCBCKKjV1ENocwrru802fCGgkc4EP+qq6wR6Nmv5Y97OzaY8Snl4oPRGmX5 sOM0ylPiNcfcZISNUzhYwobah0MJjAh/eM8aDtXyFw1qfWgX6f9+GvkG29UpuMaCs9 ZO0QFY8IucoAWW31SqcXKHXio21yM7iTsTS0ps6s= From: Kieran Bingham Date: Thu, 03 Sep 2026 15:51:52 +0100 Subject: [PATCH 3/3] DNI: TESTONLY: libcamera: camera: Add an ABI break in SensorConfig MIME-Version: 1.0 Message-Id: <20260903-kbingham-abi-trailers-v1-3-72ae051c912a@ideasonboard.com> References: <20260903-kbingham-abi-trailers-v1-0-72ae051c912a@ideasonboard.com> In-Reply-To: <20260903-kbingham-abi-trailers-v1-0-72ae051c912a@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1788447194; l=989; i=kieran.bingham@ideasonboard.com; s=20260207; h=from:subject:message-id; bh=PQ6pYrB09k7kA1NfUAqHSmojQyp/LzHn9WtIKSbMexE=; b=mIY50mNzNCUgJSalZorMwGpW+cV+ogT/3n+PcU0PrYYw4T5Ae61c/MFiGNQX/sFUL+cQLf8hD EbWyCm6e3DpCBkhktuFfg8bkHMGzBedFqonTk1swbZdj5JC3XbNiXRp X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Adding a variable here changes the size of the structure and the offsets of the variables. It should be caught by the ABI tooling. ABI: struct CameraConfiguration: Size of field sensorConfig has been changed from 56 bytes to 60 bytes ABI: struct SensorConfiguration: Field BigBreakingABIChange has been added at the middle position of this structural type. API: struct SensorConfiguration: Field BigBreakingABIChange has been added to this type. Signed-off-by: Kieran Bingham --- include/libcamera/camera.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/libcamera/camera.h b/include/libcamera/camera.h index 443116b58845..66381c823749 100644 --- a/include/libcamera/camera.h +++ b/include/libcamera/camera.h @@ -38,6 +38,8 @@ class SensorConfiguration public: unsigned int bitDepth = 0; + unsigned int BigBreakingABIChange = 1; + Rectangle analogCrop; struct {