From patchwork Wed Sep 2 09:07:21 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 28165 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7427DC3347 for ; Wed, 2 Sep 2026 09:07:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D9035685BD; Wed, 2 Sep 2026 11:07:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BFOW3lB/"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EF6E56859E for ; Wed, 2 Sep 2026 11:07:34 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DE096265C; Wed, 2 Sep 2026 11:06:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1788339964; bh=rOyAJHvtnDZWZjtLSuGZg5l3Slr3kiSC6h37DqDnzhw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=BFOW3lB/iiUrofLc03Lo57Y5UBru5ExRmlHzLs/BoZssoi7EJaQ9sDA0oXgChze/l GiwgvP0DV5UzQmRX1Dq3G7vc2MeDQF8MgTMQHF6bmRc4gkF3uQb4q04N+7hPa8rkS6 XY6Vr1CuwCVSDeeMCf621lEpuV2oOaARxcWxiUSc= From: Daniel Scally Date: Wed, 02 Sep 2026 10:07:21 +0100 Subject: [PATCH v3 03/10] ipu3: awb: Remove CCM settings from Awb algorithm MIME-Version: 1.0 Message-Id: <20260902-ipu3-libipa-rework-v3-3-b7da9b062326@ideasonboard.com> References: <20260902-ipu3-libipa-rework-v3-0-b7da9b062326@ideasonboard.com> In-Reply-To: <20260902-ipu3-libipa-rework-v3-0-b7da9b062326@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally , Jacopo Mondi , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1710; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=rOyAJHvtnDZWZjtLSuGZg5l3Slr3kiSC6h37DqDnzhw=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBql+dThLjk9We5gV9HUVTQ+YxqP/hvud30sA39V PQt595ch7qJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCapfnUwAKCRDISVd6bEV1 Mm91EACuCdkySUOUwuNaQ7sxdywkWrlEIrXtJ+KZ0yU5jK2IkEs4kDOMoxBDlZRbRPxvfp9qToz oJgVTEaN6hQLLOJAKq4rB6bmufVfq05P5zJkBBMQAL1gmtvWJy1U0TwGHekvLBMbfDqtJ0s7ItG Lu/NbL0I0Qsy4aIuefFCUMhmQg/iaEgzxxctKcxvNqrEIPmNPiRDaP8HzRhIbpmxpbHIFIOLdCP uIhMittYTtNUL93vApNhTPCsxOhPM2I5/hkrSXhUQY8yQIaWRGGhe3c1ciZkEujw23yPiPilvcM yJTk8F0Vb0W3wgYgzJKFYfZE5bHWhgYD+NzHqryNZBLKbI6WWYmbdcQgTIFi/ANNYkceARSWhk8 MYr4FHISXLFFWLjeBYAoK76LqVJ7uyfHDNGI01SSKrkJ/RTFzydOZTLCT/T5MUZDISPwLhXrgp6 3mZF3vv0kht4cWAPyPRy5bfu092w9/WLsOGbrrEZEU0J8Xlorz8MyQCovOtQapnklqncMORFFOa gnRWT+twTigVNIWzeX0kY4DV6xYI12kxitymOewA1Bayzy1oa4FI8xwQEWiQvzMmHMQ/XBILzm5 edOYmvpf105MmYhSdIZeocLHRIUcvVgBMicrdYtYhYDtv2y33zIT6gng1wgwbAlAhltICG7/Poa iJ/xy3ZaJZsjrKQ== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPU3 AWB algorithm currently defines a CCM matrix that is just a no-op. Remove the settings entirely; they need really to go in to a dedicated CCM algorithm. Reviewed-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze Signed-off-by: Daniel Scally --- Changes in v3: - None Changes in v2: - None --- src/ipa/ipu3/algorithms/awb.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 6b4418aa6f3add0a41cae77000c1f5f67897111a..613bdbbf51cd127e03906571813260a6857067dc 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -112,13 +112,6 @@ static const struct ipu3_uapi_bnr_static_config imguCssBnrDefaults = { .opt_center_sqr = { 419904, 133956 }, }; -/* Default color correction matrix defined as an identity matrix */ -static const struct ipu3_uapi_ccm_mat_config imguCssCcmDefault = { - 8191, 0, 0, 0, - 0, 8191, 0, 0, - 0, 0, 8191, 0 -}; - /** * \class Awb * \brief A Grey world white balance correction algorithm @@ -293,12 +286,9 @@ void Awb::prepare(IPAContext &context, LOG(IPU3Awb, Debug) << "Color temperature estimated: " << asyncResults_.temperatureK; - /* The CCM matrix may change when color temperature will be used */ - params->acc_param.ccm = imguCssCcmDefault; params->use.acc_awb = 1; params->use.acc_bnr = 1; - params->use.acc_ccm = 1; } /* Generate an RGB vector with the average values for each zone */