From patchwork Wed Sep 2 09:07:20 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dan Scally X-Patchwork-Id: 28164 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 253D7C3344 for ; Wed, 2 Sep 2026 09:07:45 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2AD87685B0; Wed, 2 Sep 2026 11:07:39 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="G0KHJxi9"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D006E6859D for ; Wed, 2 Sep 2026 11:07:34 +0200 (CEST) Received: from [127.0.1.1] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 922EC25CC; Wed, 2 Sep 2026 11:06:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1788339963; bh=B/mNeOq/BMWFwDja0ce5qaPrrb6CvFMkRZxq/y1M0V4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=G0KHJxi9LFty5VvvFnfO1Gns6PJg4MErWAhmX2mgk7kn/YLZkNZs0yCtSidKhnZsf KqA+g6AJ4xkGmOFV7p+XdQTFVIDraBZuviYXfU90nOn8WJeyukcSgYVdDTPM2WTbTk ZPn2YKaVD+MfWZETCsB9BBUYxOpuZvI2qZPPkFzU= From: Daniel Scally Date: Wed, 02 Sep 2026 10:07:20 +0100 Subject: [PATCH v3 02/10] ipa: ipu3: Remove ~Awb() from source and header MIME-Version: 1.0 Message-Id: <20260902-ipu3-libipa-rework-v3-2-b7da9b062326@ideasonboard.com> References: <20260902-ipu3-libipa-rework-v3-0-b7da9b062326@ideasonboard.com> In-Reply-To: <20260902-ipu3-libipa-rework-v3-0-b7da9b062326@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Daniel Scally , =?utf-8?q?Barnab=C3=A1s_?= =?utf-8?b?UMWRY3pl?= , Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1432; i=dan.scally@ideasonboard.com; h=from:subject:message-id; bh=B/mNeOq/BMWFwDja0ce5qaPrrb6CvFMkRZxq/y1M0V4=; b=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBql+dTFLSg33T4g5gPrlCpouowxuDKlWsCNo0+W 7ejT/WgasyJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCapfnUwAKCRDISVd6bEV1 Mq3qD/4kLFXQYDP02cLrpBOszAkis09HU1rWGyXSoFaspanA7wgV1cYoMsSly2Y5LIZKZnZZNKp nQwdAbPMkTFLoDeOmC/yom64vGT14pEbkWaEJtaCFtymrDEQIViDuJxyx3V67ZXU7orijLiPd9u j9dI63POQvBfY1o1N5oldwL01ZukKDdsc7Sb5TxI+ljhI/aKYLZVYsWQwlh0BBYx5TCDhywsgJP /EakG5eWcoFjZZSzu4udBxYOwGLsUUaTWxWPOlaLUUbFsdXWuUaLhETqw3Zmeaoq/0R3BrCHnm9 wDG95zAFZo/caS37i/CXLN5AQHMpkCTN7+E0UvuB6je0LRn6v4nyvTdBPk3mrCKXoEd7+06zFZJ zdED/AoYCNFsyuH7LV71kB2UZJQ6wGiPsQ8DuTjGV3hQbhK263v6ircrG+dmi6Nja89iElqawT0 31E8h/iAIERQcJxONu8QqO2/OccSiDY2yWN5FhdshLl9lwUgI9fkr7JWnDqjX+sC4X55af1eZTj Oe+TgGTRoQ1r5sn+aGh6qmBhCWAocVL2SFQ/pzubvx9z3B9cIj8rBsUFh37OnpmlcNhJsA6h5vE 03N8Zq1Txem0qI9dku9LnGfgui1FpJ4BnRaOcxdERJgjELGjx1p2PX0LWqa3Fjqvf9t9284JJ1i T596uTrPggs8WZA== X-Developer-Key: i=dan.scally@ideasonboard.com; a=openpgp; fpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Remove the ~Awb() definition from the source and header files and simply allow the compiler to provide the default implementations. Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Signed-off-by: Daniel Scally --- Changes in v3: - None Changes in v2: - None --- src/ipa/ipu3/algorithms/awb.cpp | 2 -- src/ipa/ipu3/algorithms/awb.h | 1 - 2 files changed, 3 deletions(-) diff --git a/src/ipa/ipu3/algorithms/awb.cpp b/src/ipa/ipu3/algorithms/awb.cpp index 55de05d9e39f5d2c863b89923964a4c7756f3846..6b4418aa6f3add0a41cae77000c1f5f67897111a 100644 --- a/src/ipa/ipu3/algorithms/awb.cpp +++ b/src/ipa/ipu3/algorithms/awb.cpp @@ -195,8 +195,6 @@ Awb::Awb() zones_.reserve(kAwbStatsSizeX * kAwbStatsSizeY); } -Awb::~Awb() = default; - /** * \copydoc libcamera::ipa::Algorithm::configure */ diff --git a/src/ipa/ipu3/algorithms/awb.h b/src/ipa/ipu3/algorithms/awb.h index dbf69c9073a1627b666fe63158081e347cf3581e..7ec322318dab54ae7c8a647a67a0cf5815a36eb6 100644 --- a/src/ipa/ipu3/algorithms/awb.h +++ b/src/ipa/ipu3/algorithms/awb.h @@ -38,7 +38,6 @@ class Awb : public Algorithm { public: Awb(); - ~Awb(); int configure(IPAContext &context, const IPAConfigInfo &configInfo) override; void prepare(IPAContext &context, const uint32_t frame,