From patchwork Fri Aug 21 13:01:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27989 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 64A3EC3346 for ; Fri, 21 Aug 2026 13:03:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 859DC68371; Fri, 21 Aug 2026 15:03:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hswaPk06"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 62448683AC for ; Fri, 21 Aug 2026 15:02:29 +0200 (CEST) Received: from pb-laptop.local (185.221.143.32.nat.pool.zt.hu [185.221.143.32]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 159DE157F; Fri, 21 Aug 2026 15:01:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1787317267; bh=Z/rDWPvRDO/YI85rSBLaU81YMD5XD2J1TyXW2/MNUTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hswaPk06E1ky4hBicRHTRor8FH/99POKxkjh0JJWrxgvNmt+KXkeGdN02DS3dJaFC EWs63COjPfMfVKKSpFEAJP3EEY6fb8apIYdbpI+z6oywVwiUw1yN2NGhTOkATFkEEx ZnNRRTY6xscw1p0mY4jK3uiOn3S0h3iYKejTuHXc= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi Subject: [PATCH v7 26/47] ipa: libipa: agc: Adjust debug messages slightly Date: Fri, 21 Aug 2026 15:01:56 +0200 Message-ID: <20260821130218.2706196-27-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260821130218.2706196-1-barnabas.pocze@ideasonboard.com> References: <20260821130218.2706196-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The log message showing the result of AGC seems too verbose to me, and the labels and values are far from each other. And also log the line duration when showing exposure and gain limits. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi --- src/ipa/libipa/agc.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp index 3f54dc99f2..e593eac64a 100644 --- a/src/ipa/libipa/agc.cpp +++ b/src/ipa/libipa/agc.cpp @@ -321,8 +321,10 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, float defGain = config.sensor->gain(v4l2Gain.def().get()); LOG(Agc, Debug) - << "Exposure: [" << minExposure << ", " << maxExposure - << "], gain: [" << minGain << ", " << maxGain << "]"; + << "exposure: [" << minExposure << ',' << maxExposure << "], " + << "gain: [" << minGain << ',' << maxGain << "], " + << "line-duration: " << session.lineDuration << ", " + << "sensor-output: " << session.sensor.outputSize; /* * Compute the frame duration limits. @@ -670,10 +672,10 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state, state.automatic.yTarget = newEv.yTarget; LOG(Agc, Debug) - << "Divided up exposure time, analogue gain, quantization gain" - << " and digital gain are " << newEv.exposureTime - << ", " << state.automatic.gain << ", " << state.automatic.quantizationGain - << " and " << newEv.digitalGain; + << "exposure-time: " << newEv.exposureTime << ", " + << "analogue-gain: " << state.automatic.gain << ", " + << "quantization-gain: " << state.automatic.quantizationGain << ", " + << "digital-gain: " << newEv.digitalGain; /* * Expand the target frame duration so that we do not run faster than