From patchwork Fri Aug 21 09:47:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexi Birlinger X-Patchwork-Id: 27955 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6E8B4C3308 for ; Fri, 21 Aug 2026 09:58:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5BE2568360; Fri, 21 Aug 2026 11:58:50 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="J4dy4n0s"; dkim-atps=neutral Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazlp170130006.outbound.protection.outlook.com [IPv6:2a01:111:f403:c201::6]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 896B66807E for ; Fri, 21 Aug 2026 11:58:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gl9l9TQSJWv88/m7g6quu0MgArnNh/1C4mW6g9RsEpfrQW0C+LrvraOF5Pw/n99zvde6DZ66ObBcozHiKrs7LFXbCrXtaCsUZFj/VG+aXwhCvoUfCa1ZosYdVRTuz1Kklq4fVIUmARinK0s9uSb1wnGTccpqCenc8ZY4r6Qc37Mpka+mcpbNh1rSFnxMoVD0CgXgVffGqlnA2+HOvDMZbajOpN9YXKsYdsaYqeNWUvJnTBH9Mldq0FUK7ujhLVUzFI1Aj2w+RUvVXOQgAjp8nfXOMoWQOkWP9FqEKVonP9a2k5nXKeU4kNtpDju9+9oYAXqDj+Pry8wkFGnP0fGKNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=He1auO1qC8w2TE0lJNLyO+YuF/oecdVnkYEf15xROjA=; b=nhUs+hcGFWpJmheFmyRoUE7bMwkx36gWRQacaoyY2P6oK9E8i9Hj86msIbhL+/tL2xRzT8eKutHtMSTehdKfSYO1pWlVzKein7P7KlXZ4392pBzuzKm+hanq7T+pVrn6NzA3yqTRdmYlsK50aPf8SlXqwwevjaGNG7iPNcKRty8RWu6f1M9BHw2Qjo2WQGiIRc7+9Txf4YHlgcZPR8nS7ozJuIJKVlxNO+9IQMRKIHVhmNYjXWXxM16vCJVpc1tDRihZAroEfxLbZv9a5ahfCK8+sZNKC7LoNgyLyKXkMp+JeDdp1XnDCXOrW13CaWl1+90ezt9/XvL3HD4K22aFKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=He1auO1qC8w2TE0lJNLyO+YuF/oecdVnkYEf15xROjA=; b=J4dy4n0s2Bm0Zq8r/0YtrjLGZeG1Jl9aJmr8YcMArfJ0CGhyoKTsc/0L50hsjKeYfgnz0zuLzz7dKh4loFkiE7ZQnMw1hdTe7prnxv9B5ffvLVp0CaRylDc0BMendOtIjD3e25hjZr2qg5plekP1DMQL7wVvX4JTls3Hie5Cdr4g40J4/DHzEYU9Xio4NCFEd70aXv2Q9I66BqXSWa5TvdimoSCE1V8fqn4+INo3Ipse2Bu6tSkl7Ko4hGmJy7Hd0bqEEU3y+M2vE6jB65t3v0T8sm1T33bELsBjzWdEpeEgQ3bU+P67qCGf3A4iotsyY8n24p3IT59R/9PpB8/7VQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from GV2PR04MB11980.eurprd04.prod.outlook.com (2603:10a6:150:2f3::16) by PAXPR04MB9519.eurprd04.prod.outlook.com (2603:10a6:102:22e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.339.10; Fri, 21 Aug 2026 09:58:46 +0000 Received: from GV2PR04MB11980.eurprd04.prod.outlook.com ([fe80::20be:665:a67:ec03]) by GV2PR04MB11980.eurprd04.prod.outlook.com ([fe80::20be:665:a67:ec03%3]) with mapi id 15.21.0339.008; Fri, 21 Aug 2026 09:58:46 +0000 From: Alexi Birlinger To: libcamera-devel@lists.libcamera.org Cc: julien.vuillaumier@nxp.com, Alexi Birlinger Subject: [PATCH v1] pipeline: simple: Revert "libcamera: simple: Enable SoftISP for imx7-csi" Date: Fri, 21 Aug 2026 11:47:47 +0200 Message-Id: <20260821094747.2252938-1-alexi.birlinger@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: FR4P281CA0430.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d1::20) To GV2PR04MB11980.eurprd04.prod.outlook.com (2603:10a6:150:2f3::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: GV2PR04MB11980:EE_|PAXPR04MB9519:EE_ X-MS-Office365-Filtering-Correlation-Id: 49277bda-51c6-4967-f333-08deff6aca8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|23010399003|19092799006|366016|376014|18002099003|3023799007|56012099006|10067099003|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: myQBGJnNfx1PYb2q39KI0W+DY7hIRvcXmvDEBD1gPWT2VrcbyQmSJjtT4LemtItWxeI4fUAC/5tb/Z/W1nXN1bwjcpLhh7tpMCFBWpH/IK5GuHNYQMCS7/inU1zpgVgbO+9QLmMUxIcz57LUC3YH4qP6DKlfhcjXCiSMVbqlU6y3GbFo27mXSKqsXf6g3FQOSym1rtcUBz8clMU6x3MzxlYLixuna8BwZojKoT+ZB0Qhm91Vp3vcQKBhNiP//F1zqZycVgOx8Hg3GrARi1TK5usUIqSmSTZOv9xtYb3y10e61602bu3/ZJQy1E/lfk/oPmPnAmAEMdg7lKDOT3Sxhy1p0CLNjAqzlejgJS7IPgppMfAht+a7545kuNd0DvuiQ3RJGk5U/zn9Q93ZoaGG/8i0AMV5dGyQhWosDgyKk3zTmX20jrbP1LEqI9Dsb5cuS+JtvHtpLsaVtpAGFZT5tu9IoShpoQlV1j3SM2WIhIO6KiL16HM8dONTtoqdJOPuQQUvi0moEaW+Qv/xZMeTEWH1Ra/DjD3FcJ1p42UKGAf3oJOQhhj7UF8Q7M+bC5ivqwZr1uJeU+/bvT4b32D01tQNtgO3/e1rEIcjbUUKFcIMaid98wBiPQyyUqFNq75s0Pfjo5YC9r6mKtpjx9KQ+dH/ysu8472fUhmWw4b9qmM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:GV2PR04MB11980.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(19092799006)(366016)(376014)(18002099003)(3023799007)(56012099006)(10067099003)(11063799006)(6133799003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: pHPNvOdJGneWs0bUr8DFM0hRHn0BMkzWU0qD0c/peP3JVAGYBdQtEexSrRoCwd1Y+pqgMqFUbdQ/GQVJUf1pUVxkiVIRLQZy+Wzl8wxVOfS25ozJ9PqrYtJSSgtGt1l/QTXTEM+bDUmF1YKxeOxs8amLGWyX7/6IO8gmbQAC/IuYSuHtM28lzTzZ/P2QGTu07grkdHf5qY825dQxUyj6UbG5d8y5I2WqAyjoLO4Twtjt7+nLl85gAPCr7E+x5WpuiHmyG4Nwx/cwi00sHoSL4BD6LcF1o/jKgmZG1083cDV2CRQHjvPPzF/BjB1v8+IeocEaoZ86Y9QQtXnHiUhCkVXrpCQENNmZ4NubZo6d4bdcYpituiivZkHhZI8Luun3jC7MLB4yBlJURwG5csKLGVHbAI0t1TVLmzP/ECAg9cDbw4tCBBfz7DDoXfDGAQt1Z8Y0IiH13x6JRWyEiVVMP5EFCGiXjAf5FABLPG41OsGpvM21DKBbUlm4nWee2t3Wj95oXgEhh/lffMPjtMd2CmqgNK6HW45oPl7g7WW1nwc0euGJKhhrwzkFzyGkOu8q76dOEdLDpmpKTATAwPbk7+FY0GDvEy4pE9i4dzpg7TCnQITfDfhsaLQnTI3AwmJ2b2jeXc09/VDIa1eDLsCFyDwrSK/ajPaGp54Y4CB5XZ7DbbLXlWQO2bOqoz7gOmiIioMIrLCKh74P5isLVjUcQrSPY3bouKtJ9XS6vlRsJkjGMuQ7fCeyI3exHGyzDISQSjIGyAws0HtS/RdMEUuA6I5lbQRDfnbdLFHoKZ7Rrc5tPzQWtCRuaSHYb1VZsLlE9CijK14+9OglbJP9YWTimoI2XGKfBJRiHTZlt4YSP4Hxeg4F0a0/wGzzo1SGFq0cLrYOrb4DxaBvsX7XXMnJHsi3/KANthckbZsxoioviSUtGIIthH/aCniemWohsj0wvxOu6qzxnS0BwizjHFduzrJaYSofC1xVSE+yhYoDGk8/HxmrgpsKcblWGa6bcwKPdT51mfFRHbnCLu2y/0qVxt9YfXuX41VZBC4V4n7+MMu6WglFQA94TpzW1ZtVWoX9e0rINGQ/M87EDLMTyqVcodOpb3KyKtgRLxYTqJaW80GVdaQSsHYYc5KzGmEogkUppiukKXwGB3o26K3RRcq+P01IO/J5d7dT0FXitFlnxYtmni/uemBzosJtxtHkIY4TPlU6dwyfUVGej708rXJT1bFcuxlYSsW4PgRB+Kk1cFDikV8OVff5f6AXWHFU+J8JBA89S1g0XmaNH7gJcoq+vy7yAAzcF2yqrCrH2ydLdPuQRx+mTwrSu6sQUxPNpDcYp8p4nP8Gqrky11onscwyImiT4RY9tpYYFnQFNHUYKWBPzp4PJPL+pZPaPPF7uDQ0HSAgW2Mc8JMtQVQ9A2Xw/xYvPEQpo6MFXsgffEpY3XBl+hwCoXR13dS9m/87QhDHw3eUV4bsE/J3R5TWeagEFnAHXLJ0SLV9VWu2DrtErwXtQOW8YXA2CS6jBQfBqq+f6/97XqpN8/J1FbiQEhnIee3dgIcKmuIHimf0FwEl5YTPS/XtH+SHmE5fClvMjoeEAxMha8GrAf3tLkzs524hY20jcJBON+e0f9jdP4oKTVYu9Sru6m223y5xWvpwUAAP4xaA5YNlOvYnKS/4tvlUyq9tr8yk6NzoxeyCQQE4YhRDQGTv5+c8k4SvCJCn9OaWCM5GP/7ngtFX7wiADyA16g== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49277bda-51c6-4967-f333-08deff6aca8b X-MS-Exchange-CrossTenant-AuthSource: GV2PR04MB11980.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2026 09:58:46.3954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HwmPdjXJz5dDIRTE/WH+iZoTFP6Pskvkdieusz+gM+bfz3xd7WMTt/5C36UlAgtFLz6jnrH8HF8GJIUEoY0A2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9519 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This reverts commit 4a5ebcf675a439c429ee9164c779e617b58bb7a9. It enabled the software ISP by default for the imx7-csi driver. However, this introduces a conflict with the PXP hardware converter also declared for that platform: { "imx7-csi", { { "pxp", 1 } }, true }, The simple pipeline handler enforces mutual exclusivity between a hardware converter and the software ISP, as both serve the same purpose of producing a processed output stream. When a converter is present, the match phase asserts: ASSERT(!converter_); This causes a runtime crash on any i.MX platform using the imx7-csi driver that has PXP available. Disable the software ISP flag for imx7-csi, restoring the previous behaviour and eliminating the converter/swISP conflict. Users who wish to enable the software ISP on supported imx7-csi platforms (i.e. those without a PXP converter) can do so at runtime via the libcamera configuration file by setting the software_isp key in the simple pipeline section. Signed-off-by: Alexi Birlinger --- Documentation/isp-feature-matrix.rst | 1 - src/libcamera/pipeline/simple/simple.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/isp-feature-matrix.rst b/Documentation/isp-feature-matrix.rst index b56f1e56e..3b101eb2f 100644 --- a/Documentation/isp-feature-matrix.rst +++ b/Documentation/isp-feature-matrix.rst @@ -67,7 +67,6 @@ different platforms in libcamera. * Intel 11th-14th Gen (IPU6) * Intel 15th Gen (IPU7) - * NXP i.MX7 and i.MX8 series (imx7-csi) * Texas Instruments J7x/AM6x * Qualcomm Snapdragon (CamSS) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index 02a98f594..fb777b3b4 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -257,7 +257,7 @@ namespace { static const SimplePipelineInfo supportedDevices[] = { { "dcmipp", {}, false }, - { "imx7-csi", { { "pxp", 1 } }, true }, + { "imx7-csi", { { "pxp", 1 } }, false }, { "intel-ipu6", {}, true }, { "intel-ipu7", {}, true }, { "j721e-csi2rx", {}, true },