From patchwork Thu Aug 20 15:18:56 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27930 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A5F74C3339 for ; Thu, 20 Aug 2026 15:20:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2A8606838E; Thu, 20 Aug 2026 17:20:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OAFBIx3D"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B1CA468340 for ; Thu, 20 Aug 2026 17:19:28 +0200 (CEST) Received: from pb-laptop.local (185.221.143.32.nat.pool.zt.hu [185.221.143.32]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 27A281D41; Thu, 20 Aug 2026 17:18:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1787239087; bh=akPbiwUIN9XerJhRk1qROk6H4P8Ns8o0op/3b5XPOzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OAFBIx3DjZz08fieg3GXeHEBSCU5Y+e5HtpyVOeBpPCqSJ7va+BCYV+1Wq4KjH88F Te/iBn4TU8Rah0Fup05VIhmI3Li+2fPkAJXqSWLynMXpmJF3DyPu013dVvmJ06Bx8q 2uvV8Y1pqhvOjmSAUME2wNkKIzRKdYueXozNb1XM= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi Subject: [PATCH v6 26/47] ipa: libipa: agc: Adjust debug messages slightly Date: Thu, 20 Aug 2026 17:18:56 +0200 Message-ID: <20260820151918.2382337-27-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820151918.2382337-1-barnabas.pocze@ideasonboard.com> References: <20260820151918.2382337-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The log message showing the result of AGC seems too verbose to me, and the labels and values are far from each other. And also log the line duration when showing exposure and gain limits. Signed-off-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi --- src/ipa/libipa/agc.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/ipa/libipa/agc.cpp b/src/ipa/libipa/agc.cpp index 21c0860908..fb6f765029 100644 --- a/src/ipa/libipa/agc.cpp +++ b/src/ipa/libipa/agc.cpp @@ -303,8 +303,10 @@ int AgcAlgorithm::configure(agc::Session &session, agc::ActiveState &state, float defGain = config.sensor->gain(v4l2Gain.def().get()); LOG(Agc, Debug) - << "Exposure: [" << minExposure << ", " << maxExposure - << "], gain: [" << minGain << ", " << maxGain << "]"; + << "exposure: [" << minExposure << ',' << maxExposure << "], " + << "gain: [" << minGain << ',' << maxGain << "], " + << "line-duration: " << session.lineDuration << ", " + << "sensor-output: " << session.sensor.outputSize; /* * Compute the frame duration limits. @@ -632,10 +634,10 @@ void AgcAlgorithm::process(const agc::Session &session, agc::ActiveState &state, state.automatic.yTarget = newEv.yTarget; LOG(Agc, Debug) - << "Divided up exposure time, analogue gain, quantization gain" - << " and digital gain are " << newEv.exposureTime - << ", " << state.automatic.gain << ", " << state.automatic.quantizationGain - << " and " << newEv.digitalGain; + << "exposure-time: " << newEv.exposureTime << ", " + << "analogue-gain: " << state.automatic.gain << ", " + << "quantization-gain: " << state.automatic.quantizationGain << ", " + << "digital-gain: " << newEv.digitalGain; /* * Expand the target frame duration so that we do not run faster than