From patchwork Tue Aug 18 14:05:48 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27845 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 57F5CC330A for ; Tue, 18 Aug 2026 14:06:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CA80368301; Tue, 18 Aug 2026 16:06:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="V14IYJUu"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EAvMs7mn"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8058568307 for ; Tue, 18 Aug 2026 16:06:06 +0200 (CEST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IE1A7L1085260 for ; Tue, 18 Aug 2026 14:06:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6ojiK8/yPfAa1toBNXbb2+xkfwkif46AM64OhQcn3ME=; b=V14IYJUuYFm0of7c K34TKbNFlBDT6k38vSxo2/TBlhV1N29CeM0fCT3PGh7hoUtub+R4ks4E/6x6TCm6 WNqqC4bpaagrnJr6JrdUE1HwrA2gpJGJH6iDYF4wF7kfQYucTLX+Objfk88S3d/j PP+OqTbFahgaJgvCzVk+WmitIcGSWmgszADmF2IIbB66AI82tZp/t6qkA9UBfXC9 XbfKZYlGzqq4hqNb+gTbv/78rNCovOhTi3WeikcPCIhQc+KPHwpclOBsQ78Hl1Rj /EBXPV8uqP3QeKQ9uJztNtnXAsjZ5DTGyPJFJrKYdOiV4psKxwuTN3qDtvBga8zQ f8ZfQg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4fbaajn9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 14:06:04 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e8004d60eso824715585a.1 for ; Tue, 18 Aug 2026 07:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787061963; x=1787666763; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6ojiK8/yPfAa1toBNXbb2+xkfwkif46AM64OhQcn3ME=; b=EAvMs7mnUrAO9zSKh0cwVpkoU1DpWqkDrYRhoXO+/Cbpa5ZU9n0FSALkAUqEJ3fLUF XkgCRFoP1Zyt7Z4/v3w7H46gKU6Tu9crRi1ApiwBmwMuOoprKWAuz++ZIlwx6GvNMRS+ NQksjYhXctTkpNE62/CZMuLXK4qHwWrcZ2mTlwWVFUKfPR429be/wOJM+IILTCU2quNT oq9Q5GpOqDId960XsVX7pphvhWYf5dfss7Sa4B1I0sfYjNbDJf2btuQpdJunxKsYeTmH nkRSAZ/46IZN85a9g3BN/SrBw9Lz2OzpflxV72HdcqgmILX0eV5v48qTTbv9dc1oYgwD D0eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787061963; x=1787666763; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6ojiK8/yPfAa1toBNXbb2+xkfwkif46AM64OhQcn3ME=; b=JC2RxqFAIw2n8uSDTuWCX7o/RN+DWbG8X7flZo1K/e7Y2xp5Kafx/Rm9rQfRhijXOc I+VEA4Bqtt73E3b04Apj/kCvO2IEQ+pIgaQ1CyldD7dT9fbLZab9RXK55S2jN8JMlKoI nyec4b6RX/jcv+m7vxQrbOLhNgdA0467h9Dzw4OTAXB1bMXTYj3tQ0j03hkE/PcdDnHD pmLoLi2Vf9Y8krFXsznFTRY4MY2+QXMJJRwQ27umuGxZCaSgfjwByOvswPjBhyYnvdXG ZfjkqQWTPIQkQ7CS8cQ2O+z5+IyaE9x1eQy5y9uamk6HLBIXSuUHdW5LDjT90p5eqNCw beBg== X-Gm-Message-State: AOJu0Ywt1DauomAUlI8NM5QM9kjPr1/pauhaAh59fPw/WLziipQhIm6+ kbBDQwUHTIZOEVob3CTzhaqpqg0ri6DLomj3d5oDVVjyzIv6bSsEYvqj/fryASqaSVyAec35eXX v1t8yJdL9mo18lcOEAQnHOQjbeHRZizu0nv5sZMXZBpGTs16JKfHAoTYbV49xRQCZ4+PdAHgns9 RC5pvVXjar X-Gm-Gg: AR+sD12wUV7HtgL3GCl1nBftuHssWKAByaUlvfpqjc5UDwsiXVtXp6IbnUimDfl59pf ze8sGP7E3zQRHKD9tEdBZ7dB9sBtN41Co9ADsZzhe/79Gmpb7+rw3Mv4slgc4+Kz1TuY2nsGy7I k33f4b3upkuT/TyDeEKZ6vwov70OtxpktmCeHHd8P08dmbVskfvQrgmCvzjz/YO9I7yYyoNrqJp sEaecvb+D8kr47GwcYSuULMqHrkdPJ0LgxD0G9N9TcY5g1ISK+SxZrSP5eqCXj0ZOnfiKzBGs2/ IOiEFEVR1ZslN79jcvmtgQbz+6ir1uosRSRveJM4ciADE03KFw8o2rZSGfOh2W0+fyqrRIhHypC PglOrDVCUDK3CUF73sGn2vJgxbiyERYb2SufxCyyjkuWd/lJLBRd6arPeutfJ4hi+DzN+HNXKR+ uJ/fg5OzU1mN8CcKU= X-Received: by 2002:a05:620a:414a:b0:936:df55:69e1 with SMTP id af79cd13be357-936df556d10mr2756115985a.9.1787061963207; Tue, 18 Aug 2026 07:06:03 -0700 (PDT) X-Received: by 2002:a05:620a:414a:b0:936:df55:69e1 with SMTP id af79cd13be357-936df556d10mr2756100385a.9.1787061962526; Tue, 18 Aug 2026 07:06:02 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d85a30b7sm1874967a12.30.2026.08.18.07.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 07:06:01 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6?= =?utf-8?q?derlund?= , Loic Poulain , Hans de Goede , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v9 8/8] ipa: softisp: Rename setIspParams signal to paramsComputed Date: Tue, 18 Aug 2026 16:05:48 +0200 Message-ID: <20260818140548.179663-9-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818140548.179663-1-johannes.goede@oss.qualcomm.com> References: <20260818140548.179663-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDEwMyBTYWx0ZWRfX/RNXktWQTbKL cQThskB4eEbnBdJPfyhaZfQmTVPNZGdOhlYZHpLN2NnFaQn1haSKdMVTaO37MGMLP+gXLvPO3ug cRuf5kp0uKAl5Sgkd5+O0TMFNzaAu8A= X-Authority-Analysis: v=2.4 cv=VsITxe2n c=1 sm=1 tr=0 ts=6a8466cc cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=X9iWcBBwFAc5_HUTaPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: ZBpy4t9VoedYeITlENlk24VdIR0gqW8U X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDEwMyBTYWx0ZWRfX8grwH5JedRg8 EtZadud7GsWqWvYd64DuFTH2QN1iyyYidyREC7QshyyZa7MB91QP4NJArS5uCpIbHgzCeueFIRg xD5Aci6k6ej8m42c5dVJsx8mf1OFNjsHi1XJskYpRYpN68tyX7QN0PMNn8lv7FP7BEo3AQaSLgA 1Tk2QtNQ9q+DTQFd5hdsmnIERvb2Uc00etuPWPMcUDX1U8eARDXkKh+BytHd+xXn1a5om0OcLgG oIjSbnqiwHp4ty3DAVk7DtlsZQ2ZKqQ8S8wNE9o29DLVHDheCQo8t1f/5W2sv8vb/XYoetK3kCf /e/DrETNFCzu59bFl9jidf2Nny8l2F+Tk+hFhvvFyRaP8dkmyUBzKlhKvJvcOgtYdQU/AZSL8sn /zxnYdOJwpWS2eMgCg4tNuCFmAy4iFynx0NdJTv1QRbKmQd/apPGwQjSX1VwNckgE0HqTuuzOqk /v77EGP9EosEpGMJqsA== X-Proofpoint-GUID: ZBpy4t9VoedYeITlENlk24VdIR0gqW8U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180103 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename the softisp IPA setIspParams signal to paramsComputed and pass the frame-number as argument to make the softisp IPA behavior consistent with other IPA implementations. Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Signed-off-by: Hans de Goede --- Changes in v7: - New patch in v7 of this patch-series --- include/libcamera/internal/software_isp/software_isp.h | 2 +- include/libcamera/ipa/softisp.mojom | 2 +- src/ipa/softisp/softisp.cpp | 2 +- src/libcamera/software_isp/software_isp.cpp | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h index 64c77e65c..da893d242 100644 --- a/include/libcamera/internal/software_isp/software_isp.h +++ b/include/libcamera/internal/software_isp/software_isp.h @@ -89,7 +89,7 @@ public: Signal setSensorControls; private: - void saveIspParams(); + void saveIspParams(uint32_t frame); void setSensorCtrls(const ControlList &sensorControls); void statsReady(uint32_t frame, uint32_t bufferId); void inputReady(FrameBuffer *input); diff --git a/include/libcamera/ipa/softisp.mojom b/include/libcamera/ipa/softisp.mojom index 55b6e4d7f..a892d84f1 100644 --- a/include/libcamera/ipa/softisp.mojom +++ b/include/libcamera/ipa/softisp.mojom @@ -33,6 +33,6 @@ interface IPASoftIspInterface { interface IPASoftIspEventInterface { setSensorControls(libcamera.ControlList sensorControls); - setIspParams(); + paramsComputed(uint32 frame); metadataReady(uint32 frame, libcamera.ControlList metadata); }; diff --git a/src/ipa/softisp/softisp.cpp b/src/ipa/softisp/softisp.cpp index b3f0d3fa6..aec04c528 100644 --- a/src/ipa/softisp/softisp.cpp +++ b/src/ipa/softisp/softisp.cpp @@ -292,7 +292,7 @@ void IPASoftIsp::computeParams(const uint32_t frame) algo->prepare(context_, frame, frameContext, params_); params_->combinedMatrix = context_.activeState.combinedMatrix; - setIspParams.emit(); + paramsComputed.emit(frame); } void IPASoftIsp::processStats(const uint32_t frame, diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index f29f78c98..ae86c20a8 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -171,7 +171,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, return; } - ipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams); + ipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams); ipa_->metadataReady.connect(this, [this](uint32_t frame, const ControlList &metadata) { metadataReady.emit(frame, metadata); @@ -432,7 +432,7 @@ void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *outpu ConnectionTypeQueued, frame, input, output, debayerParams_); } -void SoftwareIsp::saveIspParams() +void SoftwareIsp::saveIspParams([[maybe_unused]] uint32_t frame) { debayerParams_ = *sharedParams_; }