From patchwork Tue Aug 18 14:05:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27841 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1E303C3334 for ; Tue, 18 Aug 2026 14:06:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5895768305; Tue, 18 Aug 2026 16:06:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="HLWSoTf/"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g05w3mge"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DCE2A682EE for ; Tue, 18 Aug 2026 16:05:59 +0200 (CEST) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67IE0Z8V2564176 for ; Tue, 18 Aug 2026 14:05:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Dsi2Vw+XNd/RoJQJe3h88SfzJLuMAiqlvlVtYEPGWl8=; b=HLWSoTf/VPJjT0Qd dzi9h0HQkxPkRcPsJGK2P98FmhB3G9OCiZwk/i2JZq3O3vC6jeTe69h9ONR+NFUd brDRswHGe+zsJqkQ1X/FkmPH3H1u/Y5LKqWT1EHLyT7GkvNlHJNLh6jZ9GTTvbpf eE9yiSV+wxhwMa9HC9SfF1bg9JvF74pld5DwBYdETn0qG7s5wPDZxOimpC/yIbXv oOkGO1mMrs1rknf2cVfowX8AC1ov03q7AhYlP8hi9V1R97xJTAyZITNR+dLqEXPD y0wGasShxzOFvp5H+W6CiDPRoqon6nnjj2JSqywqYqtGjBO8lAZQ1KyN3z7ZGQJ9 EI+E3w== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4frmtgkp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Aug 2026 14:05:57 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-77543522a77so29296137.2 for ; Tue, 18 Aug 2026 07:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787061957; x=1787666757; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Dsi2Vw+XNd/RoJQJe3h88SfzJLuMAiqlvlVtYEPGWl8=; b=g05w3mge5PVw69PPJYujrDmxo4T4AUfiveq5IcXUWV3o2gviRUxFmLMtEGS4vWPIx7 8zB4MP822FVfGQH2fdvaSiwYhkWKUw7at32L2hf9CrP0CiJV7eEQELririZsBYsLVhMh i+y56z5k62+1/Fm98esrr0gq32ECmXpAnKxwmYSzK6c0PCTb10XR9geKAO8d4WcEDbvc PpiV94Xz+J23L2ZAS07NYFc68nzqaELpQfRcJ8i8TQMeGtNilpbHWsbk3CfGmTttZJ3Y LDzsu8QaDyslavqAUHym3Z+WXhc8TRLrlZ1fevA1Lx9QbZ5Aqcwy7sxtvHVbElbYDq4i j3FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787061957; x=1787666757; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Dsi2Vw+XNd/RoJQJe3h88SfzJLuMAiqlvlVtYEPGWl8=; b=TBNc/eb+TWoUOwKcLzkvzxmKPksXHGzIruqLaL1TZU7MDR+HdqTp07/aGWbV6Aqcv3 Rf1A7qhyGaD7hAgerTzDfnMghUFHP/wBybnii21ZMuUyGPhfQKFqZ142DhrH3GGu9ovr /J6+aNskDnsME7/K0xbOq61kFiFHQa/SKLHYDncrjNzaPR/pdIvwbS6G5n1eqdYabBGE 8rLODdpjvPP+oLIpFI1I3b8xHfFqkEO+n4OAIRneAx0z5IOniawMlHNM5HxPvOTw9Tom pN1SBfxcLw0Cl7kNLPkrAteoMpuwfsGYUSpIU5z9bZFxNDtZ5/lBE+7cZPxHvv32Z8nn vmMA== X-Gm-Message-State: AOJu0YwbwLcLrhnMo8KZknmfZFuapJr/D7frogjK4Eli63aInkGATx+l 3JMhy7iN1D0pEiQDFXUUbAUoht9EFmmc53zYhj+8Im/d1r5ZfHsTQTTl0unYaX/QPYCy2pm8WWJ FsUD2WRuiSN1S+4s/x+Oer/9ngEWfyJ5mcLbky/LXGTV0l+E65i9+7yZVhjZnZXGcFnVj6R9x+2 Q6jSs5w+y2 X-Gm-Gg: AR+sD12SX+kNfjm5uTpMzkbSfQjkqrFxNWJuYmRMeufO16OhV0P81DJyfIOvCm/6PQb 2ZZ0qe2HJuraoioPVuBPwpnAxhQUBDqGPkkEJccRN8AHdNUP267Xb00oni+jnUWVorWbkBFKKpO b3w+ec8n3quI9JlCge8Vvwb/XfK/S0WKPZKICgHY9N7bpLqoSnpHjRkrUhNJ4phye7+7pFfNjOJ h5aw8UAQKeUfnsCePnRl8RT0c46AxSjE8vJEaJHoCAidOyU69r9vFNVnWWe22lznI/NDQDecATv b3S4YCoFwIDYGirTCaaYZMOHc3wWRL9C651lf4ns1ptvWBYiojjyp/uW137eYfoOJU7y5h5LT4h XPFULdmMJ+EiVU2/AboETxOGeir/kaNffbl8tUHoxzpt0dOp8mvq+JwN6ovQblzfuf1CcMnVmb0 Go0z8G4+A+qJ2xwDg= X-Received: by 2002:a05:6102:148e:b0:738:472f:2cb1 with SMTP id ada2fe7eead31-76f2b9179b0mr5783446137.8.1787061956853; Tue, 18 Aug 2026 07:05:56 -0700 (PDT) X-Received: by 2002:a05:6102:148e:b0:738:472f:2cb1 with SMTP id ada2fe7eead31-76f2b9179b0mr5783415137.8.1787061956351; Tue, 18 Aug 2026 07:05:56 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d85a30b7sm1874967a12.30.2026.08.18.07.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2026 07:05:55 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6?= =?utf-8?q?derlund?= , Loic Poulain , Hans de Goede , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v9 4/8] pipeline: rpi: Explictly pass pipe()->name() when creating IPA Date: Tue, 18 Aug 2026 16:05:44 +0200 Message-ID: <20260818140548.179663-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260818140548.179663-1-johannes.goede@oss.qualcomm.com> References: <20260818140548.179663-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE4MDEwMyBTYWx0ZWRfX3ZMv/+rh/jQh 1CrO85WDRRWmxX4pCOSwcRQIEXjCbjIJSKzt9ugAVBemUCRxonBjRScl1Ss2luAoSQu8yz6OlVF BHpxA4Hs2hIqR3Kfu5bP10OtYqv5RHivlg+URPiOjWEa8xV8SNoUo+mkufq7vJKc33kyjQ8vjo2 sUXnWI1CwNe3QkVrXMZAJcndXwRLLKWHJ7k+Z0mzzTSm5tPQ8xU8DYsynoDMIsnYg/EqT9TNmSh Hgkzc866wMNeJVBq8fCq9r3rNNlvuo5KN+5d7RQNL9xREI/X8C4v+UQ8ehbK37qBTcYDtpYYxoc 6u4CMUa2o2IIVNE1yhN8au0nH0EMBT/8FrSy/DIMHQNVemDn6K+zpLDc4iDWBsWEuTgO9z19WCI QOwWaSLJUXxeVky463ijwxqnTo0uRfHVGronXUuCYRXgohZJh7ydQh6xSp3EnWACyywGe2VQmGi szIP9fW2msiBm+897iA== X-Proofpoint-GUID: ZLdFXI5A7wkPmLaSk2aAOU2D7wbh0e7j X-Proofpoint-ORIG-GUID: ZLdFXI5A7wkPmLaSk2aAOU2D7wbh0e7j X-Authority-Analysis: v=2.4 cv=GtlyPE1C c=1 sm=1 tr=0 ts=6a8466c5 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=PI23gj2s8gul_AyujO4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE4MDEwMyBTYWx0ZWRfX2SzkrOUEXjGX HaQQBVpQLge6bSKJ4V7xwxMuHo4hDaSeOrnGHlTwlRdYo+UQjTBIX6/v8FZpPTCFahW56iVHnPX 61AZLWf65gHHPseUAkElWWq6yhUuMLA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-18_02,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608180103 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Switch to explicitly specifying the pipeline-name as the name of the IPA to create. This is a preparation patch for switching the default IPA creation to matching IPA by IPA proxy type, which does not work for rpi because the same IPAProxyRPi type is used for both the rpi/vc4 and rpi/pisp pipeline handlers. Reviewed-by: Jacopo Mondi Reviewed-by: Barnabás Pőcze Signed-off-by: Hans de Goede --- Changes in v7: - Add a comment explaining why pipe()->name() is used when creating the IPA Changes in v6: - New patch in v6 of this patch-series --- src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp index 5a5acf6a1..802b2b3c7 100644 --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp @@ -1165,7 +1165,13 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result) { int ret; - ipa_ = pipe()->createIPA(1, 1); + /* + * Explicitly pass pipe()->name() to select the IPA to create. + * The default behavior of creating the IPA by the IPA proxy type name + * does not work because the same IPAProxyRPi type is used for both + * the rpi/vc4 and rpi/pisp pipeline handlers. + */ + ipa_ = pipe()->createIPA(pipe()->name(), 1, 1); if (!ipa_) return -ENOENT;