From patchwork Mon Aug 17 13:40:42 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27834 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 54C56C3264 for ; Mon, 17 Aug 2026 13:41:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5B05C682A0; Mon, 17 Aug 2026 15:41:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="moWmRJuN"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ae3NcN4X"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2AC8568299 for ; Mon, 17 Aug 2026 15:40:59 +0200 (CEST) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD6IWT2395062 for ; Mon, 17 Aug 2026 13:40:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6ojiK8/yPfAa1toBNXbb2+xkfwkif46AM64OhQcn3ME=; b=moWmRJuNpbwnmhgj jyoZU9e6ffJsAFx1fPcgawIvtUPUsAq1f9q8Zsura6HxDcN6WKb2pmnfLAPuQoka JavoTldpTKEO+qPXrO83dNgfFE0FSM3898kX/LCsa0sHZpwp1/jYWFJYD+GoDfpP 5iUEtgWqYlnyz8vGxIf43+4yas7uQItEpJU6+E4R22AYuq37Mslmj9F1MDzWea4u +A8K7mx4SLvq5YpVFsfOBwy8MkdiUOBbxmOagcrF4r2CGj117vZDZiMUhW8qcqiL lyAKP1WFwi09843X1ADnAuIlH9gaBDtyMsz4idXy5SWdcaHOZdkapxKt+N+G6US/ 9DjkkA== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3txya2jc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 13:40:56 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8f0f45415cfso34600846d6.2 for ; Mon, 17 Aug 2026 06:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786974056; x=1787578856; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6ojiK8/yPfAa1toBNXbb2+xkfwkif46AM64OhQcn3ME=; b=Ae3NcN4Xcxx7yUaP/ApYal2rnIjNgkWlHM8RV6pfXkf6UNhmr1oS3rYinqYJ2HCK2k fki1sd0GwlbCuZX/Xz17YiIPrv+ehdhLaKb0HGciWMLbMi3yflkJEAq6WgnW79LpUQ6Y Ve0w5P+/pddiQyx91iG77WxefUytu+ypTVELro94A0O+U1uHOyId85yAQWsR87mG6ZpW p0RsBoXUqpE64khEdCMu+hxgJUciUYbn2boHVEv806uBF0fDR3JPs5xyq/apnMHkeTZq bxsRSksl9+lIYAM/v2/MyuO1RTFLsu2XqZX6cfVl2u5JH9gCz2DJom7XizFAWvY1T6j1 Wlmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786974056; x=1787578856; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6ojiK8/yPfAa1toBNXbb2+xkfwkif46AM64OhQcn3ME=; b=C+RwU29tZTLP2nIW05/krT5+Q68Xx05f3//oJP6VJ6UBPRWRzOqIvyjZq2SZl2qaPp YgScjy7xuZltNWRC4copE+ysGpeVh+qDg7J1r5roGPh2B8fDzhkj1Y9L3T3zrJfEZ08W RcYta3BL/vZOvMcHxOO81gabZmP9PISbl1rpMSBVXB22uwrKcouRkrtZFgHXEVict4bB pwEbjjv7vhAKjxoQPpkZ46tOCvgRAY7S6KtmCqqsHoib4EQq1XT2fBGzGbTDIFe1o1zJ nz2DkGjlPSm0sbqHZX0xtOKM069gJXUoItKbFW4h3QTHfIBj1+84uJX1wgX4WW9nASBs buDQ== X-Gm-Message-State: AOJu0Ywa8cAu2b9ZO9vsFqmr6O/sgFzYhsBWqF3lHJOx+8syHX9VMEJv KQLNjd3m8HbRJ72cV9p8gwloXGKqpRow/jBE4F00Z5/5R08xEMDGGn1oQ9NypHJMzQvXIRYgrb9 75njnzNwTBegROUEV+IJdzlvnwHQ/wSoC+xmv6k7yDQf1Q+Xpv7wqgx+rgBQCz5K3mb02JYi8oZ 6MUMs8GTKR X-Gm-Gg: AR+sD10O79x0EZqtkUGr1Xvp4lc0o4RfZUfuS0n1YPU4kZaeY1YeWp2juXblKUSWOpn UnAvl3mMfQ/DKp0tHNA0EkWCUX+qEQTQXPWyJN5ffzhEK7wg/Rzr7QEXfXUt8p713J4WncY1Er9 iGx0RvMd2HLtQVCZ0xwamBiHdA/vGQgOPO69ijge6rhkxJsBt6uhH9yBTa4zF86RqzW+yXws9bp zlivoA5LUunF0LQeM3LltrUjeJRx9Cw2T+vtLuEAfNmKSYVVhceISE+oLvjDtT9JW9A9TuS41+K ll34DuRE/2Si1uFkiicP61KhnuVMwwILJ5fxd2KjJRdMEoSXiHNn9+hcKZ1PWA0dkVXajfjcoM7 Ql+mbq0ScPC92rpmRdTByclIKK4n/ X-Received: by 2002:a05:620a:408c:b0:933:ada:c3b2 with SMTP id af79cd13be357-936d2382749mr2596022085a.34.1786974055885; Mon, 17 Aug 2026 06:40:55 -0700 (PDT) X-Received: by 2002:a05:620a:408c:b0:933:ada:c3b2 with SMTP id af79cd13be357-936d2382749mr2596017385a.34.1786974055466; Mon, 17 Aug 2026 06:40:55 -0700 (PDT) Received: from t14s.vakwerkhuis.com ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d8517181sm772179a12.1.2026.08.17.06.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:40:54 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6?= =?utf-8?q?derlund?= , Loic Poulain , Hans de Goede , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v8 8/8] ipa: softisp: Rename setIspParams signal to paramsComputed Date: Mon, 17 Aug 2026 15:40:42 +0200 Message-ID: <20260817134042.277168-9-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817134042.277168-1-johannes.goede@oss.qualcomm.com> References: <20260817134042.277168-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDEwNCBTYWx0ZWRfX2wA7AtgElRVI Una6vQOGobAWjbKAHb2BZrrY173AG8ejj9qGewD8eAkBpZe0hUJa70u22Ul5Dc6t5xT9kr0Kj1F fS0pXLTGCAbFzBMjGZX3ZHmSWeua/vQ= X-Authority-Analysis: v=2.4 cv=auGCzyZV c=1 sm=1 tr=0 ts=6a830f69 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=rrvG0T/C2D967D07Ol03YQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=X9iWcBBwFAc5_HUTaPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDEwNCBTYWx0ZWRfX9mRDrvHQaCMO +DftWryMZjttV671I2qz48evMO1j5Cpo0DqbgbmhTRR7ii+yyAF8YnhnZQZsyBYaDjR8R6/HNdS luKD4ZkY80L9T0pGgfUgAq8VQ628FomYn3aUFmn82qhQI78KJ2RA8Xr4LO//nuX6zcLlpLSWebi P0HAE9vgHie9piCVlcZoGf9DhaJ3pW5NT/OPGwvlQezDItTDfN1vxGusGUSzliXV2MRkbjKPV/R KVzvQhBj1QmkVUMJytQvwCYezuY2efbCe/Vm8aolVbzFsflE3mrIZ26cQaNLsufCnAmSDyaGUAm +Xn4YS9MKwzpeTU6JAXxMNGXrMRn5g/SgQA+qGD1M6gv8HARB5lVRmwI+G3ymEnIkdxuSy+Cl2E 6gLmTJwdMBRJSHvhBCaM9y6uWI5+7IOnTtutrp8oGWrpB3EKjdUL8WB4xyZK6oZjAt9C1R+NTEt n+fDIIIy3xZWheN7S6w== X-Proofpoint-GUID: lFIAOV5CRREDXItihvIBAICi_XDcXxk- X-Proofpoint-ORIG-GUID: lFIAOV5CRREDXItihvIBAICi_XDcXxk- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170104 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename the softisp IPA setIspParams signal to paramsComputed and pass the frame-number as argument to make the softisp IPA behavior consistent with other IPA implementations. Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze Reviewed-by: Jacopo Mondi Signed-off-by: Hans de Goede --- Changes in v7: - New patch in v7 of this patch-series --- include/libcamera/internal/software_isp/software_isp.h | 2 +- include/libcamera/ipa/softisp.mojom | 2 +- src/ipa/softisp/softisp.cpp | 2 +- src/libcamera/software_isp/software_isp.cpp | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h index 64c77e65c..da893d242 100644 --- a/include/libcamera/internal/software_isp/software_isp.h +++ b/include/libcamera/internal/software_isp/software_isp.h @@ -89,7 +89,7 @@ public: Signal setSensorControls; private: - void saveIspParams(); + void saveIspParams(uint32_t frame); void setSensorCtrls(const ControlList &sensorControls); void statsReady(uint32_t frame, uint32_t bufferId); void inputReady(FrameBuffer *input); diff --git a/include/libcamera/ipa/softisp.mojom b/include/libcamera/ipa/softisp.mojom index 55b6e4d7f..a892d84f1 100644 --- a/include/libcamera/ipa/softisp.mojom +++ b/include/libcamera/ipa/softisp.mojom @@ -33,6 +33,6 @@ interface IPASoftIspInterface { interface IPASoftIspEventInterface { setSensorControls(libcamera.ControlList sensorControls); - setIspParams(); + paramsComputed(uint32 frame); metadataReady(uint32 frame, libcamera.ControlList metadata); }; diff --git a/src/ipa/softisp/softisp.cpp b/src/ipa/softisp/softisp.cpp index b3f0d3fa6..aec04c528 100644 --- a/src/ipa/softisp/softisp.cpp +++ b/src/ipa/softisp/softisp.cpp @@ -292,7 +292,7 @@ void IPASoftIsp::computeParams(const uint32_t frame) algo->prepare(context_, frame, frameContext, params_); params_->combinedMatrix = context_.activeState.combinedMatrix; - setIspParams.emit(); + paramsComputed.emit(frame); } void IPASoftIsp::processStats(const uint32_t frame, diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index f29f78c98..ae86c20a8 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -171,7 +171,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, return; } - ipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams); + ipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams); ipa_->metadataReady.connect(this, [this](uint32_t frame, const ControlList &metadata) { metadataReady.emit(frame, metadata); @@ -432,7 +432,7 @@ void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *outpu ConnectionTypeQueued, frame, input, output, debayerParams_); } -void SoftwareIsp::saveIspParams() +void SoftwareIsp::saveIspParams([[maybe_unused]] uint32_t frame) { debayerParams_ = *sharedParams_; }