From patchwork Mon Aug 17 13:40:38 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27830 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B9094C3264 for ; Mon, 17 Aug 2026 13:40:59 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 52BD16829F; Mon, 17 Aug 2026 15:40:59 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="KbFfmrKO"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jlenJGw/"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8272B6828D for ; Mon, 17 Aug 2026 15:40:52 +0200 (CEST) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD5rW72008348 for ; Mon, 17 Aug 2026 13:40:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tALQ4WPF1H+ xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=KbFfmrKONv2/5avn4U4xmGUX66q d0A7rwnxxQFECTTo+zctYvZP5CRVGizg+a0fVJEtee8plzj8Qmmamn34ZvgzYVUT bUrUcisLqEAj7KffWwBTwItdA+x6uW7rg9+rG89WfSf/BD4IJMuH9ABvc2UpnD1j PhTGAr/LdPnGpHt7VjCdI8RhxZQh+YhEU6i6onhaaheF7mBqnC4ARmsnGQXT04PZ fKgi9Q8c8Q8oCNyIT8pL/we/zTVPlqlV9Jn1nSM9kXHPEwnJ93av27ZjZ9R3i6V/ 79OGpgnQ49XQ+2RWuB68mvOh9kUEYC4hG/oh8zCVoLBvMcqZm9K9eQuuPYw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3xw8h55k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 13:40:51 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e52306621so327943985a.1 for ; Mon, 17 Aug 2026 06:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786974050; x=1787578850; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tALQ4WPF1H+xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=jlenJGw/w2WqtmyOoJ7JXJTI1J+8asBOUrQudjbSN+cpG9HIYMiXjIQ9+/yuDDzMgH whoYcYyAq4PD8sbTh984whuI8+PV5YokSgvQIe+anZXjDHRvj8tCHnu5MB2pYPb0GMiA JC67j694aCOANtwUSSqfpZ1oq2Pxp0UJVRJyb0FoxPLdVq35tB2oF7ZVIOJzHSuMr4O7 SThf+6JjU8LzDeYos/8yo8S8Aop+EmNQR7Rnui58n5Uk7QO1WVY9FZ8tV+OQTAfWgpSk An7Pftf/5b23YiNcT42cwAXiJy0/OjWxpSSmMUj9IkCQx7WxHZkRUebnmmMNImFkqS/O W+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786974050; x=1787578850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tALQ4WPF1H+xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=rs+XfoPuOIoHpuducuPty61+wi8YGZGNFAt2Un1V4JzxafS0RVuTAsWk73EiI6diAb YFQJsE1ACNgBBCQfZjhwY+w3ynAuFk8oF0m3A3D27LQ76GttVnzDnnBM6u5osW1FcIvZ NbtJCUXXtyqXv/HYs8EI2896XLDD0cPYCiEFdwbPOskfcZ7s102aJe45VmwrDCTP3n6b azA4Mye9YWIbixhtbAgi7JR7H5U45P6m2UYRSObKrN7O4htxVhGr3365vo6MhpPcQ+6Y smKF95gFTKhfOQuxJmcgTsZSisHK2zyHsTBckF5mHfALpsSW5Hb7qrmnG0ZkfFX7CVaR 7ttw== X-Gm-Message-State: AOJu0YywqZJfIRY9nlFarcbiouXua14a5LuiLs0QT3u6TS7DHUVeZOdN ZYCV3bjj0JCWhLhVCa1T8JnpvglRTxNZ2xh5bLmojCJ7dS8B19KRVc0R+0FKjBcV95D1LMhXfQg PdL6Kae2SsJAKyu4j08znoVrCqfcpTNUAtoKy1wo8V0NzXCZx5mBdQW9ro2BvQX9dmt/sbBD8O6 k+HxyNWgLV X-Gm-Gg: AR+sD11Pw0ZGYeky0kRAn3ZIsgCe96KQT62Zpd1c6+kA12i+NEBdfR9ca92+jDVV5RO /1FmeDWIAexJmEQcVIGtas5x8y5eCizw8sInFb7HiVrFjpbi/a5U5jhtsiGKUBlQzweuUfcnA8l +eR8BVbzma6yXvMhx+7Yc0LKZRAw+Acv37l7vM5Cc9Oy/Z/M1SWXGL22JWpsw27aO9WDLaJzthm xcWtABPvpknOBtWG+LBU7t/p0hb3/9+583PizQf4VQky7bFF4ODTefYuzWT39dLySVTomKZ3rsA LjeAtrTP+NGS0sSxQI2XPp3rtMHuNu0bTmE+4mWqK/ayvnCrZHNodkqkgNQwIh/GAzEEndQGkgX sEj177gx5dlLR85cCI8YFvbaS9w3D X-Received: by 2002:a05:620a:4514:b0:92e:4859:49dd with SMTP id af79cd13be357-93704b7d482mr56432185a.26.1786974050504; Mon, 17 Aug 2026 06:40:50 -0700 (PDT) X-Received: by 2002:a05:620a:4514:b0:92e:4859:49dd with SMTP id af79cd13be357-93704b7d482mr56427085a.26.1786974049998; Mon, 17 Aug 2026 06:40:49 -0700 (PDT) Received: from t14s.vakwerkhuis.com ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d8517181sm772179a12.1.2026.08.17.06.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:40:49 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6?= =?utf-8?q?derlund?= , Loic Poulain , Hans de Goede Subject: [PATCH v8 4/8] pipeline: rpi: Explictly pass pipe()->name() when creating IPA Date: Mon, 17 Aug 2026 15:40:38 +0200 Message-ID: <20260817134042.277168-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817134042.277168-1-johannes.goede@oss.qualcomm.com> References: <20260817134042.277168-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-GUID: E9QPPBE7PdKkUGgcRH9Hz323XY0841cp X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDEwNCBTYWx0ZWRfX0dIvWKKL+HJg kWX1BwW5apIWid7bHNeMvi0+QOJ7FeCIMeahINGymaPE/u07yyiWcR02pWe3DPeh8dhyj/IAPaY wW7KRpbYXbU1am03Q0LNjWa3lVnSCN0= X-Authority-Analysis: v=2.4 cv=SuCgLvO0 c=1 sm=1 tr=0 ts=6a830f63 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=rrvG0T/C2D967D07Ol03YQ==:17 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=PI23gj2s8gul_AyujO4A:9 a=IoWCM6iH3mJn3m4BftBB:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: E9QPPBE7PdKkUGgcRH9Hz323XY0841cp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDEwNCBTYWx0ZWRfX2WRiO9nFmKJ0 I08RMxZa5bWHF7N0DeuUaF2iEG3MvqQLZBnAbT0OV0fX7XqjP0C/unaoHadjLkze7Aq8PTHDk9j TM3iAdfZDvx4PPsGCO5DKNLDCmMuKwt13B6ajOOCPgNxshACd2VLauu5KYzdI+x+bY+6eJMKc3P jRaZ9/fDPboZz9TJs/EqNqdPLccF/z5woXHpHlqBpIrc126qle3X2naNpPfsHOUBAUfNEyT4DNJ lDgrn5l2fmgoaDCmxwbHS58BnMBZVOn+XrrN5RZR5tAFRiPd+Wcmg79qZYMYD/d+K/iCjueAD93 kncl8iUKDoqNegftPlWc6/fYLM+Q5f3lAb/+1u+he2134M6O6u9vVYKOYxcxDIxfICow0Xi702l h2jDVdJQdlPby8VCiLsJ0J9u5kE7jDiWfna+9mKnj/n0q1kFqUcWc5TmpuApNOObAYPWE74OtZY HIIlQTsZhpYdBjC85rg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170104 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Switch to explicitly specifying the pipeline-name as the name of the IPA to create. This is a preparation patch for switching the default IPA creation to matching IPA by IPA proxy type, which does not work for rpi because the same IPAProxyRPi type is used for both the rpi/vc4 and rpi/pisp pipeline handlers. Reviewed-by: Jacopo Mondi Signed-off-by: Hans de Goede --- Changes in v7: - Add a comment explaining why pipe()->name() is used when creating the IPA Changes in v6: - New patch in v6 of this patch-series --- src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp index 5a5acf6a1..802b2b3c7 100644 --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp @@ -1165,7 +1165,13 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result) { int ret; - ipa_ = pipe()->createIPA(1, 1); + /* + * Explicitly pass pipe()->name() to select the IPA to create. + * The default behavior of creating the IPA by the IPA proxy type name + * does not work because the same IPAProxyRPi type is used for both + * the rpi/vc4 and rpi/pisp pipeline handlers. + */ + ipa_ = pipe()->createIPA(pipe()->name(), 1, 1); if (!ipa_) return -ENOENT;