From patchwork Mon Aug 17 13:40:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27828 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B9F94C3264 for ; Mon, 17 Aug 2026 13:40:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E18096828F; Mon, 17 Aug 2026 15:40:54 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="bQvx+PrN"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WaxayJB+"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 58CDD68254 for ; Mon, 17 Aug 2026 15:40:50 +0200 (CEST) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67HD6DMC1193726 for ; Mon, 17 Aug 2026 13:40:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XF4Z5r1ndQnMtmFBq1N2e98ElZtjBKzKDKMicoKapmU=; b=bQvx+PrNXGBl1ziQ 4r6hd/R2PmGTi7qgk0wXv59imh/7WiQwN7sv1xbK/AMxuRQCJBBXO43J2mbmJ2Pj yRL4fLl+ztHOY+pdhsMMNjhlVWaS0ft6g8p+GxeEtkczlsPpd4h19WO5Kg0RPkSC gJtpA/ymZkaJz0rjzw2m7E6UNvZmI7E0J5UI9Jtd1P3nfdFDLuAvrjiOs+y1C/LH KK14F8eF2NNmj9FcaK3HmshPr7bpFbI9RriAB/hVWl+nt/zzfJeQCav3F+85hUBP bKCF4knd2K1pTWkRDqd/OWDlw+XyTZtS3MO2fR6YDdVuCEf4LTn8zZR06z84jVtT 5+70/A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g3wke1gxy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Aug 2026 13:40:48 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e62e3459fso315009185a.0 for ; Mon, 17 Aug 2026 06:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786974048; x=1787578848; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XF4Z5r1ndQnMtmFBq1N2e98ElZtjBKzKDKMicoKapmU=; b=WaxayJB+FpbjA/tZBHeK9YFtSIrf1dj+wDQ3yL/aKFgzghrWnE/cNuJFdYsClnOiWa g92kj2XUW9qiI+Z8fAie538ta3WcERthmSguu8pGIytseUQIsonitQKJ9IusA/ZCJ4Ed k05PSv1xpzP5AjNaJbh2+c7JYHLjzD15iCKp0N7aCCO95U0Iy7LpYHzriVOzffrsa3Av iqBn4562s3bUoBDVVNT+t6kBpxRKGYNNjf95JJKVkkHuJ8A81F6Sta8mmCeXnwVV5vuK p6JZkMwGS/WsCFzvoBoW455gC2QpoH4gnsltEd088fZLq5X7SLP5TZqAeorIUzyyQQP4 CvXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786974048; x=1787578848; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XF4Z5r1ndQnMtmFBq1N2e98ElZtjBKzKDKMicoKapmU=; b=AsbbXV9iV2j/Rtost92+YUtoQp0H3Pi0coaUcPq1NrF+vrmIRHD57vzHkwMukMCycM qmWvda4eH/Rt4/v+T6dZJzsHB+ZlkZuPOM/s/vOAOb/ze9+ff1rPVnYwSogVrb9i7Ie8 DAajihsEepOsoPl4bq+tmNFfQVqTPYZtArjnyK8Qw6zcBid5OW2pMu+X7UAl7c7y7Tii t7WhF5Up1e/MSrZeDIF37pWUX3X3Mh5lytgr07WBc5r2Ed4aVvj5EYJFSJpJu63ytoer hb2wzpIHSGRNNzSlIV88YDIA6EQtovn7VNuRoO65TvWCypduJeMDrVZW2dJRyKYhC18X ZvXw== X-Gm-Message-State: AOJu0YziqyNMmgoAE8w+b9b9tcqyOQB5cFFC6pN+C13p9FgjrxpTAeMl N1ZubsPGjRwoGi/hs08QKVvVrLDY92jsiqITff45EX4sdVM8EN3Dlydj4LaH7NeTvI/eiRpIIlJ sx/xmKd+o4rzdDsDNyBQF8h7LAN9jWSRqWAIUJH/Cvk5JsIIqwOwn3OFYNSpJmI33Yjnfw1Z1t+ BuWuY47wak X-Gm-Gg: AR+sD13GpB+cI4jzpJudT/UY2csK69KSHtd6fFlR6mJS9gBrqa2Fm3fv8fSB+GYusMy w4giPUhjOBWtbu/Emcz+UwozuaKIA61KVwujP6jmfJUts9Qu3+oT85Q6MgOIHeeUxCEBOCpdr+4 t2PgRuctlQMW5ve/SYHWtR8mzENchPUZnN7AYkGSEvi2RH6Z22uo3pB4SpdrQyP8Jd5DFzlRYQv An8nxg9AKuWcf81sh9XhWJS4ah2yiB9tOXfPkzt56HDn6B41lfooCNybVmM9o7kMoEc+PCys5yi Norck6gTSkze+LNcgdVR561qWpcc3B2pUE6AIOaAl+f6dBPHV1Xyrebkp9HMY/dwLI/sNtKWX8X sdYiJCvvuRipqvkQsVMwS8K2XqxtS X-Received: by 2002:a05:620a:40c2:b0:936:ea40:6ca2 with SMTP id af79cd13be357-936ea407327mr1313073785a.39.1786974047802; Mon, 17 Aug 2026 06:40:47 -0700 (PDT) X-Received: by 2002:a05:620a:40c2:b0:936:ea40:6ca2 with SMTP id af79cd13be357-936ea407327mr1313068385a.39.1786974047329; Mon, 17 Aug 2026 06:40:47 -0700 (PDT) Received: from t14s.vakwerkhuis.com ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a3d8517181sm772179a12.1.2026.08.17.06.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 06:40:46 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6?= =?utf-8?q?derlund?= , Loic Poulain , Hans de Goede , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Kieran Bingham Subject: [PATCH v8 2/8] ipa: ipa_module: Remove pipelineName Date: Mon, 17 Aug 2026 15:40:36 +0200 Message-ID: <20260817134042.277168-3-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817134042.277168-1-johannes.goede@oss.qualcomm.com> References: <20260817134042.277168-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE3MDEwNCBTYWx0ZWRfX7D+6EtIlkjm7 fUQLRB0ZZpmbioUBDViZ5bK03QYTE+JrvvS/jx8QCayvLfdI/dtgKh2g6lfUk34ukLpNzJxPXYS fRflg5We63nVrpZPQGzyP7paYhDZo3borrm3hPt9x+Er3N3u9/bEAgtUf/+vLb4/AXfOmWee4fg 2ZfzriMNGGWTE6iobX7lhZNcQ58w6lnxgGm+Y4FAqq4yP0YirUb7FKRGjuBSRg6byjitZgmdQn0 3fIqfXZqg+cDQ3/BcrAjfpKDkB3NRglAaCaR+Hb9t6SQBN5KRC1gjdPT/y/BIGnYv3Y98P5Wpk9 ZmEv+ps/4S3oGJLQgmQ1ftuSGsur6C2jDA2w33ZbiZM6DjyD8xa3kC9AqYtfa8a4O8S2z5wh4QQ 9SVh8Ah8Zkbnhkiog6xK3Qcga0aWAMoW80571ORcvodpuSXxGdQQp+dqg+wdrIQc5G/vPFyn2xz qQdqc8UMUMgKI0RUu2A== X-Authority-Analysis: v=2.4 cv=QetWeMbv c=1 sm=1 tr=0 ts=6a830f60 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=rrvG0T/C2D967D07Ol03YQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=lvZftHTMWe99GEGio_gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: ey9TYFo-uPchF4NeQ1AclcBJYljKiL1K X-Proofpoint-GUID: ey9TYFo-uPchF4NeQ1AclcBJYljKiL1K X-Proofpoint-Spam-Info: AW1haW4tMjYwODE3MDEwNCBTYWx0ZWRfX8S5GUEu6bctb 79Mbm1SdvKzEx50mPPRNZsrfb/O0ANDSNVMl/ffqOepPbqrgIRLXQc/vgujEWWL3IK8FlThYiSA jC58WohJFB23t0c3jscPfyaizwytrno= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-17_01,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608170104 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Jacopo Mondi All the IPA modules declare a pipelineName that is identical to their name. As we now support creating IPAs by name (either explicitly provided by the pipeline handlers or by using the pipeline name), the duplicated information in IPAModuleInfo is redundant. Remove it. Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Hans de Goede Tested-by: Niklas Söderlund Signed-off-by: Jacopo Mondi Signed-off-by: Hans de Goede --- include/libcamera/ipa/ipa_module_info.h | 1 - src/ipa/ipu3/ipu3.cpp | 1 - src/ipa/mali-c55/mali-c55.cpp | 1 - src/ipa/rkisp1/rkisp1.cpp | 1 - src/ipa/rpi/pisp/pisp.cpp | 1 - src/ipa/rpi/vc4/vc4.cpp | 1 - src/ipa/simple/soft_simple.cpp | 1 - src/ipa/vimc/vimc.cpp | 1 - src/libcamera/ipa_module.cpp | 15 ++++++--------- test/ipa/ipa_module_test.cpp | 3 --- 10 files changed, 6 insertions(+), 20 deletions(-) diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h index 3507a6d76..436ec82d7 100644 --- a/include/libcamera/ipa/ipa_module_info.h +++ b/include/libcamera/ipa/ipa_module_info.h @@ -16,7 +16,6 @@ namespace libcamera { struct IPAModuleInfo { int moduleAPIVersion; uint32_t pipelineVersion; - char pipelineName[256]; char name[256]; } __attribute__((packed)); diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 4bdc4b767..42d475ecc 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -672,7 +672,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "ipu3", - "ipu3", }; /** diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp index da0dbe4b3..37350eb28 100644 --- a/src/ipa/mali-c55/mali-c55.cpp +++ b/src/ipa/mali-c55/mali-c55.cpp @@ -382,7 +382,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "mali-c55", - "mali-c55", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 58ef163d8..e0dde542c 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -481,7 +481,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rkisp1", - "rkisp1", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index fd28fc385..88deccfd1 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -1147,7 +1147,6 @@ const IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/pisp", - "rpi/pisp", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index b6ca44e7a..f30eee7ff 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -633,7 +633,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/vc4", - "rpi/vc4", }; IPAInterface *ipaCreate() diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp index 629e1a32d..d4ab91e30 100644 --- a/src/ipa/simple/soft_simple.cpp +++ b/src/ipa/simple/soft_simple.cpp @@ -343,7 +343,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "simple", - "simple", }; IPAInterface *ipaCreate() diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index 4162b848f..bae48ea90 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -183,7 +183,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; IPAInterface *ipaCreate() diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp index c89887954..6e8513d0e 100644 --- a/src/libcamera/ipa_module.cpp +++ b/src/libcamera/ipa_module.cpp @@ -215,18 +215,15 @@ Span elfLoadSymbol(Span elf, const char *symbol) * \var IPAModuleInfo::pipelineVersion * \brief The pipeline handler version that the IPA module is for * - * \var IPAModuleInfo::pipelineName - * \brief The name of the pipeline handler that the IPA module is for - * - * This name is used to match a pipeline handler with the module. - * * \var IPAModuleInfo::name * \brief The name of the IPA module * - * The name may be used to build file system paths to IPA-specific resources. - * It shall only contain printable characters, and may not contain '*', '?' or - * '\'. For IPA modules included in libcamera, it shall match the directory of - * the IPA module in the source tree. + * This name is used to match the IPA module. + * + * The name may also be used to build file system paths to IPA-specific + * resources. It shall only contain printable characters, and may not contain + * '*', '?' or '\'. For IPA modules included in libcamera, it shall match the + * directory of the IPA module in the source tree. * * \todo Allow user to choose to isolate open source IPAs */ diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp index 1c97da324..af71c3285 100644 --- a/test/ipa/ipa_module_test.cpp +++ b/test/ipa/ipa_module_test.cpp @@ -37,12 +37,10 @@ protected: cerr << "IPA module information mismatch: expected:" << endl << "moduleAPIVersion = " << testInfo.moduleAPIVersion << endl << "pipelineVersion = " << testInfo.pipelineVersion << endl - << "pipelineName = " << testInfo.pipelineName << endl << "name = " << testInfo.name << "got: " << endl << "moduleAPIVersion = " << info.moduleAPIVersion << endl << "pipelineVersion = " << info.pipelineVersion << endl - << "pipelineName = " << info.pipelineName << endl << "name = " << info.name << endl; } @@ -58,7 +56,6 @@ protected: IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo);