From patchwork Wed Aug 12 18:50:55 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27772 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E2817C3264 for ; Wed, 12 Aug 2026 18:51:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8B7D4682F2; Wed, 12 Aug 2026 20:51:24 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="m0eNWyuM"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="atFkWmkV"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 35217682F1 for ; Wed, 12 Aug 2026 20:51:22 +0200 (CEST) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CI8iIJ355282 for ; Wed, 12 Aug 2026 18:51:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= auuMV5to/950KC7buZYUhj0TGUEl75iuMAcuX7bDBY0=; b=m0eNWyuM5McE+SIy 3cjRMU051v6OCxXNAqGnq0Dnkpp68WppHMzKyat0kbrPG7l/pToLG2jep/3uz2qD UoasgofnFKXsfFzq7iGUj2Y+p1iW283UDBFcB/AdGILjHqrSrj2qx1IbtdDYAzup P6efu+H5q6JKQXjFCG6RaZIexS+nWIJD95aKAxWf3eURH0lAzW3KN73nDFsBo5Bb 8arz6W5SQa9Dajcs3vyEnX+02qwR0XuGfsZEKv42ZYe+xDKZqKi4KMJ8aAI2cVMS ublXy6L586EM4JWwWSP08GnUVypD/noNSso9yfk1zbwIdN8xzLUvv5/jZNveOFKy mQsQ4w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj2ur4y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 18:51:20 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92efd2ca21aso233885085a.0 for ; Wed, 12 Aug 2026 11:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786560680; x=1787165480; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=auuMV5to/950KC7buZYUhj0TGUEl75iuMAcuX7bDBY0=; b=atFkWmkV/eX1jPlHCPoG8+WTqTCtBQstpYailEJ7c3sBP0Fns9wyfrrv2DlVm2KiUa nLlTH8s1aeQ9ffwxrmzj86PxRxYt2N+Wpxl0VemklUYc3bq1X4lFiHzzeklWqKHe/K56 ODGb/wSSCr1HY64f8TZ1gOyDsVax7I/rJWHlLTGoK7d8qyW2LBwFd4uGmYv8yABu2YlE iIPtq5G3AwNlSxVJfNqNc40O8vdPOJ+9o0wZzjbT4prZGQz5vpAnb+tyTluM/nGZXRMQ 0jxW8+L7Mmc8fuAvbQBqfEfPF7FxXz64rEgGmAqGl5zOaepu/490T+mfEBY4qnzQknL8 9w9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786560680; x=1787165480; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=auuMV5to/950KC7buZYUhj0TGUEl75iuMAcuX7bDBY0=; b=MPbStvYCETTn07x3/1zPY7LZM7JvQp+lxE4fVS1pwlb9dq7nLJYQIIoRm33ZXc0S/c aBe1WCphS6iCMyhs0/Ck4O1b4PWNKh9tBToGEMuwDT92WvrqL1OqeAO8ADUO+samYHnW fMqtNsDOMC6KBbouSReeF/j+bxYBh1V0An8W2M09rckfphCo0OYIwVMDKyFv/Vq4RFbD +dEUEUwk8GnIIyfanGaQruJKaINSKyYgtUm/DaGyDraS+sfMOl0B+7yn3sJSmID5i6nD U+s71YuSkTd1yqF5kfFolCNiVrVNjteNFjyjr6+eohyKUT2tEWMm45Zdb1XO8/s12mj7 g1Xg== X-Gm-Message-State: AOJu0Yw1nJ1kP0M03hDyl+WGxs5TI3ftQds7hETIb4mryPZm6Y8x8us5 NFGpoMEdgzenMVy5VubSSGjPDdiayuhlsn04+JN8zbsvqPqM2iXb1Slnet2sd5q7+Bs5gW1WxbK +cw1wijXMWv5N5iIHkXg9zrO1K94nqkKnft/VmbVtZnkJml9keNzS5knNXJpIlRoC40Q2yTaiBQ 9rO5lIi5Gm X-Gm-Gg: AR+sD12TZJ+DdNf3w0zvO+6W+Xt/TUADG4ep+4LRHif59aDJfgjS1UJcqz47pRVCqug bKHwt/tVIpSyleagUwTfCEv4IdU4ATk9n2vMp0/6vrM33GLrMOIkK4CaYye7zgAb9II9lMfGcnP nQACaHI9fk2qc7/9vUdScRKjcKvKaZMmjcbPzgcO4Nc+9jdJGWXUmvvoRBFTtjw7Oi/WiTZ8+37 uW6KlQ8T0M1b4prmE65wvHXCby9LHNAFmLo96nonWuZB6+DcnpZwN63mgGSLvr4HJ3QzjVd83zU uenfpcChKhLhOGofhnz+8EJwoR66WaeY21HwhnvAralRtjhxgwoyzZ9Hl1w87Q/kBnRI/EQArid X8ejzO1W/xWBAaoFGh7ijDOkKyjXXgG7/UrAe21cW1PS3hvx/pSeAvfGCslle4t2ZnmUHweTIri zpX03DOHt6YMO2uek= X-Received: by 2002:a05:622a:4a8a:b0:51c:f8f:13e with SMTP id d75a77b69052e-52d73e3c88bmr2587451cf.40.1786560680368; Wed, 12 Aug 2026 11:51:20 -0700 (PDT) X-Received: by 2002:a05:622a:4a8a:b0:51c:f8f:13e with SMTP id d75a77b69052e-52d73e3c88bmr2587131cf.40.1786560679974; Wed, 12 Aug 2026 11:51:19 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a37f8cd810sm47977a12.26.2026.08.12.11.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 11:51:18 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v7 8/8] ipa: softisp: Rename setIspParams signal to paramsComputed Date: Wed, 12 Aug 2026 20:50:55 +0200 Message-ID: <20260812185055.289021-9-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812185055.289021-1-johannes.goede@oss.qualcomm.com> References: <20260812185055.289021-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=a8EAM0SF c=1 sm=1 tr=0 ts=6a7cc0a8 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=X9iWcBBwFAc5_HUTaPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-ORIG-GUID: 0jAHQmR9H_cwqn25gZALM1E6b0tPsASz X-Proofpoint-GUID: 0jAHQmR9H_cwqn25gZALM1E6b0tPsASz X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfX6IjUl95z3r4Q v2nHbXtauFUPeJUU5xUqgZKi0kPmwXqc1yYfvQyg2nxJckKKIalrGcFwdGUJoANit4YhrEJOQDq Z8k0A1lihMqxdzucg60NobC+h4EVu6o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfX7cr0O4tbsLZ1 +5UyL6OZoigaaBlyAf5e1+PeKTP5r1T2f4xEJc0Ip8y6ObUq+r3daexe1LIjb91BnLd70BcGoE1 XX1pTky/kkkeDR72LWsWnhGqokJrvv9mCqvnGMW1/wh14QtusdGCDFhMED0ks5LQeAFCz1BRX8M FVeqrMzjNmdjzrxUoq3Q5TAWurZo2W0+JDsUmNxG59QW4z1uTTErqQioByXwYSZUspAJknXP8Wh f5ynd2BYRxGfxdmxQQhD6MK7gmKX5C3kOCsPiioIZCpJmjM5GXynU9vwqubRCycA+6XpM8jmadx 909qzdiqSZT8QD9YvXQDBIJat/dBA4R+JyxTZBgJEbUXopENs8s73t/QV20Ti/IRPPQujZtqVmW tj0USUJZvcuQSo1AFbUTky0N+/kjH7p9TpzPsKpJXS0X/tWZ80pvv9tZCwkoDsG8KcWM0D3U9sx 8RKJ9qvJ/Bw5t/W/vOA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-12_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120151 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Rename the softisp IPA setIspParams signal to paramsComputed and pass the frame-number as argument to make the softisp IPA behavior consistent with other IPA implementations. Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze Signed-off-by: Hans de Goede --- include/libcamera/internal/software_isp/software_isp.h | 2 +- include/libcamera/ipa/softisp.mojom | 2 +- src/ipa/softisp/softisp.cpp | 2 +- src/libcamera/software_isp/software_isp.cpp | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h index 64c77e65c..da893d242 100644 --- a/include/libcamera/internal/software_isp/software_isp.h +++ b/include/libcamera/internal/software_isp/software_isp.h @@ -89,7 +89,7 @@ public: Signal setSensorControls; private: - void saveIspParams(); + void saveIspParams(uint32_t frame); void setSensorCtrls(const ControlList &sensorControls); void statsReady(uint32_t frame, uint32_t bufferId); void inputReady(FrameBuffer *input); diff --git a/include/libcamera/ipa/softisp.mojom b/include/libcamera/ipa/softisp.mojom index 55b6e4d7f..a892d84f1 100644 --- a/include/libcamera/ipa/softisp.mojom +++ b/include/libcamera/ipa/softisp.mojom @@ -33,6 +33,6 @@ interface IPASoftIspInterface { interface IPASoftIspEventInterface { setSensorControls(libcamera.ControlList sensorControls); - setIspParams(); + paramsComputed(uint32 frame); metadataReady(uint32 frame, libcamera.ControlList metadata); }; diff --git a/src/ipa/softisp/softisp.cpp b/src/ipa/softisp/softisp.cpp index b3f0d3fa6..aec04c528 100644 --- a/src/ipa/softisp/softisp.cpp +++ b/src/ipa/softisp/softisp.cpp @@ -292,7 +292,7 @@ void IPASoftIsp::computeParams(const uint32_t frame) algo->prepare(context_, frame, frameContext, params_); params_->combinedMatrix = context_.activeState.combinedMatrix; - setIspParams.emit(); + paramsComputed.emit(frame); } void IPASoftIsp::processStats(const uint32_t frame, diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index f29f78c98..ae86c20a8 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -171,7 +171,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, return; } - ipa_->setIspParams.connect(this, &SoftwareIsp::saveIspParams); + ipa_->paramsComputed.connect(this, &SoftwareIsp::saveIspParams); ipa_->metadataReady.connect(this, [this](uint32_t frame, const ControlList &metadata) { metadataReady.emit(frame, metadata); @@ -432,7 +432,7 @@ void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *outpu ConnectionTypeQueued, frame, input, output, debayerParams_); } -void SoftwareIsp::saveIspParams() +void SoftwareIsp::saveIspParams([[maybe_unused]] uint32_t frame) { debayerParams_ = *sharedParams_; }