From patchwork Wed Aug 12 18:50:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27768 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 15BE0C3264 for ; Wed, 12 Aug 2026 18:51:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B4363682DE; Wed, 12 Aug 2026 20:51:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="jp8dralr"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U0y1v6nc"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2933D682DA for ; Wed, 12 Aug 2026 20:51:11 +0200 (CEST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CI8mAp277573 for ; Wed, 12 Aug 2026 18:51:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tALQ4WPF1H+ xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=jp8dralrUHwHZN90ClTnubCRNpD MK69n+nP+lsB1Vw1HdKeSnTn0FcB6nYsEgUYWE9+D5uUAMfR4Y1a/PWaag3p4PkG GohzKF+3BRiIhlWBNGFxXTBb3R99jQu9yFr15+ty1CWjO6FVgy6CQTTZ1Im5rZq1 bWx2TF4BL/r3qXTxMsqLkeWGWS5FlI7L3gl6ygsb0+XWpIEvcrXSCw4gVtFj7yAa A5lVIxEK55WTUD8Ek2ZbDG+klkcPYcSYNlqoJ+bVMKsXubKY3n4vCIIZXDqNlB00 z9FsXEDdVmyyW/vr9++VFFDlFEBinA8w5ELX3mkWDU/G3ZIbPFN6f00gw7Q== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj1kqnf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 18:51:09 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c01ff996dso19446401cf.2 for ; Wed, 12 Aug 2026 11:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786560669; x=1787165469; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tALQ4WPF1H+xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=U0y1v6nck4YPaXCl45g42HSWmi4RPuNvm+HJwAcuKDnP0nhv8Kf2IC9a868Q0qflSV YjY0BMrWBZJf2Q2cWmkj4JqmUmlfPi4P7gYC3l+Zq8gXOicKC+wafIj0Z5j9q1z2q+Ru 3Z1WrSZ0Z6Xk1ZqaGt/GtRpZ/2bgH2p8IpBS1UxvGVe3Sdtanehx0+oZ/OXkRTHLtcz5 KM8T4qiL9RUHu2nOI5gfwiEduszu/QDEWgmmEYtTI+K9UMGobWUaSUoDZ0VZ5cuAh/YS 82/ZJKVlVZeXhzAsvijhzrJGFsqhHf6LiJINuBkSW49Cq0ajrcJdsy6xEuC1hCELVboX vtgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786560669; x=1787165469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tALQ4WPF1H+xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=DZjqliZoKFRq0Be0o1SrjUJ5C5f7BVE435ITf4YW8OVRBO+2EyyZN00knTTsY01r5a tn1pI43O/Gk76J+k1eL+L02+OvHNmslDl8cP2ekgUiAUad4jIpSXNVsylGZCTLJeqReN wf3H8/yWxBGThoKKBgR+rXLgJ0yW/LZyweqU/jqWiLzM4FnKpd+v4Groc+fk5g0vKhiu QqDP5saW2K++sob1ex8649dWTPYzr1Ymt7JAYpchYTJmzpmlcItfskahFrP9hXPq4ck2 ntanAkq2cyQbIrWn8LiThuAHYl0Im/wPDe5q/oK3ZB0uEaJ6zpENbyobKLp2lPm5j0HH 7VAg== X-Gm-Message-State: AOJu0Ywssg2NLUj9GfrYL6efPnxF4WKl1Q6HPulm11STQEXo1BDHLuD7 gPjlo3OZTrUgPE5QQaifLchOw78V83/9lcSgVWAOk4vch9QF3xpUx+qsSl/8DsqZcqcqVShxLjH nzqjoZ4TEQv1zdLCS3gyoR7tI8S2FEFjmHocDX9pOu/1/lG0dAysusieVDmhMUDJh2PrZypHmby s5gTxmmHBM X-Gm-Gg: AR+sD13zRIqE4y+mAxKKV0d2DC23lJpR1HUpWDTNIQ/FB7jG62pswl+kC5g9ZhyEgTj sJToYHzjT4FY3j+KyQ5rRBJ7RbS9szys+BhT5rDtMho3oFM0wBFQiHoe4GZGq/7YiSSuA+EiGsS wAZ4uANlrJ+wkRQ/GqD5kGU7W7OXMf8SEvDBY/d/I9gROEE57/WLg3bhBvF3ELrI5c1o4UEaJdv 9VSh6avdOvYmrzxIEggqSkPoq4gJ+b+5HFHGjD/Olus+CigDJiY/8Vjf3CuCF4ypydMFL2LeimK pkdW+yb30xsb2Krbz12Ih/L+AbCbSciaF9/ol555U1NCfDVLl4mJuwhZv4yf5bSpYTg0zxY5HXe Q52dtkxRP42/WHw9BalPIRSPPL+kaYu9ONM7FGha01iDtNRrQTxQ5Hg8vAqNjRLYznFH1nVkOUl AcP5XbYwHC3hTdqlg= X-Received: by 2002:a05:622a:1903:b0:517:9c91:6246 with SMTP id d75a77b69052e-52d73e55e77mr1813891cf.44.1786560669095; Wed, 12 Aug 2026 11:51:09 -0700 (PDT) X-Received: by 2002:a05:622a:1903:b0:517:9c91:6246 with SMTP id d75a77b69052e-52d73e55e77mr1813561cf.44.1786560668633; Wed, 12 Aug 2026 11:51:08 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a37f8cd810sm47977a12.26.2026.08.12.11.51.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 11:51:07 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede , Jacopo Mondi Subject: [PATCH v7 4/8] pipeline: rpi: Explictly pass pipe()->name() when creating IPA Date: Wed, 12 Aug 2026 20:50:51 +0200 Message-ID: <20260812185055.289021-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812185055.289021-1-johannes.goede@oss.qualcomm.com> References: <20260812185055.289021-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: Wt9_DUMJd-24ukRjZy3s6OCJhNTKABzj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfX4XTEEJug0Wqt NseFZy7pZOSe9s7nG4TqMO3n/p/BtYloCsJZQ4mAwd1K1VPEhQjDVja/xYd91f4G3NRuWQ0cXEx sEfte8W+SXQcRMN7Fqw6kmGrvZi76YEO5BzqBUjg78qpHaGSf8HaULguncq3ePSYsrdUMPVKwI5 NQ5beRpg4KHmbYBZPYWQ/DYgepUMRVMWYxZaNy/idyVJkRoeGMmeZdqlsaafgtB731ycLGFzJ7f w0Fn63IBxklDsqOM4ITj+0CaD5CbBYsSB+Vyuj7vv38xkjtxDdROQC41LD+YQsCFPZeFkoXsr0B HOBiJF6RMD+fNY4bK1qxAXfTa9Voc/d1VN3V/w+6tuf/yonoNeHKbHY4PATvCg6NKVjIvSA2FvO u8+ud/2OcYxUm9r9Q8f/toeFPT3KiKh3SGLcd5/cMjdEVWra6CixZZ9r6PK1cjMSRathYdSbEh8 JbFXM0R3B+FBojYYzMg== X-Authority-Analysis: v=2.4 cv=K6ES2SWI c=1 sm=1 tr=0 ts=6a7cc09d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=PI23gj2s8gul_AyujO4A:9 a=a_PwQJl-kcHnX1M80qC6:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: Wt9_DUMJd-24ukRjZy3s6OCJhNTKABzj X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfXwOJw2LS/edfH lIJ7TnnV9r3Lijpxk2lcaULkjK/mXHIwK5WFMeR+jB3KXPKdW+jYctgL/dEHiv1ulzx+27r0X9F OFkFBcNJLic6FfrBF1sKLOul+FA4dgo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-12_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120151 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Switch to explicitly specifying the pipeline-name as the name of the IPA to create. This is a preparation patch for switching the default IPA creation to matching IPA by IPA proxy type, which does not work for rpi because the same IPAProxyRPi type is used for both the rpi/vc4 and rpi/pisp pipeline handlers. Reviewed-by: Jacopo Mondi Signed-off-by: Hans de Goede --- Changes in v7: - Add a comment explaining why pipe()->name() is used when creating the IPA Changes in v6: - New patch in v6 of this patch-series --- src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp index 5a5acf6a1..802b2b3c7 100644 --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp @@ -1165,7 +1165,13 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result) { int ret; - ipa_ = pipe()->createIPA(1, 1); + /* + * Explicitly pass pipe()->name() to select the IPA to create. + * The default behavior of creating the IPA by the IPA proxy type name + * does not work because the same IPAProxyRPi type is used for both + * the rpi/vc4 and rpi/pisp pipeline handlers. + */ + ipa_ = pipe()->createIPA(pipe()->name(), 1, 1); if (!ipa_) return -ENOENT;