From patchwork Wed Aug 12 18:49:08 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27763 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D7B41C3264 for ; Wed, 12 Aug 2026 18:49:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 79B71682C8; Wed, 12 Aug 2026 20:49:29 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="h3SSPc1T"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LuArBbWF"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5B2B5682BA for ; Wed, 12 Aug 2026 20:49:27 +0200 (CEST) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CI8tPf382673 for ; Wed, 12 Aug 2026 18:49:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tALQ4WPF1H+ xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=h3SSPc1Tnn1C7Yi4FD3Vj3cDjPv jJ1bXBMSvMCuM/e20gqW3jIReS6XOj69ZSvBQBqL1EBcHFsgYFN7ymF2le3snS5x IwBhuxjyYtsp5LS5qTJhUdDzjMcoBDE6vlSRbffCoE2ad6BGJG5x7mNU7ZWEoEnR vf448jN89mW24T0b7tl8fx8bjuI/NcFIlH4gYhzVhH9jKpXkps4g16vs/8Kp4DRo hHpHEC6lCSImW6IDnLeeFG+LgAO8WwsA63aJZIXcuvobQKukvoTfQ5fPkLmKIJjt pLoHgwS+18wOj30/mdVOckt1URwUM+Pzicc2QP0ie3i6T+355GwnOqWDCOQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0jgrkfyq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 18:49:25 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1d7886cdso23024721cf.1 for ; Wed, 12 Aug 2026 11:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786560565; x=1787165365; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tALQ4WPF1H+xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=LuArBbWFv4v8uJWF9tSJuNnSFhJLHyIwfcXYkRzkNlw6q5gASaqjnHn9u8/BCnVnO5 sQmSypR/uLtJVnVPTs4hWMyhuqozxzcsizjy33ix5PEBH3bnByhR/0OskUQszeIhvkJd qb6j+bQLzWmuX6Co+1CIPbk4jiebVoKlr8Wob2ksX6s1sclaLmQP5C/qm1sJDFbObj3e HHDnhDCC+/U/XEs7jtPitZdbPwnjTagYNoHvDHoHN28O/4jfPwJpVLBAzRVra1Wx0B7B G4CrM7JGKyuC/PUUjfyCFmj2K4+6H1f0Cp6XU2xoS+dtS3ERU+NnZ19qB20z9CA04cpW G+mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786560565; x=1787165365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tALQ4WPF1H+xoBX9ywuRNg2hINLBVBQkINtnqbyHhYA=; b=CHkoS4u37t9uPr0R+jis6YZHloNi6nm8F1Spka24tKn0oyZggA9Jz1z0aXKw7LThWX 9+5I/qpWu2+UnWMS7wkIJH7d8SoZ2CSrNj0wMwM7/TwtJDBbMmCbaGZyYUr9t/wRxOwH fW7GX7gfvf9I6/ESwGvgoDQW7Dmd1dnUXmhkXESHcpwpgziapto2863hBz1b+lSeqV5O Jl2vW1c8hrWFyjAOJE3CsenKp6VeGv30Jp2w+OFB3ZQScCtnckg1vMvdGZQi4EeLdPIk NmERrLe6+gjDa3XjmkT5emlpYlWTEqDlyFbzvdNssqW7zIq6z9O22tHph1wypOQlc2U/ l/zw== X-Gm-Message-State: AOJu0YyWmpfwmwtb7T0Pr2Fsxy6sKE4Cs/zfWk5GmaMY2JVeMcl9w9fO Mt7LuYVlELdfskZusH2hBuRw+MU4cXw5Xrvp2X4RH4hIzDQ6dTEAN4zkSmUisUoqbfB0RrfSyWz dcWldwrLFBReApitjBEgJU5Vtj940CQvR2ZJ0exhVz60KZ6d58NS/blyQgE3KKZPaZUcxlYIAgX 1w1OWUECV0 X-Gm-Gg: AR+sD11jRZgU8aBvrL02A1U/y031faRLHq2WRpejULHxuIjcR62BFC5pyECXgiyNZFv AVIxrtjpbA+f51YvXY1f2VawyAdopR4nSKBRRBYEjXSETFX78ZxHgUEmvtSRkdrXQ+wQIPoI+Cq NMaMTtRoXZfyjYgQVyGrFTBjvCu131f97iFcP50A98wCEL9lQxiUPS2IhTpWQC19x18ZA1YKvGy yw6dHiTadUIGBnklr1bTr3avjrRTbVxlADjmJO8fPVr+6V+K3nQL9W4t2Y6+8K66ve0y/sIv1O7 exPeI+L/SsLkJhHPkX+fq0FoqY3oLp40Y/vUi1MCmT1YGq2FnglA3kCxeDjmcvBmex+lOqs5oq5 IXDiecV3LF6b/MBU4CtosvZDB2caxMQDJhNrdsvrBPzo/a4WOijgiMW8+zKqjoO0D/qdz+tXkPf hzTOTNTm2b7FqAE+8= X-Received: by 2002:a05:622a:4c0c:b0:51c:849b:86b with SMTP id d75a77b69052e-52d73e744cdmr2335691cf.43.1786560565247; Wed, 12 Aug 2026 11:49:25 -0700 (PDT) X-Received: by 2002:a05:622a:4c0c:b0:51c:849b:86b with SMTP id d75a77b69052e-52d73e744cdmr2335401cf.43.1786560564909; Wed, 12 Aug 2026 11:49:24 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a37f8a202fsm52348a12.15.2026.08.12.11.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 11:49:23 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede , Jacopo Mondi Subject: [PATCH v7 4/8] pipeline: rpi: Explictly pass pipe()->name() when creating IPA Date: Wed, 12 Aug 2026 20:49:08 +0200 Message-ID: <20260812184912.287894-5-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812184912.287894-1-johannes.goede@oss.qualcomm.com> References: <20260812184912.287894-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfX3+iUB6Drnf6T DsMyHuosox51Z5zfeIznXVHrGEpvYt7nBMDM8wGLq9fXO0e/MbtuiOLIZfP0pQH0TB8wLeCc9LU NZQ6XbX42muIn4kLVK9IBm+Z9iP4phHLXbp0r6CmRJAg5SY9jEvrpU0izufP0urw4ANI3fjLnvc 4hsqx9JUHdh524LfL255uAnv9lADAODOvc5KFSP6nckSBrUPqNFxtgm3PkQHixYEPHzXpQsPUc4 QNot2FS1WkpQqtJem0OMXDW89MleZ6I/JjbyLShZb08SfCSu9t2T4EbeJxxbZAvpUSL4bVUbt9k qrFmBCbjmBGN6u9Q9cY67lavTV8viQq+1OHdW6HOA8q8DWGt+C+RnWtXN2eADArSRqJRtPbthIj myJgIz9KSU5ezXAu2ZMRuydD0/eSA6JwmW7bw1GR61Aq56qDQ/FPHNAEy5rgGWSkacB5GbDE0hU jyzHcCocaS2sr3Wmxew== X-Proofpoint-ORIG-GUID: yCH2N4KDQb9UMxv50R4FU2fB_prlWNbP X-Authority-Analysis: v=2.4 cv=TNJ1jVla c=1 sm=1 tr=0 ts=6a7cc035 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=PI23gj2s8gul_AyujO4A:9 a=kacYvNCVWA4VmyqE58fU:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: yCH2N4KDQb9UMxv50R4FU2fB_prlWNbP X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfX+5ndk3rGj3IU 1od/S5reTScKW22xZDXFTTOCnSt+5bJUG6hbIlJCzgreC+zUwHBh1apy+ha3S/BD3DklfOd5v6x D8d9U041+fe18J3MkPWYyBMBPWqoGjE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-12_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120151 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Switch to explicitly specifying the pipeline-name as the name of the IPA to create. This is a preparation patch for switching the default IPA creation to matching IPA by IPA proxy type, which does not work for rpi because the same IPAProxyRPi type is used for both the rpi/vc4 and rpi/pisp pipeline handlers. Reviewed-by: Jacopo Mondi Signed-off-by: Hans de Goede --- Changes in v7: - Add a comment explaining why pipe()->name() is used when creating the IPA Changes in v6: - New patch in v6 of this patch-series --- src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp index 5a5acf6a1..802b2b3c7 100644 --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp @@ -1165,7 +1165,13 @@ int CameraData::loadIPA(ipa::RPi::InitResult *result) { int ret; - ipa_ = pipe()->createIPA(1, 1); + /* + * Explicitly pass pipe()->name() to select the IPA to create. + * The default behavior of creating the IPA by the IPA proxy type name + * does not work because the same IPAProxyRPi type is used for both + * the rpi/vc4 and rpi/pisp pipeline handlers. + */ + ipa_ = pipe()->createIPA(pipe()->name(), 1, 1); if (!ipa_) return -ENOENT;