From patchwork Wed Aug 12 18:49:06 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 27761 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E0D70C3264 for ; Wed, 12 Aug 2026 18:49:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8A617682C5; Wed, 12 Aug 2026 20:49:26 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="aUGczqV3"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TK7GtkxW"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AB3BA682B6 for ; Wed, 12 Aug 2026 20:49:22 +0200 (CEST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CI8mAb277573 for ; Wed, 12 Aug 2026 18:49:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XF4Z5r1ndQnMtmFBq1N2e98ElZtjBKzKDKMicoKapmU=; b=aUGczqV3gZ7NPYC1 QPuGcK+gGRVO92pKoatPRmeWrqWoXTnDMnXe+0AG5C+l7RizQKMDfgrgtVADdncI wSZxjuD+7p8gcd5bLqi7YnV+GoiCkc3XslJ9QRFIhG1vtPVScUR+U1A+ExpklOfq XnPSP74rB3aClZUjE94gtDLu1DHTwQHQmY5zplZIfApycW6F8xfut9X2ZZB2v9kB JYGugWC3trgBoGPypHcp+eF3btJpFtV9v9DE1hwbKym65GKmxiUONACUoguYwcp8 jBeDjsa2d/e0iLlXB+Xay8X8bRsimv1wa9DxEUXrPUqx+RruHmPf45oEYCYzDicy oLCO4w== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj1kqb7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 18:49:21 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52ce3c7cb2eso22745141cf.3 for ; Wed, 12 Aug 2026 11:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786560561; x=1787165361; darn=lists.libcamera.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XF4Z5r1ndQnMtmFBq1N2e98ElZtjBKzKDKMicoKapmU=; b=TK7GtkxWHJUNCuOywnKNDgYcGPSFes03G8Rj9qM/n/bwPp/TblUYOQGJOCghQbULuc asXyWxOPsTrU3AJTqC7XU2V55rYs2Bcn6zR89VvtpMDxBLDE95ni+4ALfCNHO6iSof7Y L9p7f4W0Ku7DFAZ0SbdDhE7nfJto3ZtNs7BjUhRprq+qf+LRjNsalLfQKMPpHytSM1Xs boGuDOvXxZ5AnvbN0AYkclTKSlw8ST4X2pI8rKp1vVZitfitwKQA1rMwXA3KxIVbtwYc GlH73eMviyQHVVxgjSCtGdBk6pVCHg+xgUni/aJVpie4INDoF+FOXADhG2vufyEjHciP zQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786560561; x=1787165361; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XF4Z5r1ndQnMtmFBq1N2e98ElZtjBKzKDKMicoKapmU=; b=bOB7xGb1uM5VswHtT8XKCCuNSo9aP146ASVngbGbrjZc9/vmemsojvckN+xxB0tjT4 G8F8c3LuVEfnT8qYFlme2WPcKxvKLCNIFXks7FiSWuebGa1ZDxrQUrbb1vDWmp86jvtf AzM13NzQU5nWdVzbHDyb8MvSt6pWkYLsZWVooCBjp7lZ9gFztuYH4XaUhVA9kZXbY8dy aUeeAEdzlBwZ+9aBAEp7xnI57oH3QuA/XQlwpwauRuWoht/I/h4hZS7LYs14ldTIZIll 77P8Mqm4AJPYe6Sg/yfS56+i34lHhKqoEZuE7ZnyCBEAiktYKwpUoU5Vg/dPDVKR0v61 nOhA== X-Gm-Message-State: AOJu0YwLflNGKa1gTRxZUyCyHd4H7yDAPq9FuuszWdyRq91v4gDxrTmw 1YamtZWwogqRFpQsAgpWGKBfF7hFlirdIr2RyzTrxdwo4S70bX4JkkpDiDPFGroMV3hEcUNjKMk M41B9ILKeBIz19OkBA22ea5x/JN4buq4VGtM1WX54enM3j+OgpHydICEoOBTppYMtTNUPc/bxo+ c2AlNzMfGT X-Gm-Gg: AR+sD13EFYXQ4pFozOGoPGObPw+pjuLbqxaR0EW9Mb4fopjE+7EWKIgXOdcvC9M9rIz x882eZS/qxRPNCyKVY3tGm9HbxBxv15s8z3SvKgX/4TA5oQcw2suwzBl3NHcgUT5synDydrg7y8 1GIRiJ9PdaS4iqjCDJkOePUAfRHy/g7534Sm8LevlvI18Bg4kLbMFTCwDq1TPJhbrnUUomBBpeT T5le0W0N7t6U0oDYICdU1REdedzWlV2rJCeQ4Rs4fzQb4UVAzmPMyFV1UmTW8scxGY4w230Vj2a YK18gSzM6sZzRXrMBO+I0d5PXG9nblZYjTSWRh1BmO6Pc0ACX2e/h7geUSRAW+a9MP/InJynm2h ycwy1n54/Xc2gTY++8vy04B6RT4/KtlBTtjt6yIP3NAYa/M/zDkwGE7tYgO1pOykqIjKPspjWO6 6DO0RUofUDmkVr7Yc= X-Received: by 2002:a05:622a:164d:b0:519:5680:1b5 with SMTP id d75a77b69052e-52d73d2af57mr2593241cf.21.1786560560677; Wed, 12 Aug 2026 11:49:20 -0700 (PDT) X-Received: by 2002:a05:622a:164d:b0:519:5680:1b5 with SMTP id d75a77b69052e-52d73d2af57mr2592871cf.21.1786560560251; Wed, 12 Aug 2026 11:49:20 -0700 (PDT) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a37f8a202fsm52348a12.15.2026.08.12.11.49.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 11:49:18 -0700 (PDT) From: Hans de Goede To: libcamera-devel@lists.libcamera.org Cc: Loic Poulain , Hans de Goede , Jacopo Mondi , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Kieran Bingham , =?utf-8?q?Niklas_S=C3=B6derlund?= Subject: [PATCH v7 2/8] ipa: ipa_module: Remove pipelineName Date: Wed, 12 Aug 2026 20:49:06 +0200 Message-ID: <20260812184912.287894-3-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812184912.287894-1-johannes.goede@oss.qualcomm.com> References: <20260812184912.287894-1-johannes.goede@oss.qualcomm.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: fS8oNjnWLngiQ2IHTiFnL1P60VIPySD4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfXwBOrtP5XC5zB j97VbGtrZS7T4kgb0vVWXV2/WTTeApupgIqZv1zdG1IM9ppCrcPLd8nWW1H/fNq0x8e3emMIwkn qPv11lLCsJ6wm//2Puc9vweYIAZUOmaXW3dML/HZoXMNIXJCSqF+0YrUwYnNrxYZQpsJ7IUOAUO K5W2nEK2LRgDhPW4eeVgeYZ8sehhfe56WurDocC8+dvfcNIjI++uDe9tPFemG2TjC7y5iOuWtDb zy+Rb93TBWsqyNZD53qrNDWmwM7XtfgomMOOXu3diuDK56PxWk8PhE91FU+mEtwS4wmqMdjTarE iyrLBJqSxxuwv9xd9LE5lUGPs5dsf0XcHT12DsTfnShfsJxakzB05qGp7CIeVC63BoCdwyKlgG0 bo3bMnAMKpZ5C+mjgfxvq+O30xNFMqkNxGLMrYm9TZoRpYA1DSOd6g8aRFwNFQXEnNqHxzx8AVk U1zoRAs639t6rK5+hSQ== X-Authority-Analysis: v=2.4 cv=K6ES2SWI c=1 sm=1 tr=0 ts=6a7cc031 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=P1BnusSwAAAA:8 a=EUspDBNiAAAA:8 a=lvZftHTMWe99GEGio_gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=D0XLA9XvdZm18NrgonBM:22 X-Proofpoint-GUID: fS8oNjnWLngiQ2IHTiFnL1P60VIPySD4 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDE1MSBTYWx0ZWRfX9GQf1hRik3Jg bk6qJWvSPR0jirWeky1SNHYMfrt0L6kaAEuJE8BI0E7aQXPhJFFJwHdar9+7qUatutsIKJx9HPK ZDMqCNOJ7WZvYvOJV1MAzZbMDav3+jY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1176, Hydra:6.1.134, FMLib:17.12.100.49 definitions=2026-08-12_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120151 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Jacopo Mondi All the IPA modules declare a pipelineName that is identical to their name. As we now support creating IPAs by name (either explicitly provided by the pipeline handlers or by using the pipeline name), the duplicated information in IPAModuleInfo is redundant. Remove it. Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Hans de Goede Tested-by: Niklas Söderlund Signed-off-by: Jacopo Mondi Signed-off-by: Hans de Goede --- include/libcamera/ipa/ipa_module_info.h | 1 - src/ipa/ipu3/ipu3.cpp | 1 - src/ipa/mali-c55/mali-c55.cpp | 1 - src/ipa/rkisp1/rkisp1.cpp | 1 - src/ipa/rpi/pisp/pisp.cpp | 1 - src/ipa/rpi/vc4/vc4.cpp | 1 - src/ipa/simple/soft_simple.cpp | 1 - src/ipa/vimc/vimc.cpp | 1 - src/libcamera/ipa_module.cpp | 15 ++++++--------- test/ipa/ipa_module_test.cpp | 3 --- 10 files changed, 6 insertions(+), 20 deletions(-) diff --git a/include/libcamera/ipa/ipa_module_info.h b/include/libcamera/ipa/ipa_module_info.h index 3507a6d76..436ec82d7 100644 --- a/include/libcamera/ipa/ipa_module_info.h +++ b/include/libcamera/ipa/ipa_module_info.h @@ -16,7 +16,6 @@ namespace libcamera { struct IPAModuleInfo { int moduleAPIVersion; uint32_t pipelineVersion; - char pipelineName[256]; char name[256]; } __attribute__((packed)); diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp index 4bdc4b767..42d475ecc 100644 --- a/src/ipa/ipu3/ipu3.cpp +++ b/src/ipa/ipu3/ipu3.cpp @@ -672,7 +672,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "ipu3", - "ipu3", }; /** diff --git a/src/ipa/mali-c55/mali-c55.cpp b/src/ipa/mali-c55/mali-c55.cpp index da0dbe4b3..37350eb28 100644 --- a/src/ipa/mali-c55/mali-c55.cpp +++ b/src/ipa/mali-c55/mali-c55.cpp @@ -382,7 +382,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "mali-c55", - "mali-c55", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp index 58ef163d8..e0dde542c 100644 --- a/src/ipa/rkisp1/rkisp1.cpp +++ b/src/ipa/rkisp1/rkisp1.cpp @@ -481,7 +481,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rkisp1", - "rkisp1", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/pisp/pisp.cpp b/src/ipa/rpi/pisp/pisp.cpp index fd28fc385..88deccfd1 100644 --- a/src/ipa/rpi/pisp/pisp.cpp +++ b/src/ipa/rpi/pisp/pisp.cpp @@ -1147,7 +1147,6 @@ const IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/pisp", - "rpi/pisp", }; IPAInterface *ipaCreate() diff --git a/src/ipa/rpi/vc4/vc4.cpp b/src/ipa/rpi/vc4/vc4.cpp index b6ca44e7a..f30eee7ff 100644 --- a/src/ipa/rpi/vc4/vc4.cpp +++ b/src/ipa/rpi/vc4/vc4.cpp @@ -633,7 +633,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 1, "rpi/vc4", - "rpi/vc4", }; IPAInterface *ipaCreate() diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp index 629e1a32d..d4ab91e30 100644 --- a/src/ipa/simple/soft_simple.cpp +++ b/src/ipa/simple/soft_simple.cpp @@ -343,7 +343,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "simple", - "simple", }; IPAInterface *ipaCreate() diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp index 4162b848f..bae48ea90 100644 --- a/src/ipa/vimc/vimc.cpp +++ b/src/ipa/vimc/vimc.cpp @@ -183,7 +183,6 @@ const struct IPAModuleInfo ipaModuleInfo = { IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; IPAInterface *ipaCreate() diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp index c89887954..6e8513d0e 100644 --- a/src/libcamera/ipa_module.cpp +++ b/src/libcamera/ipa_module.cpp @@ -215,18 +215,15 @@ Span elfLoadSymbol(Span elf, const char *symbol) * \var IPAModuleInfo::pipelineVersion * \brief The pipeline handler version that the IPA module is for * - * \var IPAModuleInfo::pipelineName - * \brief The name of the pipeline handler that the IPA module is for - * - * This name is used to match a pipeline handler with the module. - * * \var IPAModuleInfo::name * \brief The name of the IPA module * - * The name may be used to build file system paths to IPA-specific resources. - * It shall only contain printable characters, and may not contain '*', '?' or - * '\'. For IPA modules included in libcamera, it shall match the directory of - * the IPA module in the source tree. + * This name is used to match the IPA module. + * + * The name may also be used to build file system paths to IPA-specific + * resources. It shall only contain printable characters, and may not contain + * '*', '?' or '\'. For IPA modules included in libcamera, it shall match the + * directory of the IPA module in the source tree. * * \todo Allow user to choose to isolate open source IPAs */ diff --git a/test/ipa/ipa_module_test.cpp b/test/ipa/ipa_module_test.cpp index 1c97da324..af71c3285 100644 --- a/test/ipa/ipa_module_test.cpp +++ b/test/ipa/ipa_module_test.cpp @@ -37,12 +37,10 @@ protected: cerr << "IPA module information mismatch: expected:" << endl << "moduleAPIVersion = " << testInfo.moduleAPIVersion << endl << "pipelineVersion = " << testInfo.pipelineVersion << endl - << "pipelineName = " << testInfo.pipelineName << endl << "name = " << testInfo.name << "got: " << endl << "moduleAPIVersion = " << info.moduleAPIVersion << endl << "pipelineVersion = " << info.pipelineVersion << endl - << "pipelineName = " << info.pipelineName << endl << "name = " << info.name << endl; } @@ -58,7 +56,6 @@ protected: IPA_MODULE_API_VERSION, 0, "vimc", - "vimc", }; count += runTest("src/ipa/vimc/ipa_vimc.so", testInfo);