From patchwork Mon Aug 10 10:59:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 27724 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CE82FBE080 for ; Mon, 10 Aug 2026 10:59:53 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6DC786820C; Mon, 10 Aug 2026 12:59:51 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rC7yKdGj"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E6B6681B4 for ; Mon, 10 Aug 2026 12:59:46 +0200 (CEST) Received: from pb-laptop.local (185.221.141.208.nat.pool.zt.hu [185.221.141.208]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 903D282A; Mon, 10 Aug 2026 12:58:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1786359512; bh=elkYYkqX+KHuYeIDySAqaqyXgsXWqVYcCep+RijFu/4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rC7yKdGjaZ2D2JssshhYdQPUiuOLhC65p4oGLZyZVguHTNXzzKtcVYpKSJn0Au+bS dZGIXUiJgkSmtlZ5Dhw7lBLtktO/DetN+dyjjBmITORG4VjF9T38Op/gQUtB2tkvD1 RhBEObFBoioXCJ8DbcK3TBL3HVbqMEP43Vq4UnVs= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal Subject: [RFC PATCH v2 2/8] libcamera: egl: Remove `eGL::surface_` Date: Mon, 10 Aug 2026 12:59:36 +0200 Message-ID: <20260810105942.1098192-3-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810105942.1098192-1-barnabas.pocze@ideasonboard.com> References: <20260810105942.1098192-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This member has always been unused, so remove it. Signed-off-by: Barnabás Pőcze Reviewed-by: Milan Zamazal --- include/libcamera/internal/egl.h | 1 - src/libcamera/egl.cpp | 8 -------- 2 files changed, 9 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index c43684808d..f8ae486a8d 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -133,7 +133,6 @@ private: EGLDisplay display_ = EGL_NO_DISPLAY; EGLContext context_ = EGL_NO_CONTEXT; - EGLSurface surface_ = EGL_NO_SURFACE; int compileShader(int shaderType, GLuint &shaderId, Span shaderData, Span shaderEnv); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 780b7bc2d5..900d2174df 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -57,11 +57,6 @@ LOG_DEFINE_CATEGORY(eGL) *\brief EGL context handle */ -/** - *\var eGL::surface_ - *\brief EGL sufrace handle - */ - /** * \brief Construct an EGL helper * \param[in] display The EGL display to use @@ -84,9 +79,6 @@ eGL::~eGL() { if (context_ != EGL_NO_CONTEXT) eglDestroyContext(display_, context_); - - if (surface_ != EGL_NO_SURFACE) - eglDestroySurface(display_, surface_); } /**