From patchwork Thu Aug 6 15:19:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 27666 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EE090C3306 for ; Thu, 6 Aug 2026 15:27:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F232C68179; Thu, 6 Aug 2026 17:27:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="fZ35vceW"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E69EE68171 for ; Thu, 6 Aug 2026 17:27:06 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-495757ccbc1so25192955e9.2 for ; Thu, 06 Aug 2026 08:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; t=1786030026; x=1786634826; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=In6KRTEPf+Ifx24CfZAVA1q3tf+YfA3zsnu6W8Tc46s=; b=fZ35vceWsfspnKm486oOFwwj2EHdo1jFW9apzG88zOVn3aX6f5Hn+kHjjvtlAtPbpi kJmKc4LRAoUlx4o8aV4JTjprAf5HvHLeXIDV7CxhN9jIKcKtxW9IzWjJrWxXnouThqtm Eme19OFExcxi3oIN7kD9oDLJA9p2xOXQHRpRr4xzy0QkS0CLTIVoQ+qP5nPKecN/wVoH Ji/fGVs0mNmiWDsCSZL/DycvAfHoSOCPBq9L6u+n4DRCi0bPpUMuajevj21YkuHc3aIg cK2ksvW5VA9gtDhgoxPaBWkT9o10EE0F7BS5Vgp+K5SEyBb2vtpA+7lsAIcELHbYyw9k aWHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786030026; x=1786634826; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=In6KRTEPf+Ifx24CfZAVA1q3tf+YfA3zsnu6W8Tc46s=; b=rRVUqeQtm9qUYZjD4qo6Cr8cDQ+ui0SQ/uUWIJMVi/uIaPr9cReZEbx74wWUOmV7ru GH0Cri1ufCDfYSeJG0J9hAmvqD79Ge1BCMJhDIrNKKCFDwieJhpI9ZTA6+2rgAYEPbHK STmRtRkOX24Ay69qbQL4SAJ7OJMGJo0UwA+YOl38OfneNOdmYI5h/lGwPVdmMro2f6jU 5CaWuNF2GLdQ8LObJf3Fv+Ha0gFbc440oE7KDVqGSDqELP9l5yItUUXlYsMakH+xqBUm bkPHMXP3tvzj5nKmhCVpVpScgkMGqXdmKhC7JeXRmw9YSo3DGGFA6aKLAqnc0fFDbgKE LfeQ== X-Gm-Message-State: AOJu0YwG7JY/MqvnZFn2QTL0nvc2MPEhTCtiGi/dbkTXD3nF+munjDKA /cWmHrSiDkRAMdARVQ+a/cw3bV48ZcAyD+hWrMBoKOX89/nJL+wNJgMax6Ti5+YzYEK+Zo2gx1A eTjKL X-Gm-Gg: AR+sD102+km4OG5RSgBMbGVKnm/4Ga5OxMH5NZx0G0vVUkv/AY7WeZLC4wEPfaFXeNS hUInolLQHjMb8+sTUDo/NHUuLD17OZpGNuTwXDKrsyq06dptqTsIZEbVIoiCcfzzQp/ZR/UkhNd dSvZfCHpF2/IuH5BvObmcLbUvrDXd5x5sxwNkwS+MRXU4taJLE/geHLhlNjfT5Iuict69NgoFn6 5E01FitWH1qxkpzOeMgLXwnXKAP6mBY775COUwCfvAhrvDv4XcAcyzEe7YUxKTi/tQkTUE9FkTZ G13UJyTh5IouodrNpru72vzy77eMRKLAoKAnPOVdml2Mb/o2ZI8Hpdlb9Y4YeZDo+Q3F1seUn6G hkB7KBay1x2b5Pk9xDXMeJkfrCICOAhqP9MQ4I08k19XBbSfJEm38eqGRnGDgM9z7RANw+RS7wd yAyVjwfol9EvqO5HcZQt4jel3H1Ow2vwwV0K5KQwM4K8taSfbEw3ibMH42v6qPaIFM71t72KPM+ uxmIFOf89jXfeBdiQGdpy40dC/P6N2r0gU64xTPyPQPcfmOpH6pwdiNtP2N4nSYMW2WxSljXzlI qhOm X-Received: by 2002:a05:600c:4514:b0:496:bbce:f3 with SMTP id 5b1f17b1804b1-4994e71ed7bmr199187455e9.6.1786030026443; Thu, 06 Aug 2026 08:27:06 -0700 (PDT) Received: from davidp-pi5.pitowers.org ([2a00:1098:3142:1f:4706:89ee:c47e:1087]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995428f294sm70769235e9.15.2026.08.06.08.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 08:27:05 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Cc: David Plowman , Naushir Patuck , Jacopo Mondi Subject: [PATCH v2 3/4] ipa: rpi: Update black level tuning for IMX662 Date: Thu, 6 Aug 2026 16:19:43 +0100 Message-ID: <20260806152701.4179-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260806152701.4179-1-david.plowman@raspberrypi.com> References: <20260806152701.4179-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" At very high gains, the measured black level increases noticeably from the nominal value of 3200. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Acked-by: Jacopo Mondi --- src/ipa/rpi/pisp/data/imx662.json | 11 ++++++++++- src/ipa/rpi/vc4/data/imx662.json | 11 ++++++++++- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/ipa/rpi/pisp/data/imx662.json b/src/ipa/rpi/pisp/data/imx662.json index b146d6b59..1aa5cf533 100644 --- a/src/ipa/rpi/pisp/data/imx662.json +++ b/src/ipa/rpi/pisp/data/imx662.json @@ -5,7 +5,16 @@ { "rpi.black_level": { - "black_level": 3200 + "black_level_func": + [ + 1.0, 3200, + 192.0, 3200, + 256.0, 3245, + 320.0, 3331, + 384.0, 3443, + 480.0, 3606, + 512.0, 3623 + ] } }, { diff --git a/src/ipa/rpi/vc4/data/imx662.json b/src/ipa/rpi/vc4/data/imx662.json index cec937d62..dc28b53c4 100644 --- a/src/ipa/rpi/vc4/data/imx662.json +++ b/src/ipa/rpi/vc4/data/imx662.json @@ -5,7 +5,16 @@ { "rpi.black_level": { - "black_level": 3200 + "black_level_func": + [ + 1.0, 3200, + 192.0, 3200, + 256.0, 3245, + 320.0, 3331, + 384.0, 3443, + 480.0, 3606, + 512.0, 3623 + ] } }, {